diff options
| author | Paulo Alcantara <pc@manguebit.com> | 2024-03-08 13:25:22 -0300 |
|---|---|---|
| committer | Pavel Shilovsky <pshilovsky@samba.org> | 2024-03-26 01:09:37 +0000 |
| commit | dac330136368a9b8d9ccf8227f56ea35de57a4d2 (patch) | |
| tree | 1d9193bfe093545322631971560f1d91ffc189bf | |
| parent | 73146385da0945c78af0fbdc08d2bf260db709d5 (diff) | |
| download | cifs-utils-dac330136368a9b8d9ccf8227f56ea35de57a4d2.tar.gz cifs-utils-dac330136368a9b8d9ccf8227f56ea35de57a4d2.tar.bz2 cifs-utils-dac330136368a9b8d9ccf8227f56ea35de57a4d2.zip | |
pam_cifscreds: fix warning on NULL arg passed to %s in pam_syslog()
Fix the following compiler warning with -Wformat-overflow in
cifscreds_pam_update():
pam_cifscreds.c: In function ‘cifscreds_pam_update’:
pam_cifscreds.c:340:83: warning: ‘%s’ directive argument is null
[-Wformat-overflow=]
340 | pam_syslog(ph, LOG_ERR, "error: Update credential key for %s: %s",
| ^~
Fixes: cbbcd6e71c0a ("cifscreds: create PAM module to insert credentials at login")
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
| -rw-r--r-- | pam_cifscreds.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pam_cifscreds.c b/pam_cifscreds.c index 5d99c2d..eb9851d 100644 --- a/pam_cifscreds.c +++ b/pam_cifscreds.c @@ -338,7 +338,7 @@ static int cifscreds_pam_update(pam_handle_t *ph, const char *user, const char * key_serial_t key = key_add(currentaddress, user, password, keytype); if (key <= 0) { pam_syslog(ph, LOG_ERR, "error: Update credential key for %s: %s", - currentaddress, strerror(errno)); + (currentaddress ?: "(null)"), strerror(errno)); } } |