summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-04-01mount.cifs: clean up setting of password fieldJeff Layton1-109/+84
Add a function to set and escape the password properly. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: eliminate "legacy" setuid behaviorJeff Layton1-81/+9
This behavior is demonstrably unsafe and not something we want to support going forward. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: eliminate some unneeded flags in parsed_mount_infoJeff Layton1-6/+1
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: parse unc into separate fieldsJeff Layton1-196/+179
The UNC is currently handled as a single string and mount.cifs will just munge it whenever it needs to change the delimiter type or uppercase it, etc. This is tricky to handle correctly and means that we often need to keep track of what's already been changed. Instead of doing this, just track the pieces of the UNC in separate fields in the parsed_mount_info, and then use those pieces to build strings as needed. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: add username and domain fields to parsed_mount_infoJeff Layton1-172/+116
...and fill and use them accordingly. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: make mountpassword a field in parsed_infoJeff Layton1-130/+78
...rather than a buffer pointed to by a global var Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: make parse_options return proper mount error codesJeff Layton1-16/+17
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: have parse_options fill parsed_mount_infoJeff Layton1-130/+89
Allocate a zeroed out parsed_mount_info struct and have parse_options put its info into that instead. realloc() is no longer used here and instead we just have the option parser carefully check that the result will fit in the buffer before copying it. We also no longer use snprintf to stuff info directly into the buffer. It may not be possible given the other checks, but snprintf can leave a non-NULL terminated string. Use strlcat everywhere instead to ensure that doesn't occur. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-04-01mount.cifs: declare new struct for holding parsed mount infoJeff Layton1-3/+23
Currently mount.cifs puts mount info into a disparate series of dynamically sized buffers. Declate a new struct that holds a set of fixed-size buffers. The option and UNC parsing routines can place their results in this struct. This should make it easier to implement privilege separation using shared memory to pass data between processes. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-23cifs-utils: release 4.1cifs-utils-4.1Jeff Layton1-1/+1
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-23mount.cifs: fix ver= option passed to the kernelJeff Layton1-1/+7
Rather than passing the VERSION string to the kernel in the ver= option, track the OPTIONS_VERSION separately and pass that to the kernel. If we ever need to have different behavior in kernel for different mount.cifs versions, we can bump this number. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: don't use exit(3) in get_password_from_fileJeff Layton1-7/+13
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: don't use exit(3) in mount_cifs_usage() and open_cred_file()Jeff Layton1-19/+23
...to help ensure that exit processing is handled appropriately. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: don't use exit(3) in main()Jeff Layton1-11/+19
Clean up error handling in main() so that cleanup tasks are completed rather than assuming exit processing will handle it. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: fix error handling when duplicating options stringJeff Layton1-2/+7
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: make check_mountpoint a noop for non-legacy buildsJeff Layton1-23/+8
Now that we chdir() to the mountpoint, the checks in that function are pointless. Just make it a noop for non-legacy setuid builds. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: remove uuid optionJeff Layton1-5/+0
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: remove bogus rsize/wsize optionsJeff Layton1-10/+0
They don't actually do anything. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: simplify command-line option parsingJeff Layton1-28/+8
Let getopt_long do the work of parsing options, then check what's left. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: remove unneeded uname callJeff Layton1-7/+0
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-22mount.cifs: clean up parse_serverJeff Layton1-69/+68
Get rid of a lot of unnecessary nesting. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-20mount.cifs: clean up preprocessor macrosJeff Layton1-17/+0
...remove some unneeded junk. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-20Update the READMEJeff Layton1-2/+9
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-20cifs-utils: switch to using autoconf package versionJeff Layton3-12/+5
Rather than using a hardcoded version string, use the VERSION macro that autoconf provides. This will help make it clear what version is actually being used in bug reports when someone runs "mount.cifs -V" or "cifs.upcall --version". Also, clean up AC_INIT and AM_INIT_AUTOMAKE macros. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-08autotools: make cifs.upcall dependent on an enable optionJeff Layton2-5/+48
Make it so that cifs.upcall is built by default, but autodisable it if the needed headers aren't present. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-07mount.cifs: check for NULL addr pointer before handling scopeidJeff Layton1-1/+1
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-03-03docs: these tools are no longer part of SambaMichael Wood4-12/+6
Remove references to samba(7). There's no cifs-utils(7) man page, so don't refer to one. Signed-off-by: Michael Wood <esiotrot@gmail.com>
2010-03-03docs: change source from Samba 3.6Michael Wood4-6/+6
These tools are no longer part of the Samba suite, so change the source to cifs-utils 4.0. Signed-off-by: Michael Wood <esiotrot@gmail.com>
2010-02-26autotools: check for keyutils.hcifs-utils-4.0Jeff Layton1-0/+1
...and throw a (hopefully) helpful error message if it's not present. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-26cifs.upcall: use non-legacy krb5.h locationJeff Layton2-3/+4
<krb5.h> is deprecated in favor of <krb5/krb5.h>. Also, make autoconf throw a more helpful error message if it's not present. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-20autotools: remove autogenerated files from git repocifs-utils-4.0rc1Jeff Layton2-990/+0
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-20autoconf: make sure C files include config.hJeff Layton5-25/+18
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-19autoconf: now it works with autoconf 2.59 (RHEL5)Igor Mammedov1-7/+3
suggest to install libtalloc-devel if talloc.h is missing
2010-02-16spnego.c: make sure to free talloc contextsJeff Layton1-2/+6
We're using talloc_init to get a context in these functions but they aren't freeing them. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-14automake: make sure to link cifs.upcall to keyutils Jeff Layton1-1/+1
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-14Don't make "configure" part of the repoJeff Layton1-7949/+0
2010-02-09autoconf: reshuffle header and function checkingJeff Layton1-3/+7
Make sure we bail out if necessary functions and headers aren't present. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-09cifs-utils: make sure -Wall is always set for buildsJeff Layton2-0/+2
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-09autoconf: bail out if talloc.h or krb5.h aren't presentJeff Layton2-12/+167
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-09autoconf: fix "quoting" around macro args in configure.acJeff Layton1-2/+2
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-09autoconf: add some missing files for the releaserelease-4-0a1cifs-utils-4.0a1Jeff Layton4-3/+1008
...we don't want people to have to run autoreconf on their own, so add them to the tree. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08silence some build warningsJeff Layton2-4/+4
mount.cifs.c: In function 'main': mount.cifs.c:1201: warning: 'dev_name' may be used uninitialized in this function mount.cifs.c:1217: warning: 'addr6' may be used uninitialized in this function asn1.c: In function 'ber_read_OID_String': asn1.c:591: warning: 'bytes_eaten' may be used uninitialized in this function Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08cifs.upcall: include util.hJeff Layton4-4/+6
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08Clean up ChangeLog and fix versioningJeff Layton0-0/+0
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08Add manpages to makefileJeff Layton1-0/+2
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08add autoconf check for talloc.hJeff Layton1-1/+1
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08Add checks for specific krb5 functionsJeff Layton1-1/+1
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08Add check for krb5.h.Jeff Layton1-3/+3
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08Add more docs...Jeff Layton3-0/+856
The client guide and manpage XML sources ...eventually we should add a way to build the manpages from XML Signed-off-by: Jeff Layton <jlayton@redhat.com>
2010-02-08add manpages for mount.cifs and cifs.upcallJeff Layton2-0/+576
...for now we just add them as regular troff manpages. Signed-off-by: Jeff Layton <jlayton@redhat.com>
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 11:32:26 +0000