summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-12-12Add program name to error output instead of static mount.cifsKenneth D'souza1-28/+28
As we are supporting mount.smb3 to be invoked, the error output should contain the called program and not mount.cifs Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-12-12Add support for smb3 alias/fstype in mount.cifs.cKenneth D'souza3-4/+20
As we will slowly move towards smb3 filesystem, supporting through "mount -t smb3" is important. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-12-12smbinfo.rst: document new `keys` commandAurelien Aptel1-0/+4
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
2019-12-12mount.cifs.rst: remove prefixpath mount option.Kenneth D'souza1-6/+0
This option is deprecated and currently ignored since kernel v3.10 Signed-off-by: Kenneth D'souza <kdsouza@redhat.com> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
2019-10-04smb2quota.rst: Add man page for smb2quota.pyKenneth D'souza1-0/+70
Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-10-04smb2quota.py: Userspace helper to display quota informationKenneth D'souza1-0/+195
Signed-off-by: Kenneth D'souza <kdsouza@redhat.com> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-10-03smbinfo: add bash completion support for setcompressionPavel Shilovsky1-1/+2
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-10-03smbinfo: Add SETCOMPRESSION supportRonnie Sahlberg2-1/+49
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-10-03smbinfo: print the security information needed to decrypt wireshark traceSteve French1-1/+52
CCM encryption Session Id: e2 3e ea ae 00 00 00 00 Session Key: 65 7e 0e d5 3c 06 5a 06 50 a3 ef 96 c1 64 3d 1f Server Encryption Key: 5e 42 a7 b5 57 75 d6 56 4a 5d 33 97 e6 45 07 76 Server Decryption Key: 1f 64 db a3 0f 24 e3 4d b6 31 00 ab 9a af 22 47 Signed-off-by: Steve French <stfrench@microsoft.com>
2019-10-03mount.cifs: Fix invalid freePaulo Alcantara (SUSE)1-4/+4
When attemping to chdir into non-existing directories, mount.cifs crashes. This patch fixes the following ASAN report: $ ./mount.cifs //localhost/foo /mnt/invalid-dir -o ... /mnt/bar -o username=foo,password=foo,vers=1.0 Couldn't chdir to /mnt/bar: No such file or directory ================================================================= ==11846==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x7ffd86332e97 in thread T0 #0 0x7f0860ca01e7 in __interceptor_free (/usr/lib64/libasan.so.5+0x10a1e7) #1 0x557edece9ccb in acquire_mountpoint (/home/paulo/src/cifs-utils/mount.cifs+0xeccb) #2 0x557edecea63d in main (/home/paulo/src/cifs-utils/mount.cifs+0xf63d) #3 0x7f08609f0bca in __libc_start_main (/lib64/libc.so.6+0x26bca) #4 0x557edece27d9 in _start (/home/paulo/src/cifs-utils/mount.cifs+0x77d9) Address 0x7ffd86332e97 is located in stack of thread T0 at offset 8951 in frame #0 0x557edece9ce0 in main (/home/paulo/src/cifs-utils/mount.cifs+0xece0) This frame has 2 object(s): [48, 52) 'rc' (line 1959) [64, 72) 'mountpoint' (line 1955) <== Memory access at offset 8951 overflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: bad-free (/usr/lib64/libasan.so.5+0x10a1e7) in __interceptor_free ==11846==ABORTING Fixes: bf7f48f4c7dc ("mount.cifs.c: fix memory leaks in main func") Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Reviewed-by: David Mulder <dmulder@suse.com>
2019-10-03mount.cifs: Fix double-free issue when mounting with setuid rootPaulo Alcantara (SUSE)1-2/+4
It can be easily reproduced with the following: # chmod +s `which mount.cifs` # echo "//localhost/share /mnt cifs \ users,username=foo,password=XXXX" >> /etc/fstab # su - foo $ mount /mnt free(): double free detected in tcache 2 Child process terminated abnormally. The problem was that check_fstab() already freed orgoptions pointer and then we freed it again in main() function. Fixes: bf7f48f4c7dc ("mount.cifs.c: fix memory leaks in main func") Signed-off-by: Paulo Alcantara (SUSE) <paulo@paulo.ac> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
2019-08-07Zero fill the allocated memory for new `struct cifs_ntsd`misku1-1/+1
Fixes a bug where `sacloffset` may not be set at all later on and therefore it can contain the original memory contents == trash.
2019-08-07Zero fill the allocated memory for a new ACEmisku1-1/+1
Fixes a bug inside a call to `verify_ace_flag`. When a flag string (char*) passed as a first parameter is "0x0", the final flag value (the second parameter - the value of a pointer to uint8_t) is not modified at all and contains the original memory contents == trash.
2019-08-07mount.cifs.c: fix memory leaks in main funcJiawen Liu1-1/+9
In mount.cifs module, orgoptions and mountpoint in the main func point to the memory allocated by func realpath and strndup respectively. However, they are not freed before the main func returns so that the memory leaks occurred. The memory leak problem is reported by LeakSanitizer tool. LeakSanitizer url: "https://github.com/google/sanitizers" Here I free the pointers orgoptions and mountpoint before main func returns. Fixes：7549ad5e7126 ("memory leaks: caused by func realpath and strndup") Signed-off-by: Jiawen Liu <liujiawen10@huawei.com> Reported-by: Jin Du <dujin1@huawei.com> Reviewed-by: Saisai Zhang <zhangsaisai@huawei.com> Reviewed-by: Aurélien Aptel <aaptel@suse.com>
2019-05-07smbinfo: add bash completion support for getcompressionPavel Shilovsky1-1/+2
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-05-07getcifsacl: Add support for -R(recursive) option.Kenneth D'souza2-5/+30
Add support for -R option so we can list the ACLs of all files and directories recursively. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-05-07smbinfo: add GETCOMPRESSION supportRonnie Sahlberg2-0/+50
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-04-18getcifsacl: Fix usage message to include multiple filesPavel Shilovsky1-2/+2
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-04-18smbinfo: Add bash completion support for smbinfo.Kenneth D'souza1-0/+42
This help us better populate options using <tab> <tab>. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-04-18getcifsacl: Add support to accept more pathsKenneth D'souza1-36/+44
Accept more than one path on the getcifsacl command line. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-04-17smbinfo: Improve help usage and add -h option.Kenneth D'souza2-6/+26
Call usage only for -h case. This avoids cluttering the screen with long help output. As we are adding more options to the utility, the end error is just hidden. Call short_usage wherever necessary. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-04-09secdesc-ui.py: a UI to view the security descriptors on SMB2+ sharesRonnie Sahlberg1-0/+436
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-04-08Update authors listPavel Shilovsky1-0/+1
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-04-05cifs-utils: bump version to 6.9cifs-utils-6.9Pavel Shilovsky1-1/+1
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-04-05smbinfo: use constant for input buffer lengthPavel Shilovsky1-3/+3
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-04-05Fix authors and maintainersPavel Shilovsky3-5/+6
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-04-05mount.cifs.rst: mention kernel version for snapshotsPavel Shilovsky1-1/+2
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-05Update man page for mount.cifs to add new optionsSteve French1-38/+60
Add description of "snapshot" and "handletimeout" mount options and a security section noting that the use of cifs is discouraged, and various minor updates. Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-05mount.cifs: detect GMT format of snapshot versionPavel Shilovsky1-7/+47
In order to provide an easy way to access snapshots a GMT token string should be allowed as a "snapshot" mount option argument, not SMB 100-nanoseconds time only. Detect if the argument is in GMT format and convert it to SMB 100-nanoseconds time before passing to the kernel. Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-05mount.cifs: add more options to help messagePavel Shilovsky1-5/+7
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-05mount.cifs Add various missing parms from the help textSteve French1-3/+11
When you type mount.cifs --help there were more than 40 mount parms missing. Add 12 of the more common ones to what is displayed by help. Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-05smbinfo: make argument order consistentPavel Shilovsky1-12/+12
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-05smbinfo: Add ability to query snapshots (previous versions)Steve French2-1/+109
"smbinfo list-snapshots" Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de>
2019-04-02smbinfo: missing help for fsctl-getobjidSteve French1-1/+3
Add usage description for new option fsctl-getobjid See section 2.1.3.1 of MS-FSCC Signed-off-by: Steve French <stfrench@microsoft.com>
2019-03-16cifs.upcall: fix a compiler warningPavel Shilovsky1-0/+1
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-03-16smbinfo: add fsctl-getobjid supportRonnie Sahlberg2-0/+75
This will print the ObjectID buffer for the object. This is an example on how to fetch FSCTL data for an object using the passthrough API. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-03-08smbinfo: fix code stylePavel Shilovsky1-592/+583
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-03-08setcifsacl: fix adding ACE when owner sid in unexpected locationSteve French1-5/+24
If owner information is after the ACEs instead of before (e.g. Azure servers) in the ACL query then we would get "invalid argument" returned on setcifsacl -a (adding an ACE). This fixes that. Signed-off-by: Steve French <stfrench@microsoft.com>
2019-03-08smbinfo: decode the ACEsRonnie Sahlberg2-34/+168
Decode the most common ACE types and provide a [-V]erbose option to show the individual mask bits by name. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-03-08getcifsacl: Improve help usage and add -h option.Kenneth D'souza1-9/+18
Call getcifsacl_usage only for -h and default case. For others error out with appropriate message. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-03-08getcifsacl: Do not go to parse_sec_desc if getxattr fails.Kenneth D'souza1-2/+6
Add more to the error message by printing the filename and error. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com> Reviewed-by: Steve French <stfrench@microsoft.com>
2019-02-15mount.cifs.rst: update vers=3.1.1 option descriptionPavel Shilovsky1-1/+1
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
2019-02-15Update mount.cifs with vers=default mount option and SMBv3.0.2Kenneth D'souza1-1/+5
Add vers=3.0.2 as a valid option for SMBv3.0.2 and explain behavior of vers=default. Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
2019-02-15Added rst2man.py to the search list.Hank Leininger1-1/+1
Gentoo Linux and (historically?) OSX install with the .py suffix. Signed-off-by: Hank Leininger <hlein@korelogic.com>
2019-02-14mount.cifs: be more verbose and helpful regarding mount errorsAurelien Aptel1-1/+11
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
2019-02-14cifs: Allow DNS resolver key to expirePaulo Alcantara2-23/+64
This patch introduces a new '--expire' option that allows the user to set a timeout value for the dns resolver key -- which is typically useful for hostnames that may get their ip addresses changed under long running mounts. The default timeout value is set to 10 minutes. Signed-off-by: Paulo Alcantara <palcantara@suse.de>
2019-02-14smbinfo: add FileFsFullSizeInformationRonnie Sahlberg2-0/+51
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-02-14smbinfo: Update the usage text with the new infolevelsRonnie Sahlberg1-1/+17
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
2019-02-14smbinfo: update help textSteve French1-0/+2
Add description for fileallinfo query option. Note that there are eight other recently added query options, but they are mostly a subset a "fileallinfo" so could be of little value (and may even be very confusing if we documented all nine in the help text in smbinfo, instead of just this one). The man page has a full description of them. Signed-off-by: Steve French <stfrench@microsoft.com>
2019-02-14smbinfo: Add more File*Information classesRonnie Sahlberg2-20/+497
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 21:23:04 +0000