From 92be8b6775958814d39fb19247ff85947a2e4f9e Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Mon, 16 Jan 2012 13:22:28 -0500 Subject: mount.cifs: handle errors from rename() in del_mtab The new del_mtab code ignored errors from rename(). Make it handle that error as well like it does other errors. Cc: Carlos Maiolino Signed-off-by: Jeff Layton --- mount.cifs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mount.cifs.c b/mount.cifs.c index af071c1..78a4811 100644 --- a/mount.cifs.c +++ b/mount.cifs.c @@ -1700,7 +1700,11 @@ del_mtab(char *mountpoint) goto del_mtab_error; } - rename(mtabtmpfile, MOUNTED); + if (rename(mtabtmpfile, MOUNTED)) { + fprintf(stderr, "del_mtab: error %d when renaming mtab in place\n", errno); + rc = EX_FILEIO; + goto del_mtab_error; + } del_mtab_exit: unlock_mtab(); -- cgit v1.2.3