From d1c43959212e335f7f46a7f53d6d8d8b734a7743 Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Mon, 26 Jul 2010 13:00:44 -0400 Subject: cifs.upcall: require a uid= or creduid= parm Even though all known kernels send the uid= parm to userspace, cifs.upcall doesn't technically require it. It should though. If one wasn't sent for some reason, then the setuid wouldn't occur. Error out if there is no uid= or creduid= parm. Signed-off-by: Jeff Layton --- cifs.upcall.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cifs.upcall.c b/cifs.upcall.c index 1f4341d..8f7850a 100644 --- a/cifs.upcall.c +++ b/cifs.upcall.c @@ -707,6 +707,11 @@ int main(const int argc, char *const argv[]) goto out; } ccname = find_krb5_cc(CIFS_DEFAULT_KRB5_DIR, arg.uid); + } else { + /* no uid= or creduid= parm -- something is wrong */ + syslog(LOG_ERR, "No uid= or creduid= parm specified"); + rc = 1; + goto out; } host = arg.hostname; -- cgit v1.2.3