linux.git/arch/tile/kernel/kgdb.c, branch v4.9.67 Clone of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git tile: Fix misspellings in comments. 2016-03-04T19:44:57+00:00 Adam Buchbinder adam.buchbinder@gmail.com 2016-03-04T19:22:24+00:00 35b90a2939a563df4b1f57f18dd925d6aa7cb38a Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com> [plus "uninitalization"] 
Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com>
Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com> [plus "uninitalization"]
tile kgdb: fix bug in copy to gdb regs, and optimize memset 2016-03-02T20:19:44+00:00 Chris Metcalf cmetcalf@ezchip.com 2016-01-25T20:05:34+00:00 77ef8f5177599efd0cedeb52c1950c1bd73fa5e3 David Binderman pointed out that we were doing a full memset() of the gdb register buffer and then doing a memcpy() to it that was almost as big. This commit optimizes that by only doing a memset() of the registers that are intended to be zero. While making this change I noticed that we were not copying the link register (LR, number 55) due to a fencepost error in commit f419e6f63c5a ("arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one"), and I've corrected that as well. Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com> 
David Binderman pointed out that we were doing a full memset()
of the gdb register buffer and then doing a memcpy() to it that
was almost as big.  This commit optimizes that by only doing a
memset() of the registers that are intended to be zero.

While making this change I noticed that we were not copying the
link register (LR, number 55) due to a fencepost error in commit
f419e6f63c5a ("arch: tile: kernel: kgdb.c: Use memcpy() instead of
pointer copy one by one"), and I've corrected that as well.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
tile: define a macro ktext_writable_addr to get writable kernel text address 2016-01-04T20:09:31+00:00 Zhigang Lu zlu@ezchip.com 2015-09-30T01:53:47+00:00 f419e6f63c5afea00d7c17ebf54f2d265f5c4d7e It is used by kgdb, ftrace, kprobe and jump label, so we factor this out into a helper routine. Reviewed-by: Chris Metcalf <cmetcalf@ezchip.com> Signed-off-by: Zhigang Lu <zlu@ezchip.com> Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com> 
It is used by kgdb, ftrace, kprobe and jump label, so we factor
this out into a helper routine.

Reviewed-by: Chris Metcalf <cmetcalf@ezchip.com>
Signed-off-by: Zhigang Lu <zlu@ezchip.com>
Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one 2014-11-12T19:27:10+00:00 Chen Gang gang.chen.5i5j@gmail.com 2014-11-12T02:11:31+00:00 a5c1cb63ddf400cf58c7d8aecd045049f6818279 Not only memcpy() is faster than pointer copy, but also let code more clearer and simple, which can avoid compiling warning (the original implementation copy registers by exceeding member array border). The related warning (with allmodconfig under tile): CC arch/tile/kernel/kgdb.o arch/tile/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs': arch/tile/kernel/kgdb.c:140:31: warning: iteration 53u invokes undefined behavior [-Waggressive-loop-optimizations] *(ptr++) = thread_regs->regs[reg]; ^ arch/tile/kernel/kgdb.c:139:2: note: containing loop for (reg = 0; reg <= TREG_LAST_GPR; reg++) ^ Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com> 
Not only memcpy() is faster than pointer copy, but also let code more
clearer and simple, which can avoid compiling warning (the original
implementation copy registers by exceeding member array border).

The related warning (with allmodconfig under tile):

    CC      arch/tile/kernel/kgdb.o
  arch/tile/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
  arch/tile/kernel/kgdb.c:140:31: warning: iteration 53u invokes undefined behavior [-Waggressive-loop-optimizations]
     *(ptr++) = thread_regs->regs[reg];
                                 ^
  arch/tile/kernel/kgdb.c:139:2: note: containing loop
    for (reg = 0; reg <= TREG_LAST_GPR; reg++)
    ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
tilegx: support KGDB 2013-09-03T18:51:26+00:00 Chris Metcalf cmetcalf@tilera.com 2013-08-28T23:53:17+00:00 8157107b13099d6eb2e8ccd00b9aba009c698c38 Enter kernel debugger at boot with: --hvd UART_1=1 --hvx kgdbwait --hvx kgdboc=ttyS1,115200 or at runtime with: echo ttyS1,115200 > /sys/module/kgdboc/parameters/kgdboc echo g > /proc/sysrq-trigger Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> 
Enter kernel debugger at boot with:
  --hvd UART_1=1 --hvx kgdbwait --hvx kgdboc=ttyS1,115200
or at runtime with:
  echo ttyS1,115200 > /sys/module/kgdboc/parameters/kgdboc
  echo g > /proc/sysrq-trigger

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>