linux.git/block/bio-integrity.c, branch v5.3.2

block/bio-integrity: fix a memory leak bug

2019-07-12T02:01:21+00:00

In bio_integrity_prep(), a kernel buffer is allocated through kmalloc() to
hold integrity metadata. Later on, the buffer will be attached to the bio
structure through bio_integrity_add_page(), which returns the number of
bytes of integrity metadata attached. Due to unexpected situations,
bio_integrity_add_page() may return 0. As a result, bio_integrity_prep()
needs to be terminated with 'false' returned to indicate this error.
However, the allocated kernel buffer is not freed on this execution path,
leading to a memory leak.

To fix this issue, free the allocated buffer before returning from
bio_integrity_prep().

Reviewed-by: Ming Lei 
Acked-by: Martin K. Petersen 
Signed-off-by: Wenwen Wang 
Signed-off-by: Jens Axboe

block/bio-integrity: use struct_size() in kmalloc()

2019-05-16T14:48:48+00:00

Use the new struct_size() helper to keep code simple.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Jackie Liu 
Signed-off-by: Jens Axboe

block: switch all files cleared marked as GPLv2 to SPDX tags

2019-04-30T22:11:57+00:00

All these files have some form of the usual GPLv2 boilerplate.  Switch
them to use SPDX tags instead.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove the bio_integrity_advance export

2018-12-16T15:33:57+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove the bioset_integrity_free export

2018-12-16T15:33:38+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove bio_rewind_iter()

2018-09-06T21:12:24+00:00

It is pointed that bio_rewind_iter() is one very bad API[1]:

1) bio size may not be restored after rewinding

2) it causes some bogus change, such as 5151842b9d8732 (block: reset
bi_iter.bi_done after splitting bio)

3) rewinding really makes things complicated wrt. bio splitting

4) unnecessary updating of .bi_done in fast path

[1] https://marc.info/?t=153549924200005&r=1&w=2

So this patch takes Kent's suggestion to restore one bio into its original
state via saving bio iterator(struct bvec_iter) in bio_integrity_prep(),
given now bio_rewind_iter() is only used by bio integrity code.

Cc: Dmitry Monakhov 
Cc: Hannes Reinecke 
Suggested-by: Kent Overstreet 
Acked-by: Kent Overstreet 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ming Lei 
Signed-off-by: Jens Axboe

block: move bio_integrity_{intervals,bytes} into blkdev.h

2018-07-26T21:49:41+00:00

This allows bio_integrity_bytes() to be called from drivers instead of
open coding it.

Acked-by: Martin K. Petersen 
Signed-off-by: Greg Edwards 
Signed-off-by: Jens Axboe

block: Convert bio_set to mempool_init()

2018-05-14T19:16:03+00:00

Minor performance improvement by getting rid of pointer indirections
from allocation/freeing fastpaths.

Signed-off-by: Kent Overstreet 
Signed-off-by: Jens Axboe

block: Fix __bio_integrity_endio() documentation

2018-01-17T16:59:33+00:00

Fixes: 4246a0b63bd8 ("block: add a bi_error field to struct bio")
Reviewed-by: Martin K. Petersen 
Signed-off-by: Bart Van Assche 
Signed-off-by: Jens Axboe

block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-06T19:03:12+00:00

mempool_destroy() already checks for a NULL value being passed in, this
eliminates duplicate checks.

This was caught by running make coccicheck M=block/ on linus' tree on
commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this
patch).

Reviewed-by: Kyle Fortin 
Acked-by: Martin K. Petersen 
Signed-off-by: Tim Hansen 
Signed-off-by: Jens Axboe