linux.git/block/partitions/efi.c, branch v4.15.8

partitions/efi: Fix integer overflow in GPT size calculation

2017-01-17T16:02:31+00:00

If a GUID Partition Table claims to have more than 2**25 entries, the
calculation of the partition table size in alloc_read_gpt_entries() will
overflow a 32-bit integer and not enough space will be allocated for the
table.

Nothing seems to get written out of bounds, but later efi_partition() will
read up to 32768 bytes from a 128 byte buffer, possibly OOPSing or exposing
information to /proc/partitions and uevents.

The problem exists on both 64-bit and 32-bit platforms.

Fix the overflow and also print a meaningful debug message if the table
size is too large.

Signed-off-by: Alden Tondettar 
Acked-by: Ard Biesheuvel 
Signed-off-by: Jens Axboe

treewide: Fix typos in printk

2016-04-18T09:23:24+00:00

This patch fix spelling typos found in printk
within various part of the kernel sources.

Signed-off-by: Masanari Iida 
Acked-by: Randy Dunlap 
Signed-off-by: Jiri Kosina

efi: Rename efi_guid_unparse to efi_guid_to_str

2015-01-08T03:07:44+00:00

Call it what it does - "unparse" is plain-misleading.

Signed-off-by: Borislav Petkov 
Signed-off-by: Ricardo Neri

block/partitions/efi.c: kerneldoc fixing

2014-07-01T16:40:05+00:00

Adding function documentation and fixing kerneldoc warnings
('field: description' uniformization).

Cc: Davidlohr Bueso 
Cc: Jens Axboe 
Signed-off-by: Fabian Frederick 
Signed-off-by: Jens Axboe

block/partitions/efi.c: fix bound check

2013-11-22T00:42:27+00:00

Use ARRAY_SIZE instead of sizeof to get proper max for label length.

Since this is just a read out of bounds it's not that bad, but the
problem becomes user-visible eg if one tries to use DEBUG_PAGEALLOC and
DEBUG_RODATA, at least with some enhancements from Hiroshi.  Of course
the destination array can contain garbage when we read beyond the end of
source array so that would be another user-visible problem.

Signed-off-by: Antti P Miettinen 
Reviewed-by: Hiroshi Doyu 
Tested-by: Hiroshi Doyu 
Cc: Will Drewry 
Cc: Matt Fleming 
Acked-by: Davidlohr Bueso 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

block/partitions/efi.c: treat size mismatch as a warning, not an error

2013-10-17T04:35:53+00:00

In commit 27a7c642174e ("partitions/efi: account for pmbr size in lba")
we started treating bad sizes in lba field of the partition that has the
0xEE (GPT protective) as errors.

However, we may run into these "bad sizes" in the real world if someone
uses dd to copy an image from a smaller disk to a bigger disk.  Since
this case used to work (even without using force_gpt), keep it working
and treat the size mismatch as a warning instead of an error.

Reported-by: Josh Triplett 
Reported-by: Sean Paul 
Signed-off-by: Doug Anderson 
Reviewed-by: Josh Triplett 
Acked-by: Davidlohr Bueso 
Tested-by: Artem Bityutskiy 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

partitions/efi: loosen check fot pmbr size in lba

2013-09-15T11:10:16+00:00

Matt found that commit 27a7c642174e ("partitions/efi: account for pmbr
size in lba") caused his GPT formatted eMMC device not to boot.  The
reason is that this commit enforced Linux to always check the lesser of
the whole disk or 2Tib for the pMBR size in LBA.  While most disk
partitioning tools out there create a pMBR with these characteristics,
Microsoft does not, as it always sets the entry to the maximum 32-bit
limitation - even though a drive may be smaller than that[1].

Loosen this check and only verify that the size is either the whole disk
or 0xFFFFFFFF.  No tool in its right mind would set it to any value
other than these.

[1] http://thestarman.pcministry.com/asm/mbr/GPT.htm#GPTPT

Reported-and-tested-by: Matt Porter 
Signed-off-by: Davidlohr Bueso 
Signed-off-by: Linus Torvalds

block/partitions/efi.c: consistently use pr_foo()

2013-09-11T22:59:19+00:00

Cc: Davidlohr Bueso 
Cc: Karel Zak 
Cc: Matt Fleming 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

partitions/efi: some style cleanups

2013-09-11T22:59:19+00:00

Trivial coding style cleanups - still plenty left.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Davidlohr Bueso 
Reviewed-by: Karel Zak 
Acked-by: Matt Fleming 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

partitions/efi: compare first and last usable LBAs

2013-09-11T22:59:18+00:00

When verifying GPT header integrity, make sure that first usable LBA is
smaller than last usable LBA.

Signed-off-by: Davidlohr Bueso 
Reviewed-by: Karel Zak 
Acked-by: Matt Fleming 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds