linux.git/block/sed-opal.c, branch v4.14.1

block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled

2017-09-11T15:45:52+00:00

Users who are booting off their Opal enabled drives are having
issues when they have a shadow MBR set up after s3/resume cycle.
When the Drive has a shadow MBR setup the MBRDone flag is set to
false upon power loss (S3/S4/S5). When the MBRDone flag is false
I/O to LBA 0 -> LBA_END_MBR are remapped to the shadow mbr
of the drive. If the drive contains useful data in the 0 -> end_mbr
range upon s3 resume the user can never get to that data as the
drive will keep remapping it to the MBR. To fix this when we unlock
on S3 resume, we need to tell the drive that we're done with the
shadow mbr (even though we didnt use it) by setting true to MBRDone.
This way the drive will stop the remapping and the user can access
their data.

Acked-by Jon Derrick: 
Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block: sed-opal: Tone down all the pr_* to debugs

2017-04-07T20:24:16+00:00

Lets not flood the kernel log with messages unless
the user requests so.

Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: fix spelling mistake: "Lifcycle" -> "Lifecycle"

2017-03-30T15:22:53+00:00

trivial fix to spelling mistake in pr_err error message

Signed-off-by: Colin Ian King 
Signed-off-by: Jens Axboe

block/sed: Fix opal user range check and unused variables

2017-03-08T16:56:12+00:00

Fixes check that the opal user is within the range, and cleans up unused
method variables.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: Propagate original error message to userland.

2017-02-23T18:55:44+00:00

During an error on a comannd, ex: user provides wrong pw to unlock
range, we will gracefully terminate the opal session. We want to
propagate the original error to userland instead of the result of
the session termination, which is almost always a success.

Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: Introduce free_opal_dev to free the structure and clean up state

2017-02-23T18:55:41+00:00

Before we free the opal structure we need to clean up any saved
locking ranges that the user had told us to unlock from a suspend.

Signed-off-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Embed function data into the function sequence

2017-02-22T18:54:49+00:00

By embedding the function data with the function sequence, we can
eliminate the external function data and state variable code. It also
made obvious some other small cleanups.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed: Check received header lengths

2017-02-22T18:54:49+00:00

Add a buffer size check against discovery and response header lengths
before we loop over their buffers.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Add helper to qualify response tokens

2017-02-22T18:54:49+00:00

Add helper which verifies the response token is valid and matches the
expected value. Merges token_type and response_get_token.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Use ssize_t on atom parsers to return errors

2017-02-22T18:54:49+00:00

The short atom parser can return an errno from decoding but does not
currently return the error as a signed value. Convert all of the parsers
to ssize_t.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe