linux.git/crypto/scatterwalk.c, branch v4.18.12

crypto: scatterwalk - Remove unnecessary aliasing check in map_and_copy

2016-11-22T07:02:25+00:00

The aliasing check in map_and_copy is no longer necessary because
the IPsec ESP code no longer provides an IV that points into the
actual request data.  As this check is now triggering BUG checks
due to the vmalloced stack code, I'm removing it.

Reported-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: scatterwalk - Inline start/map/done

2016-07-18T09:35:50+00:00

This patch inlines the functions scatterwalk_start, scatterwalk_map
and scatterwalk_done as they're all tiny and mostly used by the block
cipher walker.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Remove unnecessary BUG in scatterwalk_start

2016-07-18T09:35:50+00:00

Nothing bad will happen even if sg->length is zero, so there is
no point in keeping this BUG_ON in scatterwalk_start.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Remove unnecessary advance in scatterwalk_pagedone

2016-07-18T09:35:50+00:00

The offset advance in scatterwalk_pagedone not only is unnecessary,
but it was also buggy when it was needed by scatterwalk_copychunks.
As the latter has long ago been fixed to call scatterwalk_advance
directly, we can remove this unnecessary offset adjustment.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Fix test in scatterwalk_done

2016-07-18T09:35:49+00:00

When there is more data to be processed, the current test in
scatterwalk_done may prevent us from calling pagedone even when
we should.

In particular, if we're on an SG entry spanning multiple pages
where the last page is not a full page, we will incorrectly skip
calling pagedone on the second last page.

This patch fixes this by adding a separate test for whether we've
reached the end of a page.

Cc: stable@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: scatterwalk - Add no-copy support to copychunks

2016-07-18T09:35:48+00:00

The function ablkcipher_done_slow is pretty much identical to
scatterwalk_copychunks except that it doesn't actually copy as
the processing hasn't been completed yet.

This patch allows scatterwalk_copychunks to be used in this case
by specifying out == 2.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Remove scatterwalk_bytes_sglen

2016-07-18T09:35:48+00:00

This patch removes the now unused scatterwalk_bytes_sglen.  Anyone
using this out-of-tree should switch over to sg_nents_for_len.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Hide PageSlab call to optimise away flush_dcache_page

2015-06-03T02:51:25+00:00

On architectures where flush_dcache_page is not needed, we will
end up generating all the code up to the PageSlab call.  This is
because PageSlab operates on a volatile pointer and thus cannot
be optimised away.

This patch works around this by checking whether flush_dcache_page
is needed before we call PageSlab which then allows PageSlab to be
compiled awy.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Add missing sg_init_table to scatterwalk_ffwd

2015-05-28T03:23:17+00:00

We need to call sg_init_table as otherwise the first entry may
inadvertently become the last.

Signed-off-by: Herbert Xu

crypto: scatterwalk - Check for same address in map_and_copy

2015-05-22T03:25:55+00:00

This patch adds a check for in scatterwalk_map_and_copy to avoid
copying from the same address to the same address.  This is going
to be used for IV copying in AEAD IV generators.

There is no provision for partial overlaps.

This patch also uses the new scatterwalk_ffwd instead of doing
it by hand in scatterwalk_map_and_copy.

Signed-off-by: Herbert Xu