linux.git/drivers/amba, branch v4.9.332

ARM: 9120/1: Revert "amba: make use of -1 IRQs warn"

2021-11-12T12:18:01+00:00

commit eb4f756915875b0ea0757751cd29841f0504d547 upstream.

After commit 77a7300abad7 ("of/irq: Get rid of NO_IRQ usage"),
no irq case has been removed, irq_of_parse_and_map() will return
0 in all cases when get error from parse and map an interrupt into
linux virq space.

amba_device_register() is only used on no-DT initialization, see
  s3c64xx_pl080_init()		arch/arm/mach-s3c/pl080.c
  ep93xx_init_devices()		arch/arm/mach-ep93xx/core.c

They won't set -1 to irq[0], so no need the warn.

This reverts commit 2eac58d5026e4ec8b17ff8b62877fea9e1d2f1b3.

Reviewed-by: Rob Herring 
Signed-off-by: Kefeng Wang 
Signed-off-by: Russell King (Oracle) 
Signed-off-by: Greg Kroah-Hartman

amba: Fix resource leak for drivers without .remove

2021-03-03T16:44:38+00:00

[ Upstream commit de5d7adb89367bbc87b4e5ce7afe7ae9bd86dc12 ]

Consider an amba driver with a .probe but without a .remove callback (e.g.
pl061_gpio_driver). The function amba_probe() is called to bind a device
and so dev_pm_domain_attach() and others are called. As there is no remove
callback amba_remove() isn't called at unbind time however and so calling
dev_pm_domain_detach() is missed and the pm domain keeps active.

To fix this always use the core driver callbacks and handle missing amba
callbacks there. For probe refuse registration as a driver without probe
doesn't make sense.

Fixes: 7cfe249475fd ("ARM: AMBA: Add pclk support to AMBA bus infrastructure")
Reviewed-by: Ulf Hansson 
Reviewed-by: Arnd Bergmann 
Link: https://lore.kernel.org/r/20210126165835.687514-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Sasha Levin

ARM: amba: Don't read past the end of sysfs "driver_override" buffer

2018-05-01T22:13:08+00:00

commit d2ffed5185df9d8d9ccd150e4340e3b6f96a8381 upstream.

When printing the driver_override parameter when it is 4095 and 4094
bytes long, the printing code would access invalid memory because we
need count + 1 bytes for printing.

Cfr. commits 4efe874aace57dba ("PCI: Don't read past the end of sysfs
"driver_override" buffer") and bf563b01c2895a4b ("driver core: platform:
Don't read past the end of "driver_override" buffer").

Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device binding path 'driver_override'")
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Todd Kjos 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

ARM: amba: Fix race condition with driver_override

2018-05-01T22:13:08+00:00

commit 6a7228d90d42bcacfe38786756ba62762b91c20a upstream.

The driver_override implementation is susceptible to a race condition
when different threads are reading vs storing a different driver
override.  Add locking to avoid this race condition.

Cfr. commits 6265539776a0810b ("driver core: platform: fix race
condition with driver_override") and 9561475db680f714 ("PCI: Fix race
condition with driver_override").

Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device binding path 'driver_override'")
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Todd Kjos 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Greg Kroah-Hartman

ARM: amba: Make driver_override output consistent with other buses

2018-05-01T22:13:08+00:00

commit 5f53624662eaac89598641cee6cd54fc192572d9 upstream.

For AMBA devices with unconfigured driver override, the
"driver_override" sysfs virtual file is empty, while it contains
"(null)" for platform and PCI devices.

Make AMBA consistent with other buses by dropping the test for a NULL
pointer.

Note that contrary to popular belief, sprintf() handles NULL pointers
fine; they are printed as "(null)".

Signed-off-by: Geert Uytterhoeven 
Cc: stable 
Reviewed-by: Todd Kjos 
Signed-off-by: Greg Kroah-Hartman

ARM: 8596/1: amba: Support clk parents and rates assigned in DT

2016-08-12T15:47:07+00:00

Add the call to of_clk_set_defaults() into the amba probe path so
that devices on the amba bus can use the assigned rates and
parents feature of the common clock framework.

Cc: Michael Turquette 
Tested-by: Jorge Ramirez Ortiz 
Signed-off-by: Stephen Boyd 
Signed-off-by: Russell King

ARM: 8566/1: drivers: amba: properly handle devices with power domains

2016-05-05T18:00:40+00:00

To read pid/cid registers, the probed device need to be properly turned on.
When it is inside a power domain, the bus code should ensure that the
given power domain is enabled before trying to access device's registers.
However in some cases power domain (or clocks) might not be yet available.
Returning -EPROBE_DEFER is not a solution in such case, because callers
don't handle this special error code. Instead such devices are added to the
special list and their registration is retried from periodic worker until
all resources are available.

Signed-off-by: Marek Szyprowski 
Signed-off-by: Russell King

amba: Hide TEGRA_AHB symbol

2015-11-24T15:47:25+00:00

The symbol depends on ARCH_TEGRA and will default to y. There are no
circumstances under which it is desirable to disable this option.

Signed-off-by: Thierry Reding

ARM: 8334/1: amba: tegra-ahb: detect and correct bogus base address

2015-04-02T09:03:55+00:00

amba: tegra-ahb: detect and correct bogus base address

From a hardware SoC integration point of view, the starting address of
this IP block in the existing Tegra SoC DT files is off by 4 bytes
from the actual base address.  Since we attempt to make old DT files
forward-compatible with newer kernels, we cannot fix the IP block base
address in old DT data. This patch works around the problem by
detecting the four byte base address offset in the driver code, and
correcting it if it's detected.  (In general, IP block base addresses
almost always have a null low byte.)

Future SoC DT data for Tegra AHB should use the correct Tegra AHB base
address, in cases where there is no DT data backward compatibility
requirement.

This patch is a revision of the patch originally titled
"amba: tegra-ahb: use correct base address for future chip support".
This revision implements changes requested by Russell King:

http://marc.info/?l=linux-tegra&m=142658851825062&w=2
http://marc.info/?l=linux-tegra&m=142658873925178&w=2

Signed-off-by: Paul Walmsley 
Cc: Paul Walmsley 
Cc: Alexandre Courbot 
Cc: Hiroshi DOYU 
Cc: Stephen Warren 
Cc: Thierry Reding 
Cc: linux-kernel@vger.kernel.org
Acked-by: Stephen Warren 
Signed-off-by: Russell King

ARM: 8333/1: amba: tegra-ahb: fix register offsets in the macros

2015-04-02T09:03:55+00:00

amba: tegra-ahb: fix register offsets in the macros

From a hardware SoC integration point of view, the offsets of the
Tegra AHB registers that are currently defined in tegra-ahb.c macros
are all off by four bytes.  Similarly, the starting address of this IP
block in our existing DT files is also off by four bytes.  Since we
attempt to make old DT files forward-compatible with newer kernels, we
cannot fix the IP block base address in old DT data.  However, we can
fix the offsets in the driver so that they are correct with respect to
the hardware, which is what this patch does.  And a subsequent patch
will allow the offset to be removed for DT 'compatible' strings used
in future DT files for newer Tegra chips that the kernel does not yet
support.

Signed-off-by: Paul Walmsley 
Cc: Paul Walmsley 
Cc: Alexandre Courbot 
Cc: Hiroshi DOYU 
Cc: Stephen Warren 
Cc: Thierry Reding 
Cc: linux-kernel@vger.kernel.org
Acked-by: Stephen Warren 
Signed-off-by: Russell King