linux.git/drivers/block/cciss.c, branch v2.6.22-rc4

cciss: Fix pci_driver.shutdown while device is still active

2007-05-19T04:03:49+00:00

Fix an Oops in the cciss driver caused by system shutdown while a filesystem
on a cciss device is still active.  The cciss_remove_one function only
properly removes the device if the device has been cleanly released by its
users, which is not the case when the pci_driver.shutdown method is called.

This patch adds a new cciss_shutdown function to better match the pattern
used by various SCSI drivers: deactivate device interrupts and flush caches.
It also alters the cciss_remove_one function to match and readds the
__devexit annotation that was removed when cciss_remove_one was serving as
the pci_driver.shutdown method.

Signed-off-by: Gerald Britton 
Acked-by: Mike Miller 
Signed-off-by: Linus Torvalds

cciss: include scsi/scsi.h unconditionally

2007-05-08T18:15:10+00:00

Make cciss unconditionally include scsi/scsi.h, because of the use of
SCSI_IOCTL_GET_IDLUN and SCSI_IOCTL_GET_BUS_NUMBER.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cciss: set rq->errors more correctly in driver

2007-05-08T18:15:09+00:00

Set rq->errors more correctly in cciss driver.  Previously we had set it
synonymously with the meaning of the last parameter of end_that_last_request
and complete_buffers (the "uptodate" parameter) and had gotten away with it
for all this time because nobody ever looked at rq->errors.
SCSI_IOCTL_SEND_COMMAND looks at rq->errors, so now it matters that it be
right.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: Mike Miller 
Cc: James Bottomley 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cciss: add SG_IO ioctl to cciss

2007-05-08T18:15:09+00:00

For all of you that think cciss should be a scsi driver here is the patch that
you have been waiting for all these years. This patch actually adds the SG_IO
ioctl to cciss. The primary purpose is for clustering and high-availibilty.
But now anyone can exploit this ioctl in any manner they wish.

Note, SCSI_IOCTL_SEND_COMMAND doesn't work with this patch due to rq->errors
being set incorrectly.  Subsequent patch fixes that.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: Mike Miller 
Cc: James Bottomley 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cciss: reformat error handling

2007-05-08T18:15:09+00:00

Reformat some error handling code to reduce line lengths a bit.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: Mike Miller 
Cc: James Bottomley 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] cciss: unregister from SCSI before tearing down device resources

2007-04-12T22:31:42+00:00

We must unregister from SCSI before we unmap device resources and unhook
the IRQ handler.  Otherwise, SCSI may send us more requests, and we won't
be able to handle them.

I see the following oops during every reboot of my HP DL360:

    ...
    Unmounting local filesystems...done.
    Rebooting... Completed flushing cache on controller 0
    BUG: unable to handle kernel paging request at virtual address f8808040
     printing eip:
    c02dc72b
    *pde = 02120067
    *pte = 00000000
    Oops: 0002 [#1]
    SMP
    Modules linked in:
    CPU:    1
    EIP:    0060:[]    Not tainted VLI
    EFLAGS: 00010046   (2.6.21-rc6 #1)
    EIP is at SA5_submit_command+0xb/0x20
    eax: f8808000   ebx: f7a00000   ecx: f79f0000   edx: 37a00000
    esi: f79f0000   edi: 00000000   ebp: 00000000   esp: dd717a44
    ds: 007b   es: 007b   fs: 00d8  gs: 0000  ss: 0068
    Process khelper (pid: 1427, ti=dd716000 task=c2260a70 task.ti=dd716000)
    Stack: c02df2c0 f7a00000 f7a00000 00d41008 c02df691 00000000 00000010 00000002
	   00000001 f79f0000 f7fff844 c1398420 00000000 00000000 00001000 230a3020
	   69666564 5420656e 50434f49 465f544b 4853554c 44414552 0a312009 66656423
    Call Trace:
     [] start_io+0x80/0x120
     [] do_cciss_request+0x331/0x350
     [] mempool_alloc+0x2a/0xe0
     [] blk_alloc_request+0x61/0x80
     [] get_request+0x15e/0x1e0
     [] cache_alloc_refill+0xb0/0x1e0
     [] as_update_rq+0x2d/0x80
     [] as_add_request+0x68/0x90
     [] elv_insert+0x119/0x160
     [] __make_request+0xcb/0x320
     [] lock_timer_base+0x20/0x50
     [] del_timer+0x56/0x60
     [] blk_remove_plug+0x38/0x70
     [] __generic_unplug_device+0x25/0x30
     [] generic_unplug_device+0x15/0x30
    ...

Signed-off-by: Bjorn Helgaas 
Acked-by: Mike Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] cciss: add init of drv->cylinders back to cciss_geometry_inquiry

2007-04-05T04:12:47+00:00

This patch adds initialization of drv->cylinders back into the failing case in
cciss_geometry_inquiry. I inadvertently removed it in one my 2TB updates.

Signed-off-by: Mike Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] cciss endian annotations

2007-03-14T22:27:50+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[PATCH] cciss: add struct pci_driver shutdown support (replaces reboot notifier)

2007-03-06T17:30:25+00:00

This patch adds support for the struct pci_driver shutdown method to cciss.
 We require notification of an impending reboot or shutdown so that we can
flush the battery backed write cache (BBWC) on the Smart Array controller.

Signed-off-by: Mike Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] cciss: fix for 2TB support

2007-03-06T17:30:25+00:00

This patch changes the way we determine if a logical volume is larger than
2TB.

The original test looked for a total_size of 0.  Originally we added 1 to the
total_size.  That would make our read_capacity return size 0 for >2TB lv's.
We assumed that we could not have a lv size of 0 so it seemed OK until we were
in a clustered system.  The backup node would see a size of 0 due to the
reservation on the drive.  That caused the driver to switch to 16-byte CDB's
which are not supported on older controllers.  After that everything was
broken.

It may seem petty but I don't see the value in trying to determine if the LBA
is beyond the 2TB boundary.  That's why when we switch we use 16-byte CDB's
for all read/write operations.  Please consider this for inclusion.

Signed-off-by: Mike Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds