linux.git/drivers/edac, branch v5.18

EDAC/synopsys: Read the error count from the correct register

2022-04-14T12:44:49+00:00

Currently, the error count is read wrongly from the status register. Read
the count from the proper error count register (ERRCNT).

  [ bp: Massage. ]

Fixes: b500b4a029d5 ("EDAC, synopsys: Add ECC support for ZynqMP DDR controller")
Signed-off-by: Shubhrajyoti Datta 
Signed-off-by: Borislav Petkov 
Acked-by: Michal Simek 
Cc: 
Link: https://lore.kernel.org/r/20220414102813.4468-1-shubhrajyoti.datta@xilinx.com

Merge branch 'edac-amd64' into edac-updates-for-v5.18

2022-03-21T09:34:57+00:00

Signed-off-by: Borislav Petkov

EDAC/altera: Add SDRAM ECC check for U-Boot

2022-03-16T08:56:39+00:00

A bug in legacy U-Boot causes a crash during SDRAM boot if ECC is not
enabled in the bitstream but enabled in the Linux config.

Memory mapped read of the ECC Enabled bit was only enabled if U-Boot
determined ECC was enabled in the bitstream.

The Linux driver checks the ECC enable bit using a memory map read.
In the ECC disabled bitstream case, U-Boot didn't enable ECC register
memory map reads and since they are not allowed this results in a crash.

Always read the ECC Enable register through a SMC call which is always
allowed and it works with legacy and current U-Boot.

  [ bp: Massage commit message. ]

Signed-off-by: Rabara Niravkumar L 
Signed-off-by: Borislav Petkov 
Acked-by: Dinh Nguyen 
Link: https://lore.kernel.org/r/20220305014118.4794-1-niravkumar.l.rabara@intel.com

EDAC/amd64: Add new register offset support and related changes

2022-02-23T21:01:33+00:00

Introduce a "family flags" bitmask that can be used to indicate any
special behavior needed on a per-family basis.

Add a flag to indicate a system uses the new register offsets introduced
with Family 19h Model 10h.

Use this flag to account for register offset changes, a new bitfield
indicating DDR5 use on a memory controller, and to set the proper number
of chip select masks.

Rework f17_addr_mask_to_cs_size() to properly handle the change in chip
select masks. And update code comments to reflect the updated Chip
Select, DIMM, and Mask relationships.

[uninitialized variable warning]
Reported-by: kernel test robot 
Signed-off-by: Yazen Ghannam 
Signed-off-by: Borislav Petkov 
Reviewed-by: William Roche 
Link: https://lore.kernel.org/r/20220202144307.2678405-3-yazen.ghannam@amd.com

EDAC/amd64: Set memory type per DIMM

2022-02-23T20:53:45+00:00

Current AMD systems allow mixing of DIMM types within a system. However,
DIMMs within a channel, i.e. managed by a single Unified Memory
Controller (UMC), must be of the same type.

Handle this possible configuration by checking and setting the memory
type for each individual "UMC" structure.

Signed-off-by: Yazen Ghannam 
Signed-off-by: Borislav Petkov 
Reviewed-by: William Roche 
Link: https://lore.kernel.org/r/20220202144307.2678405-2-yazen.ghannam@amd.com

EDAC: Fix calculation of returned address and next offset in edac_align_ptr()

2022-02-15T14:54:46+00:00

Do alignment logic properly and use the "ptr" local variable for
calculating the remainder of the alignment.

This became an issue because struct edac_mc_layer has a size that is not
zero modulo eight, and the next offset that was prepared for the private
data was unaligned, causing an alignment exception.

The patch in Fixes: which broke this actually wanted to "what we
actually care about is the alignment of the actual pointer that's about
to be returned." But it didn't check that alignment.

Use the correct variable "ptr" for that.

  [ bp: Massage commit message. ]

Fixes: 8447c4d15e35 ("edac: Do alignment logic properly in edac_align_ptr()")
Signed-off-by: Eliav Farber 
Signed-off-by: Borislav Petkov 
Cc: 
Link: https://lore.kernel.org/r/20220113100622.12783-2-farbere@amazon.com

EDAC/xgene: Fix deferred probing

2022-01-30T00:06:35+00:00

The driver overrides error codes returned by platform_get_irq_optional()
to -EINVAL for some strange reason, so if it returns -EPROBE_DEFER, the
driver will fail the probe permanently instead of the deferred probing.
Switch to propagating the proper error codes to platform driver code
upwards.

  [ bp: Massage commit message. ]

Fixes: 0d4429301c4a ("EDAC: Add APM X-Gene SoC EDAC driver")
Signed-off-by: Sergey Shtylyov 
Signed-off-by: Borislav Petkov 
Cc: 
Link: https://lore.kernel.org/r/20220124185503.6720-3-s.shtylyov@omp.ru

EDAC/altera: Fix deferred probing

2022-01-28T20:38:46+00:00

The driver overrides the error codes returned by platform_get_irq() to
-ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the
driver will fail the probe permanently instead of the deferred probing.
Switch to propagating the proper error codes to platform driver code
upwards.

  [ bp: Massage commit message. ]

Fixes: 71bcada88b0f ("edac: altera: Add Altera SDRAM EDAC support")
Signed-off-by: Sergey Shtylyov 
Signed-off-by: Borislav Petkov 
Acked-by: Dinh Nguyen 
Cc: 
Link: https://lore.kernel.org/r/20220124185503.6720-2-s.shtylyov@omp.ru

EDAC/mc: Remove unnecessary cast to char * in edac_align_ptr()

2022-01-26T18:42:09+00:00

Remove the forgotten (char *) casts as that function returns void *.

  [ bp: Rewrite commit message. ]

Signed-off-by: Eliav Farber 
Signed-off-by: Borislav Petkov 
Link: https://lore.kernel.org/r/20220113100622.12783-3-farbere@amazon.com

EDAC: Use default_groups in kobj_type

2022-01-23T19:01:29+00:00

There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field. Move the edac sysfs code to use default_groups field which has
been the preferred way since

  aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type")

so that the obsolete default_attrs field can be removed soon.

Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Borislav Petkov 
Link: https://lore.kernel.org/r/20220104112401.1067148-2-gregkh@linuxfoundation.org