linux.git/drivers/extcon, branch v5.4.63

extcon: adc-jack: Fix an error handling path in 'adc_jack_probe()'

2020-06-24T15:50:36+00:00

[ Upstream commit bc84cff2c92ae5ccb2c37da73756e7174b1b430f ]

In some error handling paths, a call to 'iio_channel_get()' is not balanced
by a corresponding call to 'iio_channel_release()'.

This can be achieved easily by using the devm_ variant of
'iio_channel_get()'.

This has the extra benefit to simplify the remove function.

Fixes: 19939860dcae ("extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin

extcon: axp288: Add wakeup support

2020-04-08T07:08:43+00:00

commit 9c94553099efb2ba873cbdddfd416a8a09d0e5f1 upstream.

On devices with an AXP288, we need to wakeup from suspend when a charger
is plugged in, so that we can do charger-type detection and so that the
axp288-charger driver, which listens for our extcon events, can configure
the input-current-limit accordingly.

Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Greg Kroah-Hartman

extcon-intel-cht-wc: Don't reset USB data connection at probe

2020-02-01T09:34:46+00:00

[ Upstream commit e81b88932985c9134d410f4eaaaa9b81a3b4bd0c ]

Intel Cherry Trail Whiskey Cove extcon driver connect USB data lines to
PMIC at driver probing for further charger detection. This causes reset of
USB data sessions and removing all devices from bus. If system was
booted from Live CD or USB dongle, this makes system unusable.

Check if USB ID pin is floating and re-route data lines in this case
only, don't touch otherwise.

Reviewed-by: Hans de Goede 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Yauhen Kharuzhy 
[cw00.choi: Clean-up the minor coding style]
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin

extcon: sm5502: Reset registers during initialization

2019-12-31T15:44:04+00:00

[ Upstream commit 6942635032cfd3e003e980d2dfa4e6323a3ce145 ]

On some devices (e.g. Samsung Galaxy A5 (2015)), the bootloader
seems to keep interrupts enabled for SM5502 when booting Linux.
Changing the cable state (i.e. plugging in a cable) - until the driver
is loaded - will therefore produce an interrupt that is never read.

In this situation, the cable state will be stuck forever on the
initial state because SM5502 stops sending interrupts.
This can be avoided by clearing those pending interrupts after
the driver has been loaded.

One way to do this is to reset all registers to default state
by writing to SM5502_REG_RESET. This ensures that we start from
a clean state, with all interrupts disabled.

Suggested-by: Chanwoo Choi 
Signed-off-by: Stephan Gerhold 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin

Merge tag 'tag-chrome-platform-for-v5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux

2019-09-19T21:14:28+00:00

Pull chrome platform updates from Benson Leung:
 "CrOS EC / MFD Migration:
    - Move cros_ec core driver from mfd into chrome platform.

  Wilco EC:
    - Add batt_ppid_info command to Wilco telemetry driver.

  CrOS EC:
    - cros_ec_rpmsg : Add support to inform EC of suspend/resume status
    - cros_ec_rpmsg : Fix race condition on probe failed
    - cros_ec_chardev : Add a poll handler to receive MKBP events

  Misc:
    - bugfixes in cros_usbpd_logger and cros_ec_ishtp"

* tag 'tag-chrome-platform-for-v5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux:
  platform/chrome: cros_usbpd_logger: null check create_singlethread_workqueue
  platform/chrome: cros_ec_chardev: Add a poll handler to receive MKBP events
  platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed
  platform/chrome: chromeos_tbmc: Report wake events
  mfd: cros_ec: Use mfd_add_hotplug_devices() helper
  mfd: cros_ec: Add convenience struct to define autodetectable CrOS EC subdevices
  mfd: cros_ec: Add convenience struct to define dedicated CrOS EC MCUs
  mfd: cros_ec: Use kzalloc and cros_ec_cmd_xfer_status helper
  mfd / platform: cros_ec: Reorganize platform and mfd includes
  mfd / platform: cros_ec: Rename config to a better name
  mfd: cros_ec: Switch to use the new cros-ec-chardev driver
  mfd / platform: cros_ec: Miscellaneous character device to talk with the EC
  mfd / platform: cros_ec: Move cros-ec core driver out from MFD
  mfd / platform: cros_ec: Handle chained ECs as platform devices
  platform/chrome: cros_ec_rpmsg: Add host command AP sleep state support
  platform/chrome: chromeos_laptop: drop checks of NULL-safe functions
  platform/chrome: wilco_ec: Add batt_ppid_info command to telemetry driver

mfd / platform: cros_ec: Reorganize platform and mfd includes

2019-09-02T10:33:42+00:00

There is a bit of mess between cros-ec mfd includes and platform
includes. For example, we have a linux/mfd/cros_ec.h include that
exports the interface implemented in platform/chrome/cros_ec_proto.c. Or
we have a linux/mfd/cros_ec_commands.h file that is non related to the
multifunction device (in the sense that is not exporting any function of
the mfd device). This causes crossed includes between mfd and
platform/chrome subsystems and makes the code difficult to read, apart
from creating 'curious' situations where a platform/chrome driver includes
a linux/mfd/cros_ec.h file just to get the exported functions that are
implemented in another platform/chrome driver.

In order to have a better separation on what the cros-ec multifunction
driver does and what the cros-ec core provides move and rework the
affected includes doing:

 - Move cros_ec_commands.h to include/linux/platform_data/cros_ec_commands.h
 - Get rid of the parts that are implemented in the platform/chrome/cros_ec_proto.c
   driver from include/linux/mfd/cros_ec.h to a new file
   include/linux/platform_data/cros_ec_proto.h
 - Update all the drivers with the new includes, so
   - Drivers that only need to know about the protocol include
     - linux/platform_data/cros_ec_proto.h
     - linux/platform_data/cros_ec_commands.h
   - Drivers that need to know about the cros-ec mfd device also include
     - linux/mfd/cros_ec.h

Signed-off-by: Enric Balletbo i Serra 
Acked-by: Andy Shevchenko 
Acked-by: Mark Brown 
Acked-by: Wolfram Sang 
Acked-by: Neil Armstrong 
Acked-by: Alexandre Belloni 
Acked-by: Jonathan Cameron 
Acked-by: Benjamin Tissoires 
Acked-by: Dmitry Torokhov 
Acked-by: Sebastian Reichel 
Acked-by: Chanwoo Choi 
Reviewed-by: Gwendal Grignou 
Tested-by: Gwendal Grignou 
Series changes: 3
- Fix dereferencing pointer to incomplete type 'struct cros_ec_dev' (lkp)
Signed-off-by: Lee Jones

mfd / platform: cros_ec: Move cros-ec core driver out from MFD

2019-09-02T10:33:12+00:00

Now, the ChromeOS EC core driver has nothing related to an MFD device, so
move that driver from the MFD subsystem to the platform/chrome subsystem.

Signed-off-by: Enric Balletbo i Serra 
Acked-by: Andy Shevchenko 
Acked-by: Thierry Reding 
Acked-by: Mark Brown 
Acked-by: Wolfram Sang 
Acked-by: Neil Armstrong 
Acked-by: Alexandre Belloni 
Acked-by: Jonathan Cameron 
Acked-by: Benjamin Tissoires 
Acked-by: Dmitry Torokhov 
Acked-by: Sebastian Reichel 
Acked-by: Chanwoo Choi 
Reviewed-by: Gwendal Grignou 
Tested-by: Gwendal Grignou 
Signed-off-by: Lee Jones

extcon: adc-jack: Remove dev_err() usage after platform_get_irq()

2019-07-31T00:55:46+00:00

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

Signed-off-by: Stephen Boyd 
[cw00.choi: Edit patch title and description for readability]
Signed-off-by: Chanwoo Choi

extcon: axp288: Use for_each_set_bit() in axp288_extcon_log_rsi()

2019-07-29T01:24:14+00:00

This simplifies and standardizes axp288_extcon_log_rsi()
by using for_each_set_bit() library function.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: axp288: Add missed error check

2019-07-29T01:23:46+00:00

It seems from the very beginning the error check has been missed
in axp288_extcon_log_rsi(). Add it here.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi