linux.git/drivers/firewire, branch v2.6.29-rc2 Clone of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git firewire: core: fix sleep in atomic context due to driver core change 2009-01-09T22:22:32+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2009-01-09T19:49:37+00:00 6230582320b721e6cf2581d048cb688dca97f504 Due to commit 2831fe6f9cc4e16c103504ee09a47a084297c0f3, "driver core: create a private portion of struct device", device_initialize() can no longer be called from atomic contexts. We now defer it until after config ROM probing. This requires changes to the bus manager code because this may use a device before it was probed. Reported-by: Jay Fenlason <fenlason@redhat.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
Due to commit 2831fe6f9cc4e16c103504ee09a47a084297c0f3, "driver core:
create a private portion of struct device", device_initialize() can no
longer be called from atomic contexts.

We now defer it until after config ROM probing.  This requires changes
to the bus manager code because this may use a device before it was
probed.

Reported-by: Jay Fenlason <fenlason@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: reorder struct fw_card for better cache efficiency 2009-01-04T22:50:38+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2008-11-29T18:00:56+00:00 c8a12d45d543905a2718fccafd612edbd73a1341 topology_map is by far the largest member in struct fw_card. Move it to the very end of the struct so that card pointer dereferences have better chances to hit the CPU cache. This requires to increase the topology_map backing store to the size specified in IEEE 1394, i.e. 256 rather than 255 quadlets. Otherwise the topology_map response handler may access invalid memory. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
topology_map is by far the largest member in struct fw_card.  Move it to
the very end of the struct so that card pointer dereferences have better
chances to hit the CPU cache.

This requires to increase the topology_map backing store to the size
specified in IEEE 1394, i.e. 256 rather than 255 quadlets.  Otherwise
the topology_map response handler may access invalid memory.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: fix resetting of bus manager retry counter 2009-01-04T22:50:38+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2008-11-29T17:56:47+00:00 d6f95a3d14dc403881b23ad268ec1e3600c4e6b4 An earlier change, maybe long ago, removed the copying of self_id_count into card->self_id_count. Since then each bus reset cleared card->bm_retries even when it shouldn't. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
An earlier change, maybe long ago, removed the copying of self_id_count
into card->self_id_count.  Since then each bus reset cleared
card->bm_retries even when it shouldn't.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: improve refcounting of fw_card 2009-01-04T22:50:37+00:00 Jay Fenlason fenlason@redhat.com 2008-11-29T16:44:57+00:00 0fa1986f3a6c385b3bca0b6a051c30e548bda30d Take a reference to the card whenever fw_card_bm_work() is scheduled on that card and release it when the work is done. This allows us to remove the cancel_delayed_work_sync() in fw_core_remove_card(). Signed-off-by: Jay Fenlason <fenlason@redhat.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (patch update) 
Take a reference to the card whenever fw_card_bm_work() is scheduled on
that card and release it when the work is done.  This allows us to
remove the cancel_delayed_work_sync() in fw_core_remove_card().

Signed-off-by: Jay Fenlason <fenlason@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (patch update)
firewire: typo in comment 2009-01-04T22:50:37+00:00 Jay Fenlason fenlason@redhat.com 2008-10-22T19:59:42+00:00 2cc489c21338950c2b4097dec48864bdf7b30f1b Signed-off-by: Jay Fenlason <fenlason@redhat.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
Signed-off-by: Jay Fenlason <fenlason@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: fix small memory leak at module removal 2009-01-04T22:50:37+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2008-11-24T19:40:00+00:00 d6053e08f5520dcb58c200d2e1861d9c505b72e8 Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: fw-sbp2: remove unnecessary locking 2009-01-04T22:50:36+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2008-10-26T10:04:20+00:00 621f6dd715209d3c3c27841943ae71fc2c75c9f5 What was I thinking when I added sbp2_set_generation()? Its locking did nothing (except for implicitly providing the necessary barrier between node IDs update and generation update). Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
What was I thinking when I added sbp2_set_generation()?  Its locking did
nothing (except for implicitly providing the necessary barrier between
node IDs update and generation update).

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: fw-ohci: fix IOMMU resource exhaustion 2008-12-10T11:45:34+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2008-12-09T23:20:38+00:00 1d1dc5e83f3299c108a4e44d58cc4bfef48c876a There is a DMA map/ unmap imbalance whenever a block write request packet is sent and then dequeued with ohci_cancel_packet. The latter may happen frequently if the AR resp tasklet is executed before the AT req tasklet for the same transaction. Add the missing dma_unmap_single. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=475156 Reported-by: Emmanuel Kowalski Tested-by: Emmanuel Kowalski Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
There is a DMA map/ unmap imbalance whenever a block write request
packet is sent and then dequeued with ohci_cancel_packet.  The latter
may happen frequently if the AR resp tasklet is executed before the AT
req tasklet for the same transaction.

Add the missing dma_unmap_single.  This fixes
https://bugzilla.redhat.com/show_bug.cgi?id=475156

Reported-by: Emmanuel Kowalski
Tested-by: Emmanuel Kowalski
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: fw-sbp2: another iPod mini quirk entry 2008-11-25T20:38:31+00:00 Stefan Richter stefanr@s5r6.in-berlin.de 2008-11-22T11:38:58+00:00 031bb27c4bf77c2f60b3f3dea8cce63ef0d1fba9 Add another model ID of a broken firmware to prevent early I/O errors by acesses at the end of the disk. Reported at linux1394-user, http://marc.info/?t=122670842900002 Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
Add another model ID of a broken firmware to prevent early I/O errors
by acesses at the end of the disk.  Reported at linux1394-user,
http://marc.info/?t=122670842900002

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
firewire: struct device - replace bus_id with dev_name(), dev_set_name() 2008-10-31T07:48:25+00:00 Kay Sievers kay.sievers@vrfy.org 2008-10-30T00:41:56+00:00 a1f64819fe9f136c98d572794a35a7e377c951ef Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> 
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>