linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c, branch v6.18.21

drm/amdgpu: fix drm panic null pointer when driver not support atomic

2026-01-23T10:21:19+00:00

[ Upstream commit 9cb6278b44c38899961b36d303d7b18b38be2a6e ]

When driver not support atomic, fb using plane->fb rather than
plane->state->fb.

Fixes: fe151ed7af54 ("drm/amdgpu: add generic display panic helper code")
Signed-off-by: Lu Yao 
Signed-off-by: Alex Deucher 
(cherry picked from commit 2f2a72de673513247cd6fae14e53f6c40c5841ef)
Signed-off-by: Sasha Levin

drm/amdgpu: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-07-16T17:07:03+00:00

Plumb the format info from .fb_create() all the way to
drm_helper_mode_fill_fb_struct() to avoid the redundant
lookup.

Cc: Alex Deucher 
Cc: amd-gfx@lists.freedesktop.org
Reviewed-by: Thomas Zimmermann 
Acked-by: Alex Deucher 
Signed-off-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/20250701090722.13645-10-ville.syrjala@linux.intel.com

drm: Allow the caller to pass in the format info to drm_helper_mode_fill_fb_struct()

2025-07-16T17:04:45+00:00

Soon all drivers should have the format info already available in the
places where they call drm_helper_mode_fill_fb_struct(). Allow it to
be passed along into drm_helper_mode_fill_fb_struct() instead of doing
yet another redundant lookup.

Start by always passing in NULL and still doing the extra lookup.
The actual changes to avoid the lookup will follow.

Done with cocci (with some manual fixups):
@@
identifier dev, fb, mode_cmd;
expression get_format_info;
@@
void drm_helper_mode_fill_fb_struct(struct drm_device *dev,
                                    struct drm_framebuffer *fb,
+                                    const struct drm_format_info *info,
                                    const struct drm_mode_fb_cmd2 *mode_cmd)
{
...
- fb->format = get_format_info;
+ fb->format = info ?: get_format_info;
...
}

@@
identifier dev, fb, mode_cmd;
@@
void drm_helper_mode_fill_fb_struct(struct drm_device *dev,
                                    struct drm_framebuffer *fb,
+                                    const struct drm_format_info *info,
                                    const struct drm_mode_fb_cmd2 *mode_cmd);

@@
expression dev, fb, mode_cmd;
@@
drm_helper_mode_fill_fb_struct(dev, fb
+	       ,NULL
	       ,mode_cmd);

Cc: Alex Deucher 
Cc: Liviu Dudau 
Cc: Russell King 
Cc: Inki Dae 
Cc: Seung-Woo Kim 
Cc: Kyungmin Park 
Cc: Patrik Jakobsson 
Cc: Rob Clark 
Cc: Abhinav Kumar 
Cc: Dmitry Baryshkov 
Cc: Sean Paul 
Cc: Marijn Suijten 
Cc: Lyude Paul 
Cc: Danilo Krummrich 
Cc: Tomi Valkeinen 
Cc: Thierry Reding 
Cc: Mikko Perttunen 
Cc: Gerd Hoffmann 
Cc: Dmitry Osipenko 
Cc: Gurchetan Singh 
Cc: Chia-I Wu 
Cc: Zack Rusin 
Cc: Broadcom internal kernel review list 
Cc: amd-gfx@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
Cc: virtualization@lists.linux.dev
Reviewed-by: Thomas Zimmermann 
Reviewed-by: Laurent Pinchart 
Reviewed-by: Dmitry Baryshkov 
Reviewed-by: Liviu Dudau 
Acked-by: Alex Deucher 
Acked-by: Rodrigo Vivi 
Signed-off-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/20250701090722.13645-6-ville.syrjala@linux.intel.com

drm: Pass the format info to .fb_create()

2025-07-16T17:03:14+00:00

Pass along the format information from the top to .fb_create()
so that we can avoid redundant (and somewhat expensive) lookups
in the drivers.

Done with cocci (with some manual fixups):
@@
identifier func =~ ".*create.*";
identifier dev, file, mode_cmd;
@@
struct drm_framebuffer *func(
       struct drm_device *dev,
       struct drm_file *file,
+      const struct drm_format_info *info,
       const struct drm_mode_fb_cmd2 *mode_cmd)
{
...
(
- const struct drm_format_info *info = drm_get_format_info(...);
|
- const struct drm_format_info *info;
...
- info = drm_get_format_info(...);
)
<...
- if (!info)
-    return ...;
...>
}

@@
identifier func =~ ".*create.*";
identifier dev, file, mode_cmd;
@@
struct drm_framebuffer *func(
       struct drm_device *dev,
       struct drm_file *file,
+      const struct drm_format_info *info,
       const struct drm_mode_fb_cmd2 *mode_cmd)
{
...
}

@find@
identifier fb_create_func =~ ".*create.*";
identifier dev, file, mode_cmd;
@@
struct drm_framebuffer *fb_create_func(
       struct drm_device *dev,
       struct drm_file *file,
+      const struct drm_format_info *info,
       const struct drm_mode_fb_cmd2 *mode_cmd);

@@
identifier find.fb_create_func;
expression dev, file, mode_cmd;
@@
fb_create_func(dev, file
+	       ,info
	       ,mode_cmd)

@@
expression dev, file, mode_cmd;
@@
drm_gem_fb_create(dev, file
+	       ,info
	       ,mode_cmd)

@@
expression dev, file, mode_cmd;
@@
drm_gem_fb_create_with_dirty(dev, file
+	       ,info
	       ,mode_cmd)

@@
expression dev, file_priv, mode_cmd;
identifier info, fb;
@@
info = drm_get_format_info(...);
...
fb = dev->mode_config.funcs->fb_create(dev, file_priv
+                                      ,info
                                       ,mode_cmd);

@@
identifier dev, file_priv, mode_cmd;
@@
struct drm_mode_config_funcs {
...
struct drm_framebuffer *(*fb_create)(struct drm_device *dev,
                                     struct drm_file *file_priv,
+                                     const struct drm_format_info *info,
                                     const struct drm_mode_fb_cmd2 *mode_cmd);
...
};

v2: Fix kernel docs (Laurent)
    Fix commit msg (Geert)

Cc: Alex Deucher 
Cc: Liviu Dudau 
Cc: Maxime Ripard 
Cc: Russell King 
Cc: Inki Dae 
Cc: Seung-Woo Kim 
Cc: Kyungmin Park 
Cc: Patrik Jakobsson 
Cc: Chun-Kuang Hu 
Cc: Philipp Zabel 
Cc: Rob Clark 
Cc: Abhinav Kumar 
Cc: Dmitry Baryshkov 
Cc: Sean Paul 
Cc: Marijn Suijten 
Cc: Marek Vasut 
Cc: Stefan Agner 
Cc: Lyude Paul 
Cc: Danilo Krummrich 
Cc: Tomi Valkeinen 
Cc: Dave Airlie 
Cc: Gerd Hoffmann 
Cc: Kieran Bingham 
Cc: Biju Das 
Cc: Sandy Huang 
Cc: "Heiko Stübner" 
Cc: Andy Yan 
Cc: Thierry Reding 
Cc: Mikko Perttunen 
Cc: Dave Stevenson 
Cc: "Maíra Canal" 
Cc: Raspberry Pi Kernel Maintenance 
Cc: Dmitry Osipenko 
Cc: Gurchetan Singh 
Cc: Chia-I Wu 
Cc: Zack Rusin 
Cc: Broadcom internal kernel review list 
Cc: Oleksandr Andrushchenko 
Cc: amd-gfx@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Cc: virtualization@lists.linux.dev
Cc: spice-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: Laurent Pinchart 
Reviewed-by: Geert Uytterhoeven 
Reviewed-by: Thomas Zimmermann 
Reviewed-by: Dmitry Baryshkov 
Acked-by: Liviu Dudau 
Reviewed-by: Laurent Pinchart 
Acked-by: Alex Deucher 
Acked-by: Rodrigo Vivi 
Signed-off-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/20250701090722.13645-5-ville.syrjala@linux.intel.com

drm/amdgpu: Test for imported buffers with drm_gem_is_imported()

2025-06-30T15:54:59+00:00

Instead of testing import_attach for imported GEM buffers, invoke
drm_gem_is_imported() to do the test.

v2:
- keep amdgpu_bo_print_info() as-is (Christian)

Reviewed-by: Christian König 
Signed-off-by: Thomas Zimmermann 
Signed-off-by: Alex Deucher

drm/amdgpu: add generic display panic helper code

2024-12-18T17:13:49+00:00

Pull this out of Jocelyn's patch and make it generic.

Reviewed-by: Harry Wentland 
Signed-off-by: Alex Deucher 
Cc: Lu Yao 
Cc: Jocelyn Falempe 
Cc: Harry Wentland

drm/amdgpu: explicitely set the AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag

2024-09-18T20:15:09+00:00

Instead of having that in the amdgpu_bo_pin() function applied for all
pinned BOs.

Signed-off-by: Christian König 
Acked-by: Lijo Lazar 
Signed-off-by: Alex Deucher

drm/amdgpu: ensure the connector is not null before using it

2024-09-17T14:04:57+00:00

This resolves the dereference null return value warning
reported by Coverity.

Signed-off-by: Tim Huang 
Reviewed-by: Jesse Zhang 
Signed-off-by: Alex Deucher

Revert "drm/amd: Add power_saving_policy drm property to eDP connectors"

2024-08-02T15:29:17+00:00

This reverts commit 9d8c094ddab05db88d183ba82e23be807848cad8.

It was merged without meeting userspace requirements.

Signed-off-by: Hamza Mahfooz 
Reviewed-by: Harry Wentland 
Link: https://patchwork.freedesktop.org/patch/msgid/20240802145946.48073-2-hamza.mahfooz@amd.com

Merge drm/drm-next into drm-misc-next

2024-07-29T07:35:54+00:00

Backmerging to get a late RC of v6.10 before moving into v6.11.

Signed-off-by: Thomas Zimmermann