linux.git/drivers/hwmon/coretemp.c, branch v3.14.31

Revert "hwmon: (coretemp) Refine TjMax detection"

2014-06-07T17:28:11+00:00

commit c0940e95f7a78be0525c8d31df0b1f71e149e57e upstream.

This reverts commit 9fb6c9c73b11bef65ba80a362547fd116c1e1c9d.

Tjmax on some Intel CPUs is below 85 degrees C. One known example is
L5630 with Tjmax of 71 degrees C. There are other Xeon processors with
Tjmax of 70 or 80 degrees C. Also, the Intel IA32 System Programming
document states that the temperature target is in bits 23:16 of MSR 0x1a2
(MSR_TEMPERATURE_TARGET), which is 8 bits, not 7.

So even if turbostat uses similar checks to validate Tjmax, there is no
evidence that the checks are actually required. On the contrary, the
checks are known to cause problems and therefore need to be removed.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=75071.

Fixes: 9fb6c9c hwmon: (coretemp) Refine TjMax detection
Reviewed-by: Jean Delvare 
Signed-off-by: Guenter Roeck 
Signed-off-by: Greg Kroah-Hartman

hwmon: (coretemp) Do not return -EAGAIN for low temperatures

2014-01-15T05:36:52+00:00

Some Intel CPUs do not set the 'valid' bit in IA32_THERM_STATUS if the
temperature is too low to be measured. This condition will not change until
the CPU is hot enough for its temperature to be measured. Returning an error
in such conditions is not very useful. Drop checking the valid bit and just
return the reported temperature instead.

Reviewed-by: Jean Delvare 
Signed-off-by: Guenter Roeck

hwmon: (coretemp) Refine TjMax detection

2014-01-15T05:36:31+00:00

Intel's turbostat code uses only 7 bits from MSR_IA32_TEMPERATURE_TARGET to
read TjMax, and also only accepts it if the reported temperature is at least
85 degrees C. Play safe and do the same.

Signed-off-by: Guenter Roeck

hwmon: (coretemp) Add PCI device ID for CE41x0 CPUs

2014-01-15T05:36:31+00:00

Since we now have to use PCI IDs to detect CPU types anyway, use this mechanism
to detect CE41x0 CPUs. Advantage is that it only requires a single entry and
covers all variants of CE41x0, including those unknown to us.

Signed-off-by: Guenter Roeck

hwmon: (coretemp) Use PCI host bridge ID to identify CPU if necessary

2014-01-15T05:36:30+00:00

Atom S12x0 CPUs are identified by the CPU host bridge ID. Add an override
table based on PCI IDs as well as code to detect it.

PCI access functions can now be called with PCI disabled, so unlike previous
attempts to use PCI IDs, the code no longer depends on it. If PCI is disabled,
the CPU will not be identified correctly. Since it is unlikely that anything
will work in this case, this is an acceptable limitation.

Signed-off-by: Guenter Roeck

hwmon: (coretemp) Fix truncated name of alarm attributes

2014-01-14T17:47:52+00:00

When the core number exceeds 9, the size of the buffer storing the
alarm attribute name is insufficient and the attribute name is
truncated. This causes libsensors to skip these attributes as the
truncated name is not recognized.

Reported-by: Andreas Hollmann 
Signed-off-by: Jean Delvare 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck

hwmon: (coretemp) Atom CPUs don't support TjMax; no warning needed

2013-08-12T05:10:38+00:00

Display warning "Unable to read TjMax from CPU x" only if the CPU
is supposed to support it. This is not the case for the various Atom CPUs.

Signed-off-by: Guenter Roeck

hwmon: delete __cpuinit usage from all hwmon files

2013-07-14T23:36:57+00:00

The __cpuinit type of throwaway sections might have made sense
some time ago when RAM was more constrained, but now the savings
do not offset the cost and complications.  For example, the fix in
commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
is a good example of the nasty type of bugs that can be created
with improper use of the various __init prefixes.

After a discussion on LKML[1] it was decided that cpuinit should go
the way of devinit and be phased out.  Once all the users are gone,
we can then finally remove the macros themselves from linux/init.h.

This removes all the drivers/hwmon uses of the __cpuinit macros
from all C files.

[1] https://lkml.org/lkml/2013/5/20/589

Cc: Fenghua Yu 
Cc: lm-sensors@lm-sensors.org
Acked-by: Guenter Roeck 
Signed-off-by: Paul Gortmaker

hwmon: (coretemp) Remove redundant platform_set_drvdata()

2013-06-21T17:05:08+00:00

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat 
Cc: Rudolf Marek 
Signed-off-by: Guenter Roeck

hwmon: Fix checkpatch warning 'quoted string split across lines'

2013-04-08T04:16:40+00:00

Cc: Corentin Labbe 
Cc: Mark M. Hoffman 
Cc: Fenghua Yu 
Cc: Juerg Haefliger 
Cc: Andreas Herrmann 
Cc: Rudolf Marek 
Cc: Jim Cromie 
Cc: Roger Lucas 
Cc: Marc Hulsman 
Signed-off-by: Guenter Roeck