linux.git/drivers/iio/magnetometer, branch v4.11.9

iio: magnetometer: ak8974: remove incorrect __exit markups

2017-03-05T13:52:01+00:00

Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov 
Reviewed-by: Linus Walleij 
Cc: 
Signed-off-by: Jonathan Cameron

iio: magnetometer: mag3110: claim direct mode during raw writes

2017-01-21T12:20:40+00:00

Driver was checking for direct mode but not locking it.  Use
claim/release helper functions to guarantee the device stays
in direct mode during raw writes.

Signed-off-by: Alison Schofield 
Acked-by: Peter Meerwald-Stadler 
Signed-off-by: Jonathan Cameron

iio: magnetometer: ak8974: remove redundant zero timeout check

2017-01-14T13:10:04+00:00

At the end of the delay loop timeout will always be zero
and hence the check for !timeout will always be true. Remove
the redundant check and the redundant return 0 at the end of
the function.

Fixes CoverityScan CID#1357168 ("Logically dead code")

Signed-off-by: Colin Ian King 
Reviewed-by: Linus Walleij 
Signed-off-by: Jonathan Cameron

iio: magnetometer: separate the values of attributes based on their usage type for HID compass sensor

2016-11-24T20:41:30+00:00

There are 2 usage types (Magnetic Flux and Heading data field) for HID
compass sensor, thus the values of offset, scale, and sensitivity should
be separated according to their respective usage type. The changes made
are as below:
1. Hysteresis: A struct hid_sensor_common rot_attributes is created in
struct magn_3d_state to contain the sensitivity for IIO_ROT.
2. Scale: scale_pre_decml and scale_post_decml are separated for IIO_MAGN
and IIO_ROT.
3. Offset: Same as scale, value_offset is separated for IIO_MAGN and
IIO_ROT.

For sensitivity, HID_USAGE_SENSOR_ORIENT_MAGN_FLUX and
HID_USAGE_SENSOR_ORIENT_MAGN_HEADING are used for sensivitity fields based
on the HID Sensor Usages specifications. Hence, these changes are added on
the sensitivity field.

Signed-off-by: Ooi, Joyce 
Acked-by: Srinivas Pandruvada 
Signed-off-by: Jonathan Cameron

iio: magn: st_magn: inline per-sensor data

2016-11-12T15:45:37+00:00

We have #defines for all the individual sensor registers and
value/mask pairs #defined at the top of the file and used at
exactly one spot.

This is usually good if the #defines give a meaning to the
opaque magic numbers.

However in this case, the semantic meaning is inherent in the
name of the C99-addressable fields, and that means duplication
of information, and only makes the code hard to maintain since
you every time have to add a new #define AND update the site
where it is to be used.

Get rid of the #defines and just open code the values into the
appropriate struct elements. Make sure to explicitly address
the .hz and .value fields in the st_sensor_odr_avl struct
so that the meaning of all values is clear.

This patch is purely syntactic should have no semantic effect.

Signed-off-by: Linus Walleij 
Signed-off-by: Jonathan Cameron

iio: magnetometer: ak8974: small endianness fixes

2016-10-03T20:30:00+00:00

Fixes two cases of 'cast to restricted __le16' as reported by sparse.

Signed-off-by: Ico Doornekamp 
Signed-off-by: Jonathan Cameron

drivers: iio: magnetometer: Fix sparse endianness warnings cast to restricted __be16

2016-09-27T20:08:45+00:00

Fix the following sparse endianness warnings:

drivers/iio/magnetometer/ak8975.c:716:16: warning: cast to restricted __le16
drivers/iio/magnetometer/ak8975.c:837:19: warning: cast to restricted __le16
drivers/iio/magnetometer/ak8975.c:838:19: warning: cast to restricted __le16
drivers/iio/magnetometer/ak8975.c:839:19: warning: cast to restricted __le16

Signed-off-by: Sandhya Bankar 
Signed-off-by: Jonathan Cameron

iio: magn: ak8974: remove .owner field for driver

2016-08-29T19:12:10+00:00

Remove .owner field if calls are used which set it automatically.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Wei Yongjun 
Acked-by: Linus Walleij 
Signed-off-by: Jonathan Cameron

iio: magn/ak8974: avoid unused function warning

2016-08-29T18:54:55+00:00

The ak8974_configure() function is used only from the PM code,
but that can be hidden when CONFIG_PM is disabled:

drivers/iio/magnetometer/ak8974.c:201:12: error: 'ak8974_configure' defined but not used [-Werror=unused-function]

This replaces the #ifdef with a __maybe_unused annotation, which
will work correctly in all configurations and avoid the warning,
as the compiler can now see where ak8974_configure is called from.

Signed-off-by: Arnd Bergmann 
Fixes: 7c94a8b2ee8c ("iio: magn: add a driver for AK8974")
Signed-off-by: Jonathan Cameron

iio: magnetometer: mag3110: claim direct mode during raw reads

2016-08-21T18:37:35+00:00

Driver was checking for direct mode but not locking it.  Use
claim/release helper functions to guarantee the device stays
in direct mode during raw reads.

Signed-off-by: Alison Schofield 
Cc: Daniel Baluta 
Signed-off-by: Jonathan Cameron