linux.git/drivers/infiniband/ulp/isert, branch v3.19.6

iser-target: Fix wc->wr_id cast warning

2014-12-13T07:32:35+00:00

CC [M]  drivers/infiniband/ulp/isert/ib_isert.o
drivers/infiniband/ulp/isert/ib_isert.c: In function ‘isert_cq_comp_err’:
drivers/infiniband/ulp/isert/ib_isert.c:1979:42: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Signed-off-by: Nicholas Bellinger

iser-target: Remove code duplication

2014-12-13T07:32:35+00:00

- Fall-through in switch case instead in do_control_comp.
- Move rkey invalidation to a function.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Adjust log levels and prettify some prints

2014-12-13T07:32:34+00:00

debug_level 1 (warn): Include warning messages.
debug_level 2 (info): Include relevant info for control plane.
debug_level 3 (debug): Include relevant info in the IO path.

Also, added/removed some logging messages.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Use debug_level parameter to control logging level

2014-12-13T07:32:34+00:00

Personal preference, easier control of the log level with
a single modparam which can be changed dynamically. Allows
better saparation of control and IO plains.

Replaced throughout ib_isert.c:
s/pr_debug/isert_dbg/g
s/pr_info/isert_info/g
s/pr_warn/isert_warn/g
s/pr_err/isert_err/g

Plus nit checkpatch warning change.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Fix logout sequence

2014-12-13T07:32:33+00:00

We don't want to wait for conn_logout_comp from isert_comp_wq
context as this blocks further completions from being processed.
Instead we wait for it conditionally (if logout response was
actually posted) in wait_conn. This wait should normally happen
immediately as it occurs after we consumed all the completions
(including flush errors) and conn_logout_comp should have been
completed.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Don't wait for session commands from completion context

2014-12-13T07:32:32+00:00

Might result in a deadlock where completion context waits for
session commands release where the later might need a final
completion for it.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Reduce CQ lock contention by batch polling

2014-12-13T07:32:32+00:00

In order to reduce the contention on CQ locking (present
in some LLDDs) we poll in batches of 16 work completion items.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Introduce isert_poll_budget

2014-12-13T07:32:31+00:00

In case the CQ is packed with completions, we can't just
hog the CPU forever. Poll until a sufficient budget (currently
hard-coded to 64k completions) and if budget is exhausted, bailout
and give a chance to other threads.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Remove an atomic operation from the IO path

2014-12-13T07:32:31+00:00

In order to know that we consumed all the connection completions
we maintain atomic post_send_buf_count for each IO post send. But
we can know that if we post a "beacon" (zero length RECV work request)
after we move the QP into error state and the target does not serve
any new IO. When we consume it, we know we finished all the connection
completion and we can go ahead and destroy stuff.

In error completion handler we now just need to check for ISERT_BEACON_WRID
to arrive and then wait for session commands to cleanup and complete
conn_wait_comp_err.

We reserve another CQ and QP entries to fit the zero length post recv.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

iser-target: Remove redundant call to isert_conn_terminate

2014-12-13T07:32:30+00:00

We are calling session reinstatement, wait_conn will start
connection termination.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger