linux.git/drivers/input/tablet/pegasus_notetaker.c, branch v5.13.4

Input: Use fallthrough pseudo-keyword

2020-07-07T18:25:54+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva 
Link: https://lore.kernel.org/r/20200707180857.GA30600@embeddedor
Signed-off-by: Dmitry Torokhov

Input: pegasus_notetaker - fix endpoint sanity check

2020-01-10T22:42:53+00:00

The driver was checking the number of endpoints of the first alternate
setting instead of the current one, something which could be used by a
malicious device (or USB descriptor fuzzer) to trigger a NULL-pointer
dereference.

Fixes: 1afca2b66aac ("Input: add Pegasus Notetaker tablet driver")
Signed-off-by: Johan Hovold 
Acked-by: Martin Kepplinger 
Acked-by: Vladis Dronov 
Link: https://lore.kernel.org/r/20191210113737.4016-2-johan@kernel.org
Signed-off-by: Dmitry Torokhov

treewide: Add SPDX license identifier for more missed files

2019-05-21T08:50:45+00:00

Add SPDX license identifiers to all files which:

 - Have no license information of any form

 - Have MODULE_LICENCE("GPL*") inside which was used in the initial
   scan/conversion to ignore the file

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

Input: pegasus_notetaker - do not rely on input_dev->users

2018-03-17T18:05:18+00:00

If the device is unused and suspended, a call to open will cause the
device to autoresume through the call to usb_autopm_get_interface().

input_dev->users is already incremented by the input subsystem,
therefore this expression will always be evaluated to true:

	if (pegasus->dev->users && usb_submit_urb(pegasus->irq, GFP_NOIO) < 0)
		retval = -EIO;

The same URB will then be fail when resubmitted in pegasus_open().

Introduce pegasus->is_open to keep track of the state instead.

Signed-off-by: Marcus Folkesson 
Signed-off-by: Dmitry Torokhov

Input: pagasus_notetaker - fix deadlock in autosuspend

2018-03-17T18:05:18+00:00

usb_autopm_get_interface() that is called in pegasus_open() does an
autoresume if the device is suspended.

input_dev->mutex used in pegasus_resume() is in this case already
taken by the input subsystem and will cause a deadlock.

Signed-off-by: Marcus Folkesson 
Signed-off-by: Dmitry Torokhov

Input: pegasus_notetaker - directly include workqueue header

2016-08-25T17:11:32+00:00

According to the kernel's guidelines, let's directly include the
workqueue functions we use.

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: pegasus_notetaker - set device mode in reset_resume() if in use

2016-07-19T21:33:07+00:00

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: pegasus_notetaker - cancel workqueue's work in suspend()

2016-07-19T21:33:06+00:00

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: pegasus_notetaker - fix usb_autopm calls to be balanced

2016-07-19T21:33:05+00:00

We should only "put" the interface if submitting URB or setting tablet mode
in pegasus_open() fails, otherwise leave it to pegasus_close().

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov

Input: pegasus_notetaker - handle usb control msg errors

2016-07-19T21:33:04+00:00

Signed-off-by: Martin Kepplinger 
Signed-off-by: Dmitry Torokhov