linux.git/drivers/media/usb/hdpvr, branch v3.15

[media] hdpvr: Fix memory leak in debug

2014-02-04T08:43:53+00:00

cppcheck reported memory leak in device_authorizatio()
within hdpvr-core.c.
When the debug option is specified and the code jump to
"unlock:" label, print_buf was not freed.
Confirm the module succesfully compiled without error.

Signed-off-by: Masanari Iida 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] hdpvr: fix sparse warnings

2013-10-15T15:54:20+00:00

drivers/media/usb/hdpvr/hdpvr-core.c:110:54: warning: incorrect type in argument 1 (different base types)
drivers/media/usb/hdpvr/hdpvr-core.c:112:39: warning: invalid assignment: +=
drivers/media/usb/hdpvr/hdpvr-core.c:304:26: warning: Using plain integer as NULL pointer

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] hdpvr: fix iteration over uninitialized lists in hdpvr_probe()

2013-09-03T12:24:20+00:00

free_buff_list and rec_buff_list are initialized in the middle of hdpvr_probe(),
but if something bad happens before that, error handling code calls hdpvr_delete(),
which contains iteration over the lists (via hdpvr_free_buffers()).
The patch moves the lists initialization to the beginning and by the way fixes
goto label in error handling of registering videodev.
Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab 
Cc: stable@vger.kernel.org

[media] v4l2-dv-timings: rename v4l_match_dv_timings to v4l2_match_dv_timings

2013-08-24T07:26:51+00:00

It's the only function in v4l2-dv-timings.c with the v4l prefix instead
of v4l2. Make it consistent with the other functions.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l2: use new V4L2_DV_BT_BLANKING/FRAME defines

2013-08-18T11:19:03+00:00

Use the new defines to calculate the full blanking and frame sizes.

Signed-off-by: Hans Verkuil 
Acked-by: Scott Jiang 
Acked-by: Lad, Prabhakar 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l2: move dv-timings related code to v4l2-dv-timings.c

2013-08-18T11:16:54+00:00

v4l2-common.c contained a bunch of dv-timings related functions.
Move that to the new v4l2-dv-timings.c which is a more appropriate
place for them.
There aren't many drivers that do HDTV, so it is a good idea to separate
common code related to that into a module of its own.

Signed-off-by: Hans Verkuil 
Acked-by: Lad, Prabhakar 
Signed-off-by: Mauro Carvalho Chehab

[media] hdpvr: improve error handling

2013-06-13T14:35:47+00:00

get_video_info() should never return EFAULT, instead it should return
the low-level usb_control_msg() error. Add a valid field to the hdpvr_video_info
struct so the driver can easily check if a valid format was detected.
Whenever get_video_info is called and it returns an error (e.g. usb_control_msg
failed), then return that error to userspace as well.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] hdpvr: code cleanup

2013-06-13T14:33:51+00:00

Remove an unnecessary 'else' and invert a condition which makes the code
more readable.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] hdpvr: fix querystd 'unknown format' return

2013-06-13T14:33:08+00:00

If no format has been detected, then querystd should return V4L2_STD_UNKNOWN,
not V4L2_STD_ALL.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] hdpvr: Removed unnecessary use of kzalloc() in get_video_info()

2013-05-27T11:51:51+00:00

[mchehab@redhat.com: CodingStyle fixes]
Signed-off-by: Leonid Kegulskiy 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab