linux.git/drivers/net/macvlan.c, branch v2.6.26-rc7

macvlan: Fix memleak on device removal/crash on module removal

2008-05-08T08:13:31+00:00

As noticed by Ben Greear, macvlan crashes the kernel when unloading the
module. The reason is that it tries to clean up the macvlan_port pointer
on the macvlan device itself instead of the underlying device. A non-NULL
pointer is taken as indication that the macvlan_handle_frame_hook is
valid, when receiving the next packet on the underlying device it tries
to call the NULL hook and crashes.

Clean up the macvlan_port on the correct device to fix this.

Signed-off-by; Patrick McHardy 
Tested-by: Ben Greear 
Signed-off-by: David S. Miller

[NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS.

2008-03-25T19:39:53+00:00

Introduce per-net_device inlines: dev_net(), dev_net_set().
Without CONFIG_NET_NS, no namespace other than &init_net exists.
Let's explicitly define them to help compiler optimizations.

Signed-off-by: YOSHIFUJI Hideaki

[MACVLAN]: Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.

2008-02-01T03:28:25+00:00

In drivers/net/macvlan.c, when rtnl_link_register() fails in
macvlan_init_module(), there is no point to set it (second time in
this method) to macvlan_handle_frame; macvlan_init_module() will
return a negative number, so instead this patch sets
macvlan_handle_frame_hook to NULL.

Signed-off-by: Rami Rosen 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

[MACVLAN]: Fix thinko in macvlan_transfer_operstate()

2008-01-28T23:08:36+00:00

When the lower device's carrier is off, the macvlan devices's
carrier state should be checked to decide whether it needs to
be turned off. Currently the lower device's state is checked
a second time.

This still works, but unnecessarily tries to turn off the
carrier when its already off.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[MACVLAN]: Allow setting mac address while device is up

2008-01-28T22:54:23+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[MACVLAN]: Remove unnecessary IFF_UP check

2008-01-28T22:54:23+00:00

Only devices that are UP are in the hash, so macvlan_broadcast() doesn't
need to check for IFF_UP.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[MACVLAN]: Prevent nesting macvlan devices

2008-01-11T06:39:28+00:00

Don't allow to nest macvlan devices since it will cause lockdep
warnings and isn't really useful for anything.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

remove duplicate initializer (macvlan)

2007-10-14T19:41:51+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[NET]: Move hardware header operations out of netdevice.

2007-10-10T23:52:52+00:00

Since hardware header operations are part of the protocol class
not the device instance, make them into a separate object and
save memory.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NET]: Wrap netdevice hardware header creation.

2007-10-10T23:52:50+00:00

Add inline for common usage of hardware header creation, and
fix bug in IPV6 mcast where the assumption about negative return is
an errno. Negative return from hard_header means not enough space
was available,(ie -N bytes).

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller