linux.git/drivers/nvme/host, branch v5.12.5

nvme: do not try to reconfigure APST when the controller is not live

2021-05-19T08:56:45+00:00

commit 53fe2a30bc168db9700e00206d991ff934973cf1 upstream.

Do not call nvme_configure_apst when the controller is not live, given
that nvme_configure_apst will fail due the lack of an admin queue when
the controller is being torn down and nvme_set_latency_tolerance is
called from dev_pm_qos_hide_latency_tolerance.

Fixes: 510a405d945b("nvme: fix memory leak for power latency tolerance")
Reported-by: Peng Liu 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Keith Busch 
Signed-off-by: Greg Kroah-Hartman

nvme-pci: don't simple map sgl when sgls are disabled

2021-05-14T08:52:42+00:00

[ Upstream commit e51183be1fa96dc6d3cd11b3c25a0f595807315e ]

According to the module parameter description for sgl_threshold,
a value of 0 means that SGLs are disabled.

If SGLs are disabled, we should respect that, even for the case
where the request is made up of a single physical segment.

Fixes: 297910571f08 ("nvme-pci: optimize mapping single segment requests using SGLs")
Signed-off-by: Niklas Cassel 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Sasha Levin

nvme: retrigger ANA log update if group descriptor isn't found

2021-05-14T08:52:38+00:00

[ Upstream commit dd8f7fa908f66dd44abcd83cbb50410524b9f8ef ]

If ANA is enabled but no ANA group descriptor is found when creating
a new namespace the ANA log is most likely out of date, so trigger
a re-read. The namespace will be tagged with the NS_ANA_PENDING flag
to exclude it from path selection until the ANA log has been re-read.

Fixes: 32acab3181c7 ("nvme: implement multipath access to nvme subsystems")
Reported-by: Martin George 
Signed-off-by: Hannes Reinecke 
Reviewed-by: Keith Busch 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Sasha Levin

nvme-tcp: block BH in sk state_change sk callback

2021-05-14T08:52:38+00:00

[ Upstream commit 8b73b45d54a14588f86792869bfb23098ea254cb ]

The TCP stack can run from process context for a long time
so we should disable BH here.

Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Sasha Levin

nvme-rdma: fix possible hang when failing to set io queues

2021-03-18T04:39:01+00:00

We only setup io queues for nvme controllers, and it makes absolutely no
sense to allow a controller (re)connect without any I/O queues.  If we
happen to fail setting the queue count for any reason, we should not allow
this to be a successful reconnect as I/O has no chance in going through.
Instead just fail and schedule another reconnect.

Reported-by: Chao Leng 
Fixes: 711023071960 ("nvme-rdma: add a NVMe over Fabrics RDMA host driver")
Signed-off-by: Sagi Grimberg 
Reviewed-by: Chao Leng 
Signed-off-by: Christoph Hellwig

nvme-tcp: fix possible hang when failing to set io queues

2021-03-18T04:39:01+00:00

We only setup io queues for nvme controllers, and it makes absolutely no
sense to allow a controller (re)connect without any I/O queues.  If we
happen to fail setting the queue count for any reason, we should not
allow this to be a successful reconnect as I/O has no chance in going
through. Instead just fail and schedule another reconnect.

Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvme-tcp: fix misuse of __smp_processor_id with preemption enabled

2021-03-18T04:39:01+00:00

For our pure advisory use-case, we only rely on this call as a hint, so
fix the warning complaints of using the smp_processor_id variants with
preemption enabled.

Fixes: db5ad6b7f8cd ("nvme-tcp: try to send request in queue_rq context")
Fixes: ada831772188 ("nvme-tcp: Fix warning with CONFIG_DEBUG_PREEMPT")
Signed-off-by: Sagi Grimberg 
Reviewed-by: Chaitanya Kulkarni 
Tested-by: Yi Zhang 
Signed-off-by: Christoph Hellwig

nvme-tcp: fix a NULL deref when receiving a 0-length r2t PDU

2021-03-18T04:39:01+00:00

When the controller sends us a 0-length r2t PDU we should not attempt to
try to set up a h2cdata PDU but rather conclude that this is a buggy
controller (forward progress is not possible) and simply fail it
immediately.

Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Reported-by: Belanger, Martin 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvme: fix Write Zeroes limitations

2021-03-18T04:38:49+00:00

We voluntarily limit the Write Zeroes sizes to the MDTS value provided by
the hardware, but currently get the units wrong, so fix that.

Fixes: 6e02318eaea5 ("nvme: add support for the Write Zeroes command")
Signed-off-by: Christoph Hellwig 
Reviewed-by: Keith Busch 
Tested-by: Klaus Jensen 
Reviewed-by: Klaus Jensen 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Himanshu Madhani

nvme: allocate the keep alive request using BLK_MQ_REQ_NOWAIT

2021-03-18T04:38:48+00:00

To avoid an error recovery deadlock where the keep alive work is waiting
for a request and thus can't be flushed to make progress for tearing down
the controller.  Also print the error code returned from
blk_mq_alloc_request to help debugging any future issues in this code.

Based on an earlier patch from Hannes Reinecke .

Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Daniel Wagner