linux.git/drivers/pci/endpoint, branch v4.14.249

PCI: endpoint: Fix for concurrent memory allocation in OB address region

2020-04-24T06:00:37+00:00

commit 04e046ca57ebed3943422dee10eec9e73aec081e upstream.

pci-epc-mem uses a bitmap to manage the Endpoint outbound (OB) address
region. This address region will be shared by multiple endpoint
functions (in the case of multi function endpoint) and it has to be
protected from concurrent access to avoid updating an inconsistent state.

Use a mutex to protect bitmap updates to prevent the memory
allocation API from returning incorrect addresses.

Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Lorenzo Pieralisi 
Cc: stable@vger.kernel.org # v4.14+
Signed-off-by: Greg Kroah-Hartman

PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()

2020-01-27T13:46:19+00:00

[ Upstream commit 726dabfde6aa35a4f1508e235ae37edbbf9fbc65 ]

Functions copying from/to IO addresses should use the
memcpy_fromio()/memcpy_toio() API rather than plain memcpy().

Fix the issue detected through the sparse tool.

Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")
Suggested-by: Kishon Vijay Abraham I 
Signed-off-by: Wen Yang 
[lorenzo.pieralisi@arm.com: updated log]
Signed-off-by: Lorenzo Pieralisi 
Acked-by: Kishon Vijay Abraham I 
CC: Lorenzo Pieralisi 
CC: Bjorn Helgaas 
CC: Gustavo Pimentel 
CC: Niklas Cassel 
CC: Greg Kroah-Hartman 
CC: Cyrille Pitchen 
CC: linux-pci@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Sasha Levin

PCI: endpoint: Use EPC's device in dma_alloc_coherent()/dma_free_coherent()

2019-03-27T05:13:55+00:00

commit b330104fa76df3eae6e199a23791fed5d35f06b4 upstream.

After commit 723288836628 ("of: restrict DMA configuration"),
of_dma_configure() doesn't configure the coherent_dma_mask/dma_mask
of endpoint function device (since it doesn't have a DT node associated
with and hence no dma-ranges property), resulting in
dma_alloc_coherent() (used in pci_epf_alloc_space()) to fail.

Fix it by making dma_alloc_coherent() use EPC's device for allocating
memory address.

Link: http://lkml.kernel.org/r/64d63468-d28f-8fcd-a6f3-cf2a6401c8cb@ti.com
Signed-off-by: Kishon Vijay Abraham I 
[lorenzo.pieralisi@arm.com: tweaked commit log]
Signed-off-by: Lorenzo Pieralisi 
Cc: Robin Murphy 
Cc: Rob Herring 
Cc: Christoph Hellwig 
Tested-by: Cyrille Pitchen 
Tested-by: Niklas Cassel 
Reviewed-by: Robin Murphy 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

PCI: endpoint: Populate func_no before calling pci_epc_add_epf()

2018-12-01T08:42:57+00:00

commit 0c47cd7a9b6c9c36c08113e594e9ad017fb17865 upstream.

func_no is a member of struct pci_epf.

Since struct pci_epf is used as an argument to pci_epc_add_epf() (to
bind an endpoint function to a controller), struct pci_epf.func_no
should be populated before calling pci_epc_add_epf().

Initialize the struct pci_epf.func_no member before calling
pci_epc_add_epf(), to fix the endpoint function binding to
an endpoint controller.

Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions")
Signed-off-by: Niklas Cassel 
[lorenzo.pieralisi@arm.com: rewrote the commit log]
Signed-off-by: Lorenzo Pieralisi 
Suggested-by: Kishon Vijay Abraham I 
Acked-by: Kishon Vijay Abraham I 
Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

PCI: endpoint: Fix find_first_zero_bit() usage

2018-03-24T10:01:26+00:00

[ Upstream commit 35ad61921f495ee14915d185de79478c1737b4da ]

find_first_zero_bit()'s parameter 'size' is defined in bits,
not in bytes.

Calling find_first_zero_bit() with the wrong size unit
will lead to insidious bugs.

Fix this by calling find_first_zero_bit() with size BITS_PER_LONG,
rather than sizeof() and add missing find_first_zero_bit() return
handling.

Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions")
Signed-off-by: Niklas Cassel 
Signed-off-by: Lorenzo Pieralisi 
Acked-by: Kishon Vijay Abraham I 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

PCI: endpoint: Use correct "end of test" interrupt

2017-09-20T18:56:06+00:00

pci_epf_test_raise_irq() reads the interrupt to use for the response from
reg->command, but this has been cleared at the beginning of the command
handler so the value is always zero at this point.

Instead, extract the interrupt index before handling the command and then
pass the requested interrupt into pci_epf_test_raise_irq().  This allows us
to remove the specific code to extract the interrupt for
COMMAND_RAISE_MSI_IRQ since it is now handled in common code.

Fixes: 3ecf3232c54c ("PCI: endpoint: Do not reset *command* inadvertently")
Signed-off-by: John Keeping 
Signed-off-by: Bjorn Helgaas 
Acked-by: Kishon Vijay Abraham I

Merge branch 'pci/misc' into next

2017-09-07T18:24:16+00:00

* pci/misc:
  PCI: Fix PCIe capability sizes
  PCI: Convert to using %pOF instead of full_name()
  PCI: Constify endpoint pci_epf_type device_type
  PCI: Constify bin_attribute structures
  PCI: Constify hotplug pci_device_id structures
  PCI: Constify hotplug attribute_group structures
  PCI: Constify label attribute_group structures
  PCI: Constify sysfs attribute_group structures

PCI: endpoint: Remove the ->remove() callback

2017-08-29T21:00:38+00:00

epf_test is allocated using devm_kzalloc(). Hence it's not required to
explicitly free it in remove() callback. Since ->remove() callback doesn't
do anything other than freeing epf_test, remove the ->remove() callback.

Signed-off-by: Shawn Lin 
Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Bjorn Helgaas

PCI: endpoint: Add support to poll early for host commands

2017-08-29T21:00:38+00:00

Certain platforms like TI's K2G doesn't support link-up notification. Add
support to poll early (without waiting for the linkup notification) for
commands from the host.

Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Bjorn Helgaas

PCI: endpoint: Add support to use _any_ BAR to map PCI_ENDPOINT_TEST regs

2017-08-29T21:00:37+00:00

pci_epf_test always maps the PCI_ENDPOINT_TEST registers to BAR_0. But if
BAR_0 is reserved for some other purpose (like in TI's K2G BAR_0 is mapped
to application registers and cannot be used to map any other regions),
PCI_ENDPOINT_TEST registers cannot be mapped making pci_epf_test unusable.
Add support to use any BAR to map PCI_ENDPOINT_TEST registers.

Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Bjorn Helgaas