linux.git/drivers/pwm/sysfs.c, branch v4.4.69

pwm: Fix device reference leak

2016-12-08T06:15:24+00:00

commit 0e1614ac84f1719d87bed577963bb8140d0c9ce8 upstream.

Make sure to drop the reference to the parent device taken by
class_find_device() after "unexporting" any children when deregistering
a PWM chip.

Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
Signed-off-by: Johan Hovold 
Signed-off-by: Thierry Reding 
Signed-off-by: Greg Kroah-Hartman

pwm: Unexport children before chip removal

2016-11-10T15:36:37+00:00

commit 0733424c9ba9f42242409d1ece780777272f7ea1 upstream.

Exported pwm channels aren't removed before the pwmchip and are
leaked. This results in invalid sysfs files. This fix removes
all exported pwm channels before chip removal.

Signed-off-by: David Hsu 
Fixes: 76abbdde2d95 ("pwm: Add sysfs interface")
Signed-off-by: Thierry Reding 
Signed-off-by: Greg Kroah-Hartman

pwm: sysfs: Make use of the DEVICE_ATTR_[RW][WO] macro's

2015-11-10T12:06:46+00:00

For the npwm property the PWM sysfs interface already made use of the
DEVICE_ATTR_RO macro. This patch expands this to the other sysfs
properties so that the code base is concise and makes use of this
helpful macro.

This has the advantage of slightly reducing the code size, improving
readability and no longer using magic values for permissions.

Signed-off-by: Olliver Schinagl 
Signed-off-by: Thierry Reding

pwm: sysfs: Remove unnecessary temporary variable

2015-11-10T12:06:45+00:00

Use the result of pwm_is_enabled() directly instead of storing it in a
temporary variable.

Signed-off-by: Olliver Schinagl 
Signed-off-by: Thierry Reding

pwm: sysfs: Remove unnecessary padding

2015-07-27T10:03:38+00:00

Padding initializers so that assignment operators align is bound to lead
to inconsistencies or churn. Single spaces around the assignment is just
fine.

Signed-off-by: Thierry Reding

pwm: sysfs: Properly convert from enum to string

2015-07-27T10:03:37+00:00

The current code will check for polarity in a boolean way. While it is
correct that polarity is either normal or inversed, make it more obvious
that it's an enumeration by using a switch statement and explicit
matches on the enumeration values.

Signed-off-by: Thierry Reding

pwm: Make use of pwm_get_xxx() helpers where appropriate

2015-07-20T07:53:22+00:00

Use the pwm_get_xxx() helpers instead of directly accessing the fields
in struct pwm_device. This will allow us to smoothly move to the atomic
update approach.

Signed-off-by: Boris Brezillon 
Signed-off-by: Thierry Reding

pwm: Add the pwm_is_enabled() helper

2015-07-20T07:46:06+00:00

Some PWM drivers are testing the PWMF_ENABLED flag. Create a helper
function to hide the logic behind enabled test. This will allow us to
smoothly move from the current approach to an atomic PWM update
approach.

Signed-off-by: Boris Brezillon 
Signed-off-by: Thierry Reding

pwm: sysfs: Convert to use ATTRIBUTE_GROUPS macro

2013-12-04T10:35:28+00:00

Use new ATTRIBUTE_GROUPS macro to reduce the number of lines of code.

Signed-off-by: Axel Lin 
Signed-off-by: Thierry Reding

pwm: convert class code to use dev_groups

2013-07-29T07:08:33+00:00

The dev_attrs field of struct class is going away soon, dev_groups
should be used instead.  This converts the PWM class code to use the
correct field.

Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Thierry Reding