linux.git/drivers/rtc/rtc-ds1343.c, branch v5.10.258

rtc: ds1343: Remove unused struct spi_device in struct ds1343_priv

2019-12-23T10:22:32+00:00

struct spi_device in struct ds1343_priv is not used, remove it.

CC: Alessandro Zummo 
CC: Alexandre Belloni 
CC: Raghavendra Chandra Ganiga 
CC: Ankur Srivastava 
Signed-off-by: Nobuhiro Iwamatsu 
Link: https://lore.kernel.org/r/20191218081917.3308211-1-iwamatsu@nigauri.org
Signed-off-by: Alexandre Belloni

rtc: ds1343: Do not hardcode SPI mode flags

2019-12-10T16:47:16+00:00

The current use of mode flags to us SPI_MODE_3 and
SPI_CS_HIGH is fragile: it overwrites anything already
assigned by the SPI core. Change it thusly:

- Just |= the SPI_MODE_3 so we keep other flags
- Assign ^= SPI_CS_HIGH since we might be active high
  already, and that is usually the case with GPIOs used
  for chip select, even if they are in practice active low.

Add a comment clarifying why ^= SPI_CS_HIGH is the right
choice here.

Reported-by: Mark Brown 
Signed-off-by: Linus Walleij 
Link: https://lore.kernel.org/r/20191204225731.20306-1-linus.walleij@linaro.org
Signed-off-by: Alexandre Belloni

rtc: ds1343: cleanup .remove

2019-10-19T20:56:11+00:00

It is not necessary to call device_init_wakeup(dev, false) in .remove as
device_del will take care of that. It is also not necessary to
devm_free_irq. Finally, dev_pm_clear_wake_irq can be called
unconditionally.

Link: https://lore.kernel.org/r/20191019204941.6203-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: rework interrupt handling

2019-10-19T20:56:09+00:00

Rework the interrupt handling to avoid caching the values as the core is
already doing that. The core also always ensures the rtc_time passed for
the alarm is fully populated.

The only trick is in read_alarm where status needs to be read before the
alarm registers to ensure the potential irq is not cleared.

Link: https://lore.kernel.org/r/20191019204941.6203-8-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: remove unnecessary mutex

2019-10-19T20:56:07+00:00

Use rtc_lock and rtc_unlock to lock the rtc from the interrupt handler.
This removes the need for a driver specific lock.

Link: https://lore.kernel.org/r/20191019204941.6203-7-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: check regmap_read return value

2019-10-19T20:56:05+00:00

Check whether regmap_read fails before continuing in the sysfs .show
callbacks.

Link: https://lore.kernel.org/r/20191019204941.6203-6-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: use regmap_update_bits for glitch filter

2019-10-19T20:56:03+00:00

Use regmap_update_bits to update DS1343_CONTROL_REG in a race free manner
when setting the glitch filter.

Link: https://lore.kernel.org/r/20191019204941.6203-5-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: use rtc_add_group

2019-10-19T20:56:01+00:00

Use rtc_add_group to add the sysfs group in a race free manner.
This has the side effect of moving the files to their proper location.

Link: https://lore.kernel.org/r/20191019204941.6203-4-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: use burst write to set time

2019-10-19T20:56:00+00:00

To avoid possible race condition, use regmap_bulk_write to write all the
date/time registers at once instead of sequentially.

Link: https://lore.kernel.org/r/20191019204941.6203-3-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1343: remove dead code

2019-10-19T20:55:58+00:00

RTC_SET_CHARGE doesn't exist, the ioctl code is never used.

Link: https://lore.kernel.org/r/20191019204941.6203-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni