linux.git/drivers/rtc/rtc-ps3.c, branch v6.12.80

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres
by itself - instead it marks an rtc_device as "registered" and the devres
callback for devm_rtc_allocate_device() takes care of resource release.

This doesn't correspond with the design behind devres where managed
structures should not be aware of being managed. The correct solution
here is to register a separate devres callback for unregistering the
device.

While at it: rename rtc_register_device() to devm_rtc_register_device()
and add it to the list of managed interfaces in devres.rst. This way we
can avoid any potential confusion of driver developers who may expect
there to exist a corresponding unregister function.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: ps3: set range

2019-04-04T08:07:10+00:00

The PS3 has a 64bit second counter from 2000. While this exceeds the 64bit
UNIX timestamp, there is not doubt that non of them will still be working
by then.

Signed-off-by: Alexandre Belloni

rtc: ps3: convert to devm_rtc_allocate_device

2019-04-04T08:07:09+00:00

This allows further improvement of the driver.

Signed-off-by: Alexandre Belloni

rtc: ps3: convert to SPDX identifier

2019-04-04T08:07:09+00:00

Use SPDX-License-Identifier instead of a verbose license text.

Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Alexandre Belloni

rtc: ps3: switch to rtc_time64_to_tm/rtc_tm_to_time64

2019-04-04T08:07:09+00:00

Call the 64bit versions of rtc_tm time conversion as the PS3 handles 64bit
values.

Signed-off-by: Alexandre Belloni

rtc: stop validating rtc_time after rtc_time_to_tm

2018-03-01T09:49:41+00:00

rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it.

Signed-off-by: Alexandre Belloni

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

drivers/rtc/rtc-ps3.c: remove empty function

2013-07-03T23:07:58+00:00

After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat 
Acked-by: Geoff Levand 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-ps3: use devm_rtc_device_register()

2013-04-30T01:28:30+00:00

devm_rtc_device_register() is device managed and makes cleanup paths
simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-ps3: use module_platform_driver_probe()

2013-04-30T01:28:24+00:00

Use module_platform_driver_probe() macro which makes the code smaller and
simpler.

Signed-off-by: Jingoo Han 
Acked-by: Geert Uytterhoeven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds