linux.git/drivers/rtc, branch v5.13.4

rtc: fix snprintf() checking in is_rtc_hctosys()

2021-07-20T14:00:36+00:00

[ Upstream commit 54b909436ede47e0ee07f1765da27ec2efa41e84 ]

The scnprintf() function silently truncates the printf() and returns
the number bytes that it was able to copy (not counting the NUL
terminator).  Thus, the highest value it can return here is
"NAME_SIZE - 1" and the overflow check is dead code.  Fix this by
using the snprintf() function which returns the number of bytes that
would have been copied if there was enough space and changing the
condition from "> NAME_SIZE" to ">= NAME_SIZE".

Fixes: 92589c986b33 ("rtc-proc: permit the /proc/driver/rtc device to use other devices")
Signed-off-by: Dan Carpenter 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/YJov/pcGmhLi2pEl@mwanda
Signed-off-by: Sasha Levin

rtc: bd70528: fix BD71815 watchdog dependency

2021-07-20T14:00:36+00:00

[ Upstream commit b0ddc5b170058a9ed3c9f031501d735a4eb8ee89 ]

The added Kconfig dependency is slightly incorrect, which can
lead to a link failure when the watchdog is a loadable module:

arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x6cc): undefined reference to `bd70528_wdt_set'
arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
rtc-bd70528.c:(.text+0xaa0): undefined reference to `bd70528_wdt_lock'
arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0xab8): undefined reference to `bd70528_wdt_unlock'
arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
rtc-bd70528.c:(.text+0xfc0): undefined reference to `bd70528_wdt_lock'
arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0x1030): undefined reference to `bd70528_wdt_unlock'

The problem is that it allows to be built-in if MFD_ROHM_BD71828
is built-in, even when the watchdog is a loadable module.

Rework this so that having the watchdog as a loadable module always
forces the rtc to be a module as well instead of built-in,
regardless of bd71828.

Fixes: c56dc069f268 ("rtc: bd70528: Support RTC on ROHM BD71815")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Guenter Roeck 
Reviewed-by: Matti Vaittinen 
Acked-by: Randy Dunlap  # build-tested
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210422151545.2403356-1-arnd@kernel.org
Signed-off-by: Sasha Levin

rtc: stm32: Fix unbalanced clk_disable_unprepare() on probe error path

2021-07-14T15:06:14+00:00

commit 950ac33dbe6ff656a623d862022f0762ec061ba7 upstream.

The STM32MP1 RTC may have 2 clocks, the pclk and the rtc_ck.

If clk_prepare_enable() fails for the second clock (rtc_ck) we must only
call clk_disable_unprepare() for the first clock (pclk) but currently we
call it on both leading to a WARN:

[   15.629568] WARNING: CPU: 0 PID: 146 at drivers/clk/clk.c:958 clk_core_disable+0xb0/0xc8
[   15.637620] ck_rtc already disabled
[   15.663322] CPU: 0 PID: 146 Comm: systemd-udevd Not tainted 5.4.77-pknbsp-svn5759-atag-v5.4.77-204-gea4235203137-dirty #2413
[   15.674510] Hardware name: STM32 (Device Tree Support)
[   15.679658] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[   15.687371] [] (show_stack) from [] (dump_stack+0xc0/0xe0)
[   15.694574] [] (dump_stack) from [] (__warn+0xc8/0xf0)
[   15.701428] [] (__warn) from [] (warn_slowpath_fmt+0x60/0x94)
[   15.708894] [] (warn_slowpath_fmt) from [] (clk_core_disable+0xb0/0xc8)
[   15.717230] [] (clk_core_disable) from [] (clk_core_disable_lock+0x18/0x24)
[   15.725924] [] (clk_core_disable_lock) from [] (stm32_rtc_probe+0x124/0x5e4 [rtc_stm32])
[   15.735739] [] (stm32_rtc_probe [rtc_stm32]) from [] (platform_drv_probe+0x48/0x98)
[   15.745095] [] (platform_drv_probe) from [] (really_probe+0x1f0/0x458)
[   15.753338] [] (really_probe) from [] (driver_probe_device+0x70/0x1c4)
[   15.761584] [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60)
[   15.770439] [] (device_driver_attach) from [] (__driver_attach+0xcc/0x170)
[   15.779032] [] (__driver_attach) from [] (bus_for_each_dev+0x58/0x7c)
[   15.787191] [] (bus_for_each_dev) from [] (bus_add_driver+0xdc/0x1f8)
[   15.795352] [] (bus_add_driver) from [] (driver_register+0x7c/0x110)
[   15.803425] [] (driver_register) from [] (do_one_initcall+0x70/0x1b8)
[   15.811588] [] (do_one_initcall) from [] (do_init_module+0x58/0x1f8)
[   15.819660] [] (do_init_module) from [] (load_module+0x1e58/0x23c8)
[   15.827646] [] (load_module) from [] (sys_finit_module+0xa0/0xd4)
[   15.835459] [] (sys_finit_module) from [] (__sys_trace_return+0x0/0x20)

Signed-off-by: Martin Fuzzey 
Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver")
Cc: stable@vger.kernel.org
Reviewed-by: Nobuhiro Iwamatsu 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/1623087421-19722-1-git-send-email-martin.fuzzey@flowbird.group
Signed-off-by: Greg Kroah-Hartman

Merge tag 'rtc-5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux

2021-05-03T19:15:21+00:00

Pull RTC updates from Alexandre Belloni:
 "Mostly small fixes and two drivers gaining alarm support. Summary:

  Subsystem:

    - UIE emulation has been reworked to avoid calling driver callbacks
      when it is known it will not work

  Drivers:

   - ab-eoz9: add alarm support

   - pcf8523: add alarm support"

* tag 'rtc-5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux: (27 commits)
  rtc: sysfs: check features instead of ops
  rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG
  rtc: s5m: Remove reference to parent's device pdata
  rtc: ds1307: Fix wday settings for rx8130
  rtc: pcf8523: report oscillator failures
  rtc: pcf8523: add alarm support
  rtc: pcf8523: remove useless define
  rtc: rtc_update_irq_enable: rework UIE emulation
  rtc: ds1307: remove flags
  rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM
  rtc: imx-sc: remove .read_alarm
  rtc: ds1511: remove unused function
  rtc: fsl-ftm-alarm: add MODULE_TABLE()
  rtc: rtc-spear: replace spin_lock_irqsave by spin_lock in hard IRQ
  dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings
  rtc: pm8xxx: Add RTC support for PMIC PMK8350
  rtc: ab-eoz9: make use of RTC_FEATURE_ALARM
  rtc: ab-eoz9: add alarm support
  rtc: ab-eoz9: set regmap max_register
  rtc: pcf85063: fallback to parent of_node
  ...

rtc: sysfs: check features instead of ops

2021-04-29T21:51:18+00:00

Test RTC_FEATURE_ALARM instead of relying on .set_alarm to know whether
alarms are available.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210429214403.2610952-1-alexandre.belloni@bootlin.com

rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG

2021-04-29T21:37:18+00:00

The RTC_OSC_REG register is 32-bit, but the useful information is found
in the 7 least significant bits (bits 7-31 are reserved). And in fact,
as you can see from the code, all read accesses are 8-bit, as well as
some writes. Let's make sure all writes are 8-bit. Moreover, in contexts
where consecutive reads / writes after the busy check must take place
within 15 us, it is better not to waste time on useless accesses.

Signed-off-by: Dario Binacchi 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210425145924.23353-1-dariobin@libero.it

rtc: s5m: Remove reference to parent's device pdata

2021-04-29T21:37:18+00:00

The S5M RTC driver does not use parent's device (sec-core PMIC driver)
platform data so there is no need to check for it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210420170244.13467-3-krzysztof.kozlowski@canonical.com

rtc: ds1307: Fix wday settings for rx8130

2021-04-29T21:37:18+00:00

rx8130 wday specifies the bit position, not BCD.

Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
Signed-off-by: Nobuhiro Iwamatsu 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210420023917.1949066-1-nobuhiro1.iwamatsu@toshiba.co.jp

rtc: pcf8523: report oscillator failures

2021-04-29T21:37:18+00:00

Report oscillator failures and invalid date/time on RTC_VL_READ.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210418002023.1000265-3-alexandre.belloni@bootlin.com

rtc: pcf8523: add alarm support

2021-04-29T21:37:18+00:00

Alarm support requires unconditionally disabling clock out because it is
using the int1 pin.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210418002023.1000265-2-alexandre.belloni@bootlin.com