linux.git/drivers/rtc, branch v5.4.131

rtc: ds1307: Fix wday settings for rx8130

2021-05-19T08:08:26+00:00

[ Upstream commit 204756f016726a380bafe619438ed979088bd04a ]

rx8130 wday specifies the bit position, not BCD.

Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
Signed-off-by: Nobuhiro Iwamatsu 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210420023917.1949066-1-nobuhiro1.iwamatsu@toshiba.co.jp
Signed-off-by: Sasha Levin

rtc: fsl-ftm-alarm: add MODULE_TABLE()

2021-05-19T08:08:25+00:00

[ Upstream commit 7fcb86185978661c9188397d474f90364745b8d9 ]

The module doesn't load automatically. Fix it by adding the missing
MODULE_TABLE().

Fixes: 7b0b551dbc1e ("rtc: fsl-ftm-alarm: add FTM alarm driver")
Signed-off-by: Michael Walle 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210414084006.17933-1-michael@walle.cc
Signed-off-by: Sasha Levin

rtc: s5m: select REGMAP_I2C

2021-03-04T09:26:29+00:00

[ Upstream commit 1f0cbda3b452b520c5f3794f8f0e410e8bc7386a ]

The rtc-s5m uses the I2C regmap but doesn't select it in Kconfig so
depending on the configuration the build may fail. Fix it.

Fixes: 959df7778bbd ("rtc: Enable compile testing for Maxim and Samsung drivers")
Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210114102219.23682-2-brgl@bgdev.pl
Signed-off-by: Sasha Levin

rtc: pl031: fix resource leak in pl031_probe

2021-01-06T13:48:39+00:00

[ Upstream commit 1eab0fea2514b269e384c117f5b5772b882761f0 ]

When devm_rtc_allocate_device is failed in pl031_probe, it should release
mem regions with device.

Reported-by: Hulk Robot 
Signed-off-by: Zheng Liang 
Signed-off-by: Alexandre Belloni 
Acked-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201112093139.32566-1-zhengliang6@huawei.com
Signed-off-by: Sasha Levin

rtc: sun6i: Fix memleak in sun6i_rtc_clk_init

2021-01-06T13:48:39+00:00

[ Upstream commit 28d211919e422f58c1e6c900e5810eee4f1ce4c8 ]

When clk_hw_register_fixed_rate_with_accuracy() fails,
clk_data should be freed. It's the same for the subsequent
two error paths, but we should also unregister the already
registered clocks in them.

Signed-off-by: Dinghao Liu 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201020061226.6572-1-dinghao.liu@zju.edu.cn
Signed-off-by: Sasha Levin

rtc: ep93xx: Fix NULL pointer dereference in ep93xx_rtc_read_time

2020-12-30T10:51:47+00:00

commit 00c33482bb6110bce8110daa351f9b3baf4df7dc upstream.

Mismatch in probe platform_set_drvdata set's and method's that call
dev_get_platdata will result in "Unable to handle kernel NULL pointer
dereference", let's use according method for getting driver data after
platform_set_drvdata.

8<--- cut here ---
Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = (ptrval)
[00000000] *pgd=00000000
Internal error: Oops: 5 [#1] ARM
Modules linked in:
CPU: 0 PID: 1 Comm: swapper Not tainted 5.9.10-00003-g723e101e0037-dirty #4
Hardware name: Technologic Systems TS-72xx SBC
PC is at ep93xx_rtc_read_time+0xc/0x2c
LR is at __rtc_read_time+0x4c/0x8c
[...]
[] (ep93xx_rtc_read_time) from [] (__rtc_read_time+0x4c/0x8c)
[] (__rtc_read_time) from [] (rtc_read_time+0x2c/0x4c)
[] (rtc_read_time) from [] (__rtc_read_alarm+0x28/0x358)
[] (__rtc_read_alarm) from [] (__rtc_register_device+0x124/0x2ec)
[] (__rtc_register_device) from [] (ep93xx_rtc_probe+0xa4/0xac)
[] (ep93xx_rtc_probe) from [] (platform_drv_probe+0x24/0x5c)
[] (platform_drv_probe) from [] (really_probe+0x218/0x374)
[] (really_probe) from [] (device_driver_attach+0x44/0x60)
[] (device_driver_attach) from [] (__driver_attach+0xb4/0xc0)
[] (__driver_attach) from [] (bus_for_each_dev+0x68/0xac)
[] (bus_for_each_dev) from [] (driver_attach+0x18/0x24)
[] (driver_attach) from [] (bus_add_driver+0x150/0x1b4)
[] (bus_add_driver) from [] (driver_register+0xb0/0xf4)
[] (driver_register) from [] (__platform_driver_register+0x30/0x48)
[] (__platform_driver_register) from [] (ep93xx_rtc_driver_init+0x10/0x1c)
[] (ep93xx_rtc_driver_init) from [] (do_one_initcall+0x7c/0x1c0)
[] (do_one_initcall) from [] (kernel_init_freeable+0x168/0x1ac)
[] (kernel_init_freeable) from [] (kernel_init+0x8/0xf4)
[] (kernel_init) from [] (ret_from_fork+0x14/0x34)
Exception stack(0xc441dfb0 to 0xc441dff8)
dfa0:                                     00000000 00000000 00000000 00000000
dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
Code: e12fff1e e92d4010 e590303c e1a02001 (e5933000)
---[ end trace c914d6030eaa95c8 ]---

Fixes: b809d192eb98 ("rtc: ep93xx: stop setting platform_data")
Signed-off-by: Nikita Shubin 
Signed-off-by: Alexandre Belloni 
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201201095507.10317-1-nikita.shubin@maquefel.me
Signed-off-by: Greg Kroah-Hartman

rtc: pcf2127: fix pcf2127_nvmem_read/write() returns

2020-12-30T10:51:02+00:00

[ Upstream commit ba1c30bf3f2536f248d262c6f257b5a787305991 ]

These functions should return zero on success.  Non-zero returns are
treated as error.  On some paths, this doesn't matter but in
nvmem_cell_read() a non-zero return would be passed to ERR_PTR() and
lead to an Oops.

Fixes: d6c3029f32f7 ("rtc: pcf2127: add support for accessing internal static RAM")
Signed-off-by: Dan Carpenter 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201022070451.GA2817669@mwanda
Signed-off-by: Sasha Levin

rtc: rx8010: don't modify the global rtc ops

2020-11-05T10:43:33+00:00

commit d3b14296da69adb7825022f3224ac6137eb30abf upstream.

The way the driver is implemented is buggy for the (admittedly unlikely)
use case where there are two RTCs with one having an interrupt configured
and the second not. This is caused by the fact that we use a global
rtc_class_ops struct which we modify depending on whether the irq number
is present or not.

Fix it by using two const ops structs with and without alarm operations.
While at it: not being able to request a configured interrupt is an error
so don't ignore it and bail out of probe().

Fixes: ed13d89b08e3 ("rtc: Add Epson RX8010SJ RTC driver")
Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Alexandre Belloni 
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200914154601.32245-2-brgl@bgdev.pl
Signed-off-by: Greg Kroah-Hartman

rtc: ds1374: fix possible race condition

2020-10-01T11:17:43+00:00

[ Upstream commit c11af8131a4e7ba1960faed731ee7e84c2c13c94 ]

The RTC IRQ is requested before the struct rtc_device is allocated,
this may lead to a NULL pointer dereference in the IRQ handler.

To fix this issue, allocating the rtc_device struct before requesting
the RTC IRQ using devm_rtc_allocate_device, and use rtc_register_device
to register the RTC device.

Link: https://lore.kernel.org/r/20200306073404.56921-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni 
Signed-off-by: Sasha Levin

rtc: sa1100: fix possible race condition

2020-10-01T11:17:43+00:00

[ Upstream commit f2997775b111c6d660c32a18d5d44d37cb7361b1 ]

Both RTC IRQs are requested before the struct rtc_device is allocated,
this may lead to a NULL pointer dereference in the IRQ handler.

To fix this issue, allocating the rtc_device struct before requesting
the IRQs using devm_rtc_allocate_device, and use rtc_register_device
to register the RTC device.

Link: https://lore.kernel.org/r/20200306010146.39762-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni 
Signed-off-by: Sasha Levin