linux.git/drivers/soc/amlogic, branch v4.19.321

meson-mx-socinfo: Fix refcount leak in meson_mx_socinfo_init

2022-08-25T09:15:00+00:00

[ Upstream commit a2106f38077e78afcb4bf98fdda3e162118cfb3d ]

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 5e68c0fc8df8 ("soc: amlogic: Add Meson6/Meson8/Meson8b/Meson8m2 SoC Information driver")
Signed-off-by: Miaoqian Lin 
Reviewed-by: Martin Blumenstingl 
Signed-off-by: Neil Armstrong 
Link: https://lore.kernel.org/r/20220524065729.33689-1-linmq006@gmail.com
Signed-off-by: Sasha Levin

soc: amlogic: meson-gx-pwrc-vpu: Fix power on/off register bitmask

2020-01-27T13:50:39+00:00

[ Upstream commit 2fe3b4bbc93ec30a173ebae7d2b8c530416df3af ]

The register bitmask to power on/off the VPU memories was incorectly set
to 0x2 instead of 0x3. While still working, let's use the recommended
vendor value instead.

Fixes: 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
Signed-off-by: Neil Armstrong 
Signed-off-by: Kevin Hilman 
Signed-off-by: Sasha Levin

soc: amlogic: gx-socinfo: Add mask for each SoC packages

2020-01-27T13:50:32+00:00

[ Upstream commit dce47aed20c7de3ee2011b7a63e67f08e9dcfb5e ]

When updated IDs on f842c41adc04 ("amlogic: meson-gx-socinfo: Update soc ids")
we introduced packages ids using the full 8bit value, but in the function
socinfo_to_package_id() the id was filtered with the 0xf0 mask.

While the 0xf0 mask is valid for most board, it filters out the lower
4 bits which encodes some characteristics of the chip.

This patch moves the mask into the meson_gx_package_id table to be applied
on each package name independently and add the correct mask for some
specific entries.

An example is the S905, in the vendor code the S905 is package_id
different from 0x20, and S905M is exactly 0x20.

Another example are the The Wetek Hub & Play2 boards using a S905-H
variant, which is the S905 SoC with some licence bits enabled.
These licence bits are encoded in the lower 4bits, so to detect
the -H variant, we must detect the id == 0x3 with the 0xf mask.

Fixes: f842c41adc04 ("amlogic: meson-gx-socinfo: Update soc ids")
Signed-off-by: Neil Armstrong 
Signed-off-by: Kevin Hilman 
Signed-off-by: Sasha Levin

amlogic: meson-gx-socinfo: Update soc ids

2018-03-19T23:40:26+00:00

Updates the Amlogic Meson SoCs IDs for the Armv8 based SoCs.
It includes the new families and packages.

Signed-off-by: Neil Armstrong 
Signed-off-by: Kevin Hilman

meson-gx-socinfo: make local function meson_gx_socinfo_init static

2018-02-12T22:15:47+00:00

Fixes the following sparse warnings:

drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
 symbol 'meson_gx_socinfo_init' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
Acked-by: Neil Armstrong 
Signed-off-by: Kevin Hilman

meson-mx-socinfo: Make local function meson_mx_socinfo_init() static

2018-02-12T22:15:47+00:00

Fixes the following sparse warnings:

drivers/soc/amlogic/meson-mx-socinfo.c:107:12: warning:
 symbol 'meson_mx_socinfo_init' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
Signed-off-by: Kevin Hilman

soc: amlogic: meson-gx-pwrc-vpu: fix error on shutdown when domain is powered off

2018-02-12T22:15:46+00:00

When operating the system headless headless, the domain is never
powered on, leaving the clocks disabled. The shutdown function then
tries to disable the already disabled clocks, resulting in errors.
Therefore call meson_gx_pwrc_vpu_power_off() only if domain is
powered on.
This patch fixes the described issue on my system (Odorid-C2).

Fixes: 339cd0ea0822 "soc: amlogic: meson-gx-pwrc-vpu: fix power-off when powered by bootloader"
Signed-off-by: Heiner Kallweit 
Reviewed-by: Neil Armstrong 
Signed-off-by: Kevin Hilman

soc: amlogic: meson-gx-pwrc-vpu: don't print error message on probe deferral

2018-02-12T22:15:46+00:00

The error message may be misleading in case of probe deferral
(happens on my Odroid-C2). Therefore don't print it in this case.

Fixes: 75fcb5ca4b46 "soc: amlogic: add Meson GX VPU Domains driver"
Signed-off-by: Heiner Kallweit 
Acked-by: Neil Armstrong 
Signed-off-by: Kevin Hilman

meson-gx-socinfo: Fix package id parsing

2017-11-30T23:29:44+00:00

I've noticed the following message while booting a S905X based board:

soc soc0: Amlogic Meson GXL (S905D) Revision 21:82 (b:2) Detected

The S905D string is obviously wrong. The vendor code does:
...
        ver = (readl(assist_hw_rev) >> 8) & 0xff;
        meson_cpu_version[MESON_CPU_VERSION_LVL_MINOR] = ver;
        ver =  (readl(assist_hw_rev) >> 16) & 0xff;
        meson_cpu_version[MESON_CPU_VERSION_LVL_PACK] = ver;
...

while the current code does:
...
...

This means that the current mainline code has package id and minor
version reversed.

Fixes: a9daaba2965e8 ("soc: Add Amlogic SoC Information driver")
Signed-off-by: Arnaud Patard 
Acked-by: Neil Armstrong 
Signed-off-by: Kevin Hilman

soc: amlogic: meson-gx-pwrc-vpu: fix power-off when powered by bootloader

2017-11-09T10:42:17+00:00

In the case the VPU power domain has been powered on by the bootloader
and no driver are attached to this power domain, the genpd will power it
off after a certain amount of time, but the clocks hasn't been enabled
by the kernel itself and the power-off will trigger some faults.
This patch enable the clocks to have a coherent state for an eventual
poweroff and switches to the pm_domain_always_on_gov governor.

Fixes: 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
Signed-off-by: Neil Armstrong 
Tested-by: Kevin Hilman 
Signed-off-by: Arnd Bergmann