linux.git/drivers/staging/octeon-usb, branch master

staging: octeon-usb: move driver out of staging

2022-06-21T14:43:37+00:00

The Octeon usb driver has been in staging for a long time and used in
Ubiquiti routers for a while now.
It's been built and then tested on real hardware with several usb devices
and it is proven to be stable and ready to be moved to its proper place
in the kernel tree.

Move it to drivers/usb/host and adjust its Makefile, Kconfig and defconfig
dependencies.

Many thanks to the developers who made it happen.

Signed-off-by: Artur Bujdoso 
Link: https://lore.kernel.org/r/Yo0HBIlSXOBM+//9@crux
Signed-off-by: Greg Kroah-Hartman

staging: octeon-hcd: Directly include linux/of.h

2021-06-10T12:09:15+00:00

This drivers currently obtains linux/of.h by luck and a chain of
bizarre inclusions, which we're about to fix.

Let's include the required file directly.

Signed-off-by: Marc Zyngier

staging: octeon-usb: Match alignment with open parenthesis

2021-03-18T09:20:33+00:00

This patches fixes the checks- 'Alignment should match open parenthesis'
of 'checkpatch.pl'.

Signed-off-by: Mahak Gupta 
Link: https://lore.kernel.org/r/20210317183846.4867-1-gmahak1@gmail.com
Signed-off-by: Greg Kroah-Hartman

drivers: staging: octeon-usb: fixed codestyle check warning

2020-09-13T07:21:15+00:00

Fixed line cannot end with '(' check.

Signed-off-by: Naveen Panwar 
Link: https://lore.kernel.org/r/20200908030239.10131-1-naveen.panwar27@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: Replace zero-length array with flexible-array member

2020-02-23T18:18:54+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Link: https://lore.kernel.org/r/20200220132908.GA30501@embeddedor
Signed-off-by: Greg Kroah-Hartman

Revert "staging: octeon-usb: delete the octeon usb host controller driver"

2020-02-12T21:50:32+00:00

This reverts commit 95ace52e4036482da1895b6e19f15141802cc3dd. Re-instate
the code so subsequent commits can clean it up and get it building
properly.

Signed-off-by: Chris Packham 
Link: https://lore.kernel.org/r/20200205001116.14096-2-chris.packham@alliedtelesis.co.nz
Signed-off-by: Greg Kroah-Hartman

staging: octeon-usb: delete the octeon usb host controller driver

2019-12-17T11:54:55+00:00

This driver was merged back in 2013 and shows no progress toward every
being merged into the "correct" part of the kernel.  The code doesn't
even build for anyone unless you have the specific hardware platform
selected, so odds are it doesn't even work anymore.

Remove it for now and is someone comes along that has the hardware and
is willing to fix it up, it can be reverted.

Cc: Aaro Koskinen 
Cc: David Daney 
Cc: Nishka Dasgupta 
Cc: Himadri Pandya 
Cc: "Frank A. Cancio Bello" 
Cc: Sumit Pundir 
Cc: Laura Lazzati 
Signed-off-by: Greg Kroah-Hartman 
Link: https://lore.kernel.org/r/20191210091509.3546251-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

staging: octeon-usb: Fix line ending with a '('

2019-10-28T15:41:42+00:00

checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"

Signed-off-by: Frank A. Cancio Bello 
Link: https://lore.kernel.org/r/20191028042111.tzfhugs6f4erohir@linux-kernel-dev
Signed-off-by: Greg Kroah-Hartman

usb: add a HCD_DMA flag instead of guestimating DMA capabilities

2019-08-21T17:03:35+00:00

The usb core is the only major place in the kernel that checks for
a non-NULL device dma_mask to see if a device is DMA capable.  This
is generally a bad idea, as all major busses always set up a DMA mask,
even if the device is not DMA capable - in fact bus layers like PCI
can't even know if a device is DMA capable at enumeration time.  This
leads to lots of workaround in HCD drivers, and also prevented us from
setting up a DMA mask for platform devices by default last time we
tried.

Replace this guess with an explicit HCD_DMA that is set by drivers that
appear to have DMA support.

Signed-off-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20190816062435.881-4-hch@lst.de
Signed-off-by: Greg Kroah-Hartman

staging: octeon-usb: Remove return variable

2019-05-30T21:13:45+00:00

Remove return variable result and return the value directly.
Issue found using Coccinelle.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman