linux.git/drivers/staging/panel, branch v3.15

Staging: panel: Fix quoted string split across line in panel.c

2014-02-27T20:29:24+00:00

This patch fixes the following checkpatch.pl warning in panel.c:
WARNING: quoted string split across lines

Signed-off-by: Monam Agarwal 
Signed-off-by: Greg Kroah-Hartman

Staging: panel: Fix space prohibited between function name and open paranthesis

2014-02-27T20:29:24+00:00

This patch fixes the following checkpatch.pl issues in panel.c:
WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Monam Agarwal 
Signed-off-by: Greg Kroah-Hartman

staging: panel: fix interruptible_sleep_on race

2014-01-09T18:41:44+00:00

interruptible_sleep_on is racy and going away. This replaces the one
caller in the panel driver with the appropriate wait_event_interruptible
variant.

Signed-off-by: Arnd Bergmann 
Cc: devel@driverdev.osuosl.org
Cc: Willy Tarreau 
Cc: Greg Kroah-Hartman 
Signed-off-by: Greg Kroah-Hartman

Staging: Panel: panel: Fixed checkpatch line length warnings

2013-05-16T23:01:46+00:00

Fixed 4 cases of line length issues with checkpatch. Checkpatch is now clean
for panel.c.

Signed-off-by: 'Jake Champlin '
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging/panel: Mark local functions/structs static and add const if applicable (fix sparse warnings)

2013-02-15T18:20:14+00:00

sparse complains about the following functions:
panel.c:188:1: warning: symbol 'logical_inputs' was not declared. Should it be static?
panel.c:569:6: warning: symbol 'old_keypad_profile' was not declared. Should it be static?
panel.c:580:6: warning: symbol 'new_keypad_profile' was not declared. Should it be static?
panel.c:593:6: warning: symbol 'nexcom_keypad_profile' was not declared. Should it be static?
panel.c:672:6: warning: symbol 'pin_to_bits' was not declared. Should it be static?
panel.c:1375:6: warning: symbol 'panel_lcd_print' was not declared. Should it be static?
panel.c:1382:6: warning: symbol 'lcd_init' was not declared. Should it be static?
panel.c:2181:5: warning: symbol 'panel_init' was not declared. Should it be static?

Add the static keyword to silence these warnings and make sparse happy.

If structs or function parameters are used readonly they are also marked
as const.

CC: David Howells 
Signed-off-by: Peter Huewe 
Signed-off-by: Greg Kroah-Hartman

staging: panel: pass correct lengths to keypad_send_key()

2012-11-30T02:16:15+00:00

We changed the sizeof() statements in 429ccf058b "staging:panel: Fixed
coding conventions." so that they could fit inside the 80 character
line limit.  Unfortunately, the new sizeof() statements are a smaller
size.  This reverts it.

There isn't a nice way to stay within the 80 character limit without
a re-work so I've gone over.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: Fix misspellings of "whether".

2012-09-21T15:56:40+00:00

"Whether" is spelled "wether" in several places. This fixes those that
are in the staging tree.

Signed-off-by: Adam Buchbinder 
Signed-off-by: Greg Kroah-Hartman

Staging: panel: fix spinlock trylock failure on UP

2012-09-10T18:23:32+00:00

Use spin_lock_irq() to quiet warning:

         [    8.232324] BUG: spinlock trylock failure on UP on CPU#0, reboot/85
         [    8.234138]  lock: c161c760, .magic: dead4ead, .owner: reboot/85, .owner_cpu: 0
         [    8.236132] Pid: 85, comm: reboot Not tainted 3.4.0-rc7-00656-g82163ed #5
         [    8.237965] Call Trace:
         [    8.238648]  [] ? printk+0x18/0x1a
         [    8.239827]  [] spin_dump+0x80/0xd0
         [    8.241016]  [] spin_bug+0x22/0x30
         [    8.242181]  [] do_raw_spin_trylock+0x5b/0x70
         [    8.243611]  [] _raw_spin_trylock+0xe/0x60
         [    8.244975]  [] ? keypad_send_key.constprop.9+0xe0/0xe0
 ==>     [    8.246638]  [] panel_scan_timer+0xba/0x570
         [    8.248019]  [] ? keypad_send_key.constprop.9+0xe0/0xe0
         [    8.249689]  [] run_timer_softirq+0x1e5/0x370
         [    8.251191]  [] ? run_timer_softirq+0x135/0x370
         [    8.252718]  [] ? keypad_send_key.constprop.9+0xe0/0xe0
         [    8.254462]  [] __do_softirq+0xc2/0x1c0
         [    8.255758]  [] ? local_bh_enable_ip+0x130/0x130
         [    8.257228]    [] ? irq_exit+0x65/0x70
         [    8.258647]  [] ? smp_apic_timer_interrupt+0x49/0x80
         [    8.260226]  [] ? apic_timer_interrupt+0x31/0x38
         [    8.261737]  [] ? drm_vm_open_locked+0x70/0xb0
         [    8.263166]  [] ? delay_tsc+0x1a/0x30
         [    8.264452]  [] ? __delay+0x9/0x10
         [    8.265621]  [] ? __const_udelay+0x1c/0x20
 ==>     [    8.266967]  [] ? lcd_clear_fast_p8+0x9c/0xe0
         [    8.268386]  [] ? lcd_write+0x226/0x810
         [    8.269653]  [] ? md_set_readonly+0xc0/0xc0
         [    8.271013]  [] ? do_raw_spin_unlock+0x9d/0xe0
         [    8.272470]  [] ? panel_lcd_print+0x38/0x40
         [    8.273837]  [] ? panel_notify_sys+0x2e/0x60
         [    8.275224]  [] ? notifier_call_chain+0x84/0xb0
         [    8.276754]  [] ? __blocking_notifier_call_chain+0x3e/0x60
         [    8.278576]  [] ? blocking_notifier_call_chain+0x1a/0x20
         [    8.280267]  [] ? kernel_restart_prepare+0x14/0x40
         [    8.281901]  [] ? kernel_restart+0xe/0x50
         [    8.283216]  [] ? sys_reboot+0x149/0x1e0
         [    8.284532]  [] ? handle_pte_fault+0x93/0xd70
         [    8.285956]  [] ? do_page_fault+0x215/0x5e0
         [    8.287330]  [] ? do_page_fault+0x4f3/0x5e0
         [    8.288704]  [] ? up_read+0x16/0x30
         [    8.289890]  [] ? do_page_fault+0x4f3/0x5e0
         [    8.291252]  [] ? iterate_supers+0x86/0xd0
         [    8.292615]  [] ? do_raw_spin_unlock+0x9d/0xe0
         [    8.294049]  [] ? _raw_spin_unlock+0x1d/0x20
         [    8.295449]  [] ? iterate_supers+0xab/0xd0
         [    8.296795]  [] ? __sync_filesystem+0xa0/0xa0
         [    8.298199]  [] ? sysenter_do_call+0x12/0x37
         [    8.306899] Restarting system.
         [    8.307747] machine restart

Signed-off-by: Fengguang Wu 
Signed-off-by: Greg Kroah-Hartman

staging: panel: fix checkpatch warnings

2012-08-14T02:25:48+00:00

Now checkpatch clean.

$ find drivers/staging/panel -name "*.[ch]"|xargs ./scripts/checkpatch.pl \
-f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n

2  WARNING: Single statement macros should not use a do {} while (0) loop

Signed-off-by: Toshiaki Yamane 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Use pr_info(...) rather than printk(KERN_INFO

2012-07-17T01:57:26+00:00

-Added pr_fmt.
-Converted printk(KERN_INFO to pr_info
-Removed embedded message prefixes.

Signed-off-by: Toshiaki Yamane 
Signed-off-by: Greg Kroah-Hartman