linux.git/drivers/staging/rtl8712, branch v5.3.2

staging: rtl8712: Replace function r8712_dequeue_cmd()

2019-07-01T08:44:06+00:00

Remove function r8712_dequeue_cmd as all it does is call _dequeue_cmd.
Rename _dequeue_cmd to r8712_dequeue_cmd and change its type from static
to non-static to maintain compatibility with call sites.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Replace function r8712_enqueue_cmd()

2019-07-01T08:44:06+00:00

Merge function _enqueue_cmd into function r8712_enqueue_cmd as
_enqueue_cmd is only called by r8712_enqueue_cmd, and then only once.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: r8712_xmit_resource_alloc(): Change return values

2019-07-01T08:44:06+00:00

Change call site of function r8712_xmit_resource_alloc to add a check
for its return value.
Change return values of r8712_xmit_resource_alloc from
_SUCCESS/_FAIL to 0/-ENOMEM.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: _r8712_init_sta_priv(): Change return values

2019-07-01T08:44:06+00:00

Add check for the return value of function _r8712_init_sta_priv at call
site.
Change return values of the function from _SUCCESS/_FAIL to 0/-ENOMEM
respectively.
Change return type of the function from u32 to int to enable return of
-ENOMEM.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: _r8712_free_sta_priv(): Change return type

2019-07-01T08:44:06+00:00

Change return type of function _r8712_free_sta_priv from u32 to void as
it always returns _SUCCESS and this return value is never used.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: mp_start_test(): Change return values

2019-07-01T08:44:06+00:00

Change return values of function mp_start_test() from _SUCCESS/_FAIL to
0/-ENOMEM and modify call sites accordingly.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: r8712_parse_wpa2_ie(): Change return values

2019-07-01T08:44:06+00:00

Change return values of function r8712_parse_wpa2_ie from
_SUCCESS/_FAIL to 0/-EINVAL.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: r8712_parse_wpa_ie(): Change return values

2019-07-01T08:44:06+00:00

Change return values of function r8712_parse_wpa_ie from _SUCCESS/_FAIL
to 0/-EINVAL. Modify call site accordingly.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Change return values of r8712_getrfreg_cmd()

2019-07-01T08:44:05+00:00

Change return values of r8712_getrfreg_cmd from _SUCCESS/_FAIL to
0/-ENOMEM respectively. Modify call site accordingly.

Signed-off-by: Nishka Dasgupta 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: reduce stack usage, again

2019-06-28T12:54:45+00:00

An earlier patch I sent reduced the stack usage enough to get
below the warning limit, and I could show this was safe, but with
GCC_PLUGIN_STRUCTLEAK_BYREF_ALL, it gets worse again because large stack
variables in the same function no longer overlap:

drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In function 'translate_scan.isra.2':
drivers/staging/rtl8712/rtl871x_ioctl_linux.c:322:1: error: the frame size of 1200 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]

Split out the largest two blocks in the affected function into two
separate functions and mark those noinline_for_stack.

Fixes: 8c5af16f7953 ("staging: rtl8712: reduce stack usage")
Fixes: 81a56f6dcd20 ("gcc-plugins: structleak: Generalize to all variable types")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman