linux.git/drivers/thermal/devfreq_cooling.c, branch v5.16.1

thermal/drivers/devfreq_cooling: use HZ macros

2021-09-08T18:50:25+00:00

HZ unit conversion macros are available in units.h, use them and remove
the duplicate definition.

The new macro uses a unsigned long type which is already the type in the
current code via the 'freq' variable.

Link: https://lkml.kernel.org/r/20210816114732.1834145-4-daniel.lezcano@linaro.org
Signed-off-by: Daniel Lezcano 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Christian Eggers 
Cc: Chanwoo Choi 
Cc: Guenter Roeck 
Cc: Jonathan Cameron 
Cc: Jonathan Cameron 
Cc: Kyungmin Park 
Cc: Lars-Peter Clausen 
Cc: Lukasz Luba 
Cc: Maxime Coquelin 
Cc: Miquel Raynal 
Cc: MyungJoo Ham 
Cc: Peter Meerwald 
Cc: "Rafael J. Wysocki" 
Cc: Zhang Rui 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

thermal: devfreq_cooling: Fix kernel-doc

2021-07-04T16:28:04+00:00

Fix function name in devfreq_cooling.c comment to remove a
warning found by kernel-doc.

drivers/thermal/devfreq_cooling.c:479: warning: expecting prototype for
devfreq_cooling_em_register_power(). Prototype was for
devfreq_cooling_em_register() instead.

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Reviewed-by: Nick Desaulniers 
Reviewed-by: Nathan Chancellor 
Reviewed-by: Lukasz Luba 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/1623223350-128104-1-git-send-email-yang.lee@linux.alibaba.com

thermal/drivers/devfreq_cooling: Fix wrong return on error path

2021-04-15T11:21:16+00:00

The following error is reported by kbuild:

 smatch warnings:
 drivers/thermal/devfreq_cooling.c:433 of_devfreq_cooling_register_power() warn: passing zero to 'ERR_PTR'

Fix the error code by the setting the 'err' variable instead of 'cdev'.

Fixes: f8d354e821b2 ("thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering")
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20210319202424.890968-1-daniel.lezcano@linaro.org

thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

2021-03-15T03:47:04+00:00

Currently the naming of a cooling device is just a cooling technique
followed by a number. When there are multiple cooling devices using
the same technique, it is impossible to clearly identify the related
device as this one is just a number.

For instance:

 thermal-devfreq-0
 thermal-devfreq-1
 etc ...

The 'thermal' prefix is redundant with the subsystem namespace. This
patch removes the 'thermal' prefix and changes the number by the device
name. So the naming above becomes:

 devfreq-5000000.gpu
 devfreq-1d84000.ufshc
 etc ...

Signed-off-by: Daniel Lezcano 
Reviewed-by: Lukasz Luba 
Link: https://lore.kernel.org/r/20210314111333.16551-3-daniel.lezcano@linaro.org

thermal/drivers/devfreq_cooling: Fix the build when !ENERGY_MODEL

2020-12-15T16:03:56+00:00

Prevent build failure if the option CONFIG_ENERGY_MODEL is not set. The
devfreq cooling is able to operate without the Energy Model.
Don't use dev->em_pd directly and use local pointer.

Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM")
Reported-by: Stephen Rothwell 
Signed-off-by: Lukasz Luba 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20201215154221.8828-1-lukasz.luba@arm.com

thermal: devfreq_cooling: remove old power model and use EM

2020-12-11T13:10:44+00:00

Remove old power model and use new Energy Model to calculate the power
budget. It drops static + dynamic power calculations and power table
in order to use Energy Model performance domain data. This model
should be easy to use and could find more users. It is also less
complicated to setup the needed structures.

Reviewed-by: Ionela Voinescu 
Signed-off-by: Lukasz Luba 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20201210143014.24685-5-lukasz.luba@arm.com

thermal: devfreq_cooling: add new registration functions with Energy Model

2020-12-11T13:10:44+00:00

The Energy Model (EM) framework supports devices such as Devfreq. Create
new registration function which automatically register EM for the thermal
devfreq_cooling devices. This patch prepares the code for coming changes
which are going to replace old power model with the new EM.

Reviewed-by: Ionela Voinescu 
Signed-off-by: Lukasz Luba 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20201210143014.24685-4-lukasz.luba@arm.com

thermal: devfreq_cooling: use a copy of device status

2020-12-11T13:10:44+00:00

Devfreq cooling needs to now the correct status of the device in order
to operate. Devfreq framework can change the device status in the
background. To mitigate issues make a copy of the status structure and use
it for internal calculations.

In addition this patch adds normalization function, which also makes sure
that whatever data comes from the device, the load will be in range from 1
to 1024.

Reviewed-by: Ionela Voinescu 
Signed-off-by: Lukasz Luba 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20201210143014.24685-3-lukasz.luba@arm.com

thermal: devfreq_cooling: change tracing function and arguments

2020-12-11T13:10:44+00:00

Prepare for deleting the static and dynamic power calculation and clean
the trace function. These two fields are going to be removed in the next
changes.

Reviewed-by: Ionela Voinescu 
Reviewed-by: Steven Rostedt (VMware)  # for tracing code
Signed-off-by: Lukasz Luba 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20201210143014.24685-2-lukasz.luba@arm.com

thermal: cooling: Remove unused variable *tz

2020-10-12T10:08:36+00:00

1. devfreq_cooling.c: The variable *tz is not used in
devfreq_cooling_get_requested_power(), devfreq_cooling_state2power()
and devfreq_cooling_power2state().

2. cpufreq_cooling.c: After 84fe2cab48590, the variable *tz is not used
anymore in cpufreq_get_requested_power(), cpufreq_state2power() and
cpufreq_power2state().

Remove the variable *tz.

Signed-off-by: zhuguangqing 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20200914071101.13575-1-zhuguangqing83@gmail.com