linux.git/drivers/usb/image, branch v6.12.80

usb: image: mdc800: kill download URB on timeout

2026-03-25T10:08:32+00:00

commit 1be3b77de4eb89af8ae2fd6610546be778e25589 upstream.

mdc800_device_read() submits download_urb and waits for completion.
If the timeout fires and the device has not responded, the function
returns without killing the URB, leaving it active.

A subsequent read() resubmits the same URB while it is still
in-flight, triggering the WARN in usb_submit_urb():

  "URB submitted while active"

Check the return value of wait_event_timeout() and kill the URB if
it indicates timeout, ensuring the URB is complete before its status
is inspected or the URB is resubmitted.

Similar to
- commit 372c93131998 ("USB: yurex: fix control-URB timeout handling")
- commit b98d5000c505 ("media: rc: iguanair: handle timeouts")

Signed-off-by: Ziyi Guo 
Cc: stable 
Link: https://patch.msgid.link/20260209151937.2247202-1-n7l8m4@u.northwestern.edu
Signed-off-by: Greg Kroah-Hartman

usb: mdc800: handle signal and read racing

2026-03-25T10:08:32+00:00

commit 2d6d260e9a3576256fe9ef6d1f7930c9ec348723 upstream.

If a signal arrives after a read has partially completed,
we need to return the number of bytes read. -EINTR is correct
only if that number is zero.

Signed-off-by: Oliver Neukum 
Cc: stable 
Link: https://patch.msgid.link/20260209142048.1503791-1-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman

scsi: core: Add a dma_alignment field to the host and host template

2024-04-12T01:37:48+00:00

Get drivers out of the business of having to call the block layer DMA
alignment limits helpers themselves.

Signed-off-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20240409143748.980206-8-hch@lst.de
Reviewed-by: Bart Van Assche 
Reviewed-by: John Garry 
Reviewed-by: Damien Le Moal 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Martin K. Petersen

usb: image: mdc800: Remove redundant assignment to variable retval

2024-02-17T16:01:13+00:00

The variable retval is being assigned a value that is not being read
and is being re-assigned a new value a couple of statements later.
The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/usb/image/mdc800.c:634:2: warning: Value stored to 'retval'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20240207113730.2444296-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman

scsi: usb: uas: Declare two host templates and host template pointers const

2023-03-24T23:20:00+00:00

Improve source code documentation by constifying host templates that are
not modified.

Acked-by: Alan Stern  (for usb-storage)
Acked-by: Oliver Neukum 
Acked-by: Greg Kroah-Hartman 
Cc: Oliver Neukum 
Cc: linux-usb@vger.kernel.org
Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-81-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

usb/image: fix repeated words in comments

2022-07-27T12:33:53+00:00

 Delete the redundant word 'the'.

Signed-off-by: Jilin Yuan 
Link: https://lore.kernel.org/r/20220716133825.43161-1-yuanjilin@cdjrlc.com
Signed-off-by: Greg Kroah-Hartman

scsi: Remove drivers/scsi/scsi.h

2022-02-23T02:11:02+00:00

The following two header files have the same file name: include/scsi/scsi.h
and drivers/scsi/scsi.h. This is confusing. Remove the latter since the
following note was added in drivers/scsi/scsi.h in 2004:

"NOTE: this file only contains compatibility glue for old drivers. All
these wrappers will be removed sooner or later. For new code please use
the interfaces declared in the headers in include/scsi/"

Link: https://lore.kernel.org/r/20220218195117.25689-7-bvanassche@acm.org
Cc: Christoph Hellwig 
Cc: Ming Lei 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Himanshu Madhani 
Reviewed-by: Johannes Thumshirn 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions

2021-10-17T01:32:16+00:00

The DEF_SCSI_QCMD() macro passes the addresses of the SCSI host lock and
also that of the scsi_done function to the queuecommand_lck() function
implementations. Remove the 'scsi_done' argument since its address is
now a constant and instead call 'scsi_done' directly from inside the
queuecommand_lck() functions.

Link: https://lore.kernel.org/r/20211007204618.2196847-14-bvanassche@acm.org
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

USB: microtek: use set_host_byte()

2020-09-16T10:42:10+00:00

The SCSI layer is providing a new macro. Let's use it.

Signed-off-by: Oliver Neukum 
Link: https://lore.kernel.org/r/20200916100302.30855-1-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman

usb: Use fallthrough pseudo-keyword

2020-07-10T06:55:17+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva 
Link: https://lore.kernel.org/r/20200707195607.GA4198@embeddedor
Signed-off-by: Greg Kroah-Hartman