linux.git/fs/btrfs/ordered-data.c, branch v6.1.2

btrfs: add btrfs_try_lock_ordered_range

2022-09-29T15:08:28+00:00

For IOCB_NOWAIT we're going to want to use try lock on the extent lock,
and simply bail if there's an ordered extent in the range because the
only choice there is to wait for the ordered extent to complete.

Reviewed-by: Filipe Manana 
Signed-off-by: Josef Bacik 
Signed-off-by: Stefan Roesch 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: unify the lock/unlock extent variants

2022-09-26T10:28:05+00:00

We have two variants of lock/unlock extent, one set that takes a cached
state, another that does not.  This is slightly annoying, and generally
speaking there are only a few places where we don't have a cached state.
Simplify this by making lock_extent/unlock_extent the only variant and
make it take a cached state, then convert all the callers appropriately.

Signed-off-by: Josef Bacik 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: add lockdep annotations for the ordered extents wait event

2022-09-26T10:27:53+00:00

This wait event is very similar to the pending ordered wait event in the
sense that it occurs in a different context than the condition signaling
for the event. The signaling occurs in btrfs_remove_ordered_extent()
while the wait event is implemented in btrfs_start_ordered_extent() in
fs/btrfs/ordered-data.c

However, in this case a thread must not acquire the lockdep map for the
ordered extents wait event when the ordered extent is related to a free
space inode. That is because lockdep creates dependencies between locks
acquired both in execution paths related to normal inodes and paths
related to free space inodes, thus leading to false positives.

Reviewed-by: Josef Bacik 
Signed-off-by: Ioannis Angelakopoulos 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: add lockdep annotations for pending_ordered wait event

2022-09-26T10:27:53+00:00

In contrast to the num_writers and num_extwriters wait events, the
condition for the pending ordered wait event is signaled in a different
context from the wait event itself. The condition signaling occurs in
btrfs_remove_ordered_extent() in fs/btrfs/ordered-data.c while the wait
event is implemented in btrfs_commit_transaction() in
fs/btrfs/transaction.c

Thus the thread signaling the condition has to acquire the lockdep map
as a reader at the start of btrfs_remove_ordered_extent() and release it
after it has signaled the condition. In this case some dependencies
might be left out due to the placement of the annotation, but it is
better than no annotation at all.

Reviewed-by: Josef Bacik 
Signed-off-by: Ioannis Angelakopoulos 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: remove the finish_func argument to btrfs_mark_ordered_io_finished

2022-07-25T15:45:37+00:00

finish_func is always set to finish_ordered_fn, so remove it and also
the now pointless and somewhat confusingly named
__endio_write_update_ordered wrapper.

Reviewed-by: Nikolay Borisov 
Signed-off-by: Christoph Hellwig 
Signed-off-by: David Sterba

btrfs: add tracepoints for ordered extents

2022-07-25T15:45:34+00:00

When debugging a reference counting issue with ordered extents, I've found
we're lacking a lot of tracepoint coverage in the ordered extent code.

Close these gaps by adding tracepoints after every refcount_inc() in the
ordered extent code.

Reviewed-by: Boris Burkov 
Reviewed-by: Qu Wenruo 
Reviewed-by: Anand Jain 
Signed-off-by: Johannes Thumshirn 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: fix typos in comments

2022-07-25T15:44:33+00:00

Codespell has found a few typos.

Signed-off-by: David Sterba

btrfs: add BTRFS_IOC_ENCODED_WRITE

2022-03-14T12:13:51+00:00

The implementation resembles direct I/O: we have to flush any ordered
extents, invalidate the page cache, and do the io tree/delalloc/extent
map/ordered extent dance. From there, we can reuse the compression code
with a minor modification to distinguish the write from writeback. This
also creates inline extents when possible.

Signed-off-by: Omar Sandoval 
Signed-off-by: David Sterba

btrfs: add ram_bytes and offset to btrfs_ordered_extent

2022-03-14T12:13:51+00:00

Currently, we only create ordered extents when ram_bytes == num_bytes
and offset == 0. However, BTRFS_IOC_ENCODED_WRITE writes may create
extents which only refer to a subset of the full unencoded extent, so we
need to plumb these fields through the ordered extent infrastructure and
pass them down to insert_reserved_file_extent().

Since we're changing the btrfs_add_ordered_extent* signature, let's get
rid of the trivial wrappers and add a kernel-doc.

Reviewed-by: Nikolay Borisov 
Reviewed-by: Josef Bacik 
Signed-off-by: Omar Sandoval 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: zoned: fix double counting of split ordered extent

2021-09-07T12:30:41+00:00

btrfs_add_ordered_extent_*() add num_bytes to fs_info->ordered_bytes.
Then, splitting an ordered extent will call btrfs_add_ordered_extent_*()
again for split extents, leading to double counting of the region of
a split extent. These leaked bytes are finally reported at unmount time
as follow:

  BTRFS info (device dm-1): at unmount dio bytes count 364544

Fix the double counting by subtracting split extent's size from
fs_info->ordered_bytes.

Fixes: d22002fd37bd ("btrfs: zoned: split ordered extent when bio is sent")
CC: stable@vger.kernel.org # 5.12+
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Naohiro Aota 
Signed-off-by: David Sterba