linux.git/fs/ceph/acl.c, branch v4.8.10

posix_acl: Clear SGID bit when setting file permissions

2016-10-31T11:02:08+00:00

commit 073931017b49d9458aa351605b43a7e34598caef upstream.

When file permissions are modified via chmod(2) and the user is not in
the owning group or capable of CAP_FSETID, the setgid bit is cleared in
inode_change_ok().  Setting a POSIX ACL via setxattr(2) sets the file
permissions as well as the new ACL, but doesn't clear the setgid bit in
a similar way; this allows to bypass the check in chmod(2).  Fix that.

References: CVE-2016-7097
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Jan Kara 
Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Juerg Haefliger 
Signed-off-by: Greg Kroah-Hartman

ceph: Get rid of d_find_alias in ceph_set_acl

2016-04-23T19:41:30+00:00

Create a variant of ceph_setattr that takes an inode instead of a
dentry.  Change __ceph_setxattr (and also __ceph_removexattr) to take an
inode instead of a dentry.  Use those in ceph_set_acl so that we no
longer need a dentry there.

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: "Yan, Zheng" 
Signed-off-by: Al Viro

posix_acl: Inode acl caching fixes

2016-03-31T04:30:15+00:00

When get_acl() is called for an inode whose ACL is not cached yet, the
get_acl inode operation is called to fetch the ACL from the filesystem.
The inode operation is responsible for updating the cached acl with
set_cached_acl().  This is done without locking at the VFS level, so
another task can call set_cached_acl() or forget_cached_acl() before the
get_acl inode operation gets to calling set_cached_acl(), and then
get_acl's call to set_cached_acl() results in caching an outdate ACL.

Prevent this from happening by setting the cached ACL pointer to a
task-specific sentinel value before calling the get_acl inode operation.
Move the responsibility for updating the cached ACL from the get_acl
inode operations to get_acl().  There, only set the cached ACL if the
sentinel value hasn't changed.

The sentinel values are chosen to have odd values.  Likewise, the value
of ACL_NOT_CACHED is odd.  In contrast, ACL object pointers always have
an even value (ACLs are aligned in memory).  This allows to distinguish
uncached ACLs values from ACL objects.

In addition, switch from guarding inode->i_acl and inode->i_default_acl
upates by the inode->i_lock spinlock to using xchg() and cmpxchg().

Filesystems that do not want ACLs returned from their get_acl inode
operations to be cached must call forget_cached_acl() to prevent the VFS
from doing so.

(Patch written by Al Viro and Andreas Gruenbacher.)

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Al Viro

posix acls: Remove duplicate xattr name definitions

2015-12-07T02:25:17+00:00

Remove POSIX_ACL_XATTR_{ACCESS,DEFAULT} and GFS2_POSIX_ACL_{ACCESS,DEFAULT}
and replace them with the definitions in .

Signed-off-by: Andreas Gruenbacher 
Reviewed-by: James Morris 
Signed-off-by: Al Viro

ceph: switch some GFP_NOFS memory allocation to GFP_KERNEL

2015-06-25T08:49:31+00:00

GFP_NOFS memory allocation is required for page writeback path.
But there is no need to use GFP_NOFS in syscall path and readpage
path

Signed-off-by: Yan, Zheng

ceph: acl: Remove unused function

2015-02-19T10:31:38+00:00

Remove the function ceph_get_cached_acl() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist 
Reviewed-by: Yan, Zheng

ceph: include the initial ACL in create/mkdir/mknod MDS requests

2014-10-14T19:56:49+00:00

Current code set new file/directory's initial ACL in a non-atomic
manner.
Client first sends request to MDS to create new file/directory, then set
the initial ACL after the new file/directory is successfully created.

The fix is include the initial ACL in create/mkdir/mknod MDS requests.
So MDS can handle creating file/directory and setting the initial ACL in
one request.

Signed-off-by: Yan, Zheng 
Reviewed-by: Sage Weil

ceph: properly apply umask when ACL is enabled

2014-07-08T11:08:47+00:00

when ACL is enabled, posix_acl_create() may change inode's mode

Signed-off-by: Yan, Zheng

ceph: remove useless ACL check

2014-06-06T01:29:50+00:00

posix_acl_xattr_set() already does the check, and it's the only
way to feed in an ACL from userspace.
So the check here is useless, remove it.

Signed-off-by: zhang zhen 
Reviewed-by: Yan, Zheng

ceph: make ceph_forget_all_cached_acls() static inline

2014-02-17T20:37:12+00:00

Signed-off-by: Guangliang Zhao 
Reviewed-by: Alex Elder 
Signed-off-by: Sage Weil