linux.git/fs/ecryptfs/miscdev.c, branch v6.12.80

ecryptfs: miscdev: File headers are not good kernel-doc candidates

2021-04-19T04:42:13+00:00

Supply description for the 'daemon' param too.

Fixes the following W=1 kernel build warning(s):

 fs/ecryptfs/miscdev.c:19: warning: cannot understand function prototype: 'atomic_t ecryptfs_num_miscdev_opens; '
 fs/ecryptfs/miscdev.c:323: warning: Function parameter or member 'daemon' not described in 'ecryptfs_miscdev_response'

Cc: Tyler Hicks 
Cc: "Michael A. Halcrow" 
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Tyler Hicks

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333

2019-06-05T15:37:06+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation this program is
  distributed in the hope that it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details you should have received a copy of the gnu general
  public license along with this program if not write to the free
  software foundation inc 59 temple place suite 330 boston ma 02111
  1307 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 136 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Alexios Zavras 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190530000436.384967451@linutronix.de
Signed-off-by: Greg Kroah-Hartman

vfs: do bulk POLL* -> EPOLL* replacement

2018-02-11T22:34:03+00:00

This is the mindless scripted replacement of kernel use of POLL*
variables as described by Al, done by this script:

    for V in IN OUT PRI ERR RDNORM RDBAND WRNORM WRBAND HUP RDHUP NVAL MSG; do
        L=`git grep -l -w POLL$V | grep -v '^t' | grep -v /um/ | grep -v '^sa' | grep -v '/poll.h$'|grep -v '^D'`
        for f in $L; do sed -i "-es/^\([^\"]*\)\(\\)/\\1E\\2/" $f; done
    done

with de-mangling cleanups yet to come.

NOTE! On almost all architectures, the EPOLL* constants have the same
values as the POLL* constants do.  But they keyword here is "almost".
For various bad reasons they aren't the same, and epoll() doesn't
actually work quite correctly in some cases due to this on Sparc et al.

The next patch from Al will sort out the final differences, and we
should be all done.

Scripted-by: Al Viro 
Signed-off-by: Linus Torvalds

fs: annotate ->poll() instances

2017-11-27T21:20:05+00:00

Signed-off-by: Al Viro

ecryptfs: Delete 21 error messages for a failed memory allocation

2017-11-06T18:23:29+00:00

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Tyler Hicks

ecryptfs: add missing \n to end of various error messages

2017-11-04T22:16:39+00:00

Trival fix, some error messages are missing a \n, so add it.

Signed-off-by: Colin Ian King 
Signed-off-by: Tyler Hicks

ecryptfs: close rmmod race

2013-04-09T18:08:16+00:00

Signed-off-by: Al Viro

eCryptfs: Make all miscdev functions use daemon ptr in file private_data

2012-07-08T17:51:44+00:00

Now that a pointer to a valid struct ecryptfs_daemon is stored in the
private_data of an opened /dev/ecryptfs file, the remaining miscdev
functions can utilize the pointer rather than looking up the
ecryptfs_daemon at the beginning of each operation.

The security model of /dev/ecryptfs is simplified a little bit with this
patch. Upon opening /dev/ecryptfs, a per-user ecryptfs_daemon is
registered. Another daemon cannot be registered for that user until the
last file reference is released. During the lifetime of the
ecryptfs_daemon, access checks are not performed on the /dev/ecryptfs
operations because it is assumed that the application securely handles
the opened file descriptor and does not unintentionally leak it to
processes that are not trusted.

Signed-off-by: Tyler Hicks 
Cc: Sasha Levin

eCryptfs: Gracefully refuse miscdev file ops on inherited/passed files

2012-07-06T20:51:12+00:00

File operations on /dev/ecryptfs would BUG() when the operations were
performed by processes other than the process that originally opened the
file. This could happen with open files inherited after fork() or file
descriptors passed through IPC mechanisms. Rather than calling BUG(), an
error code can be safely returned in most situations.

In ecryptfs_miscdev_release(), eCryptfs still needs to handle the
release even if the last file reference is being held by a process that
didn't originally open the file. ecryptfs_find_daemon_by_euid() will not
be successful, so a pointer to the daemon is stored in the file's
private_data. The private_data pointer is initialized when the miscdev
file is opened and only used when the file is released.

https://launchpad.net/bugs/994247

Signed-off-by: Tyler Hicks 
Reported-by: Sasha Levin 
Tested-by: Sasha Levin

eCryptfs: Fix lockdep warning in miscdev operations

2012-07-03T23:34:10+00:00

Don't grab the daemon mutex while holding the message context mutex.
Addresses this lockdep warning:

 ecryptfsd/2141 is trying to acquire lock:
  (&ecryptfs_msg_ctx_arr[i].mux){+.+.+.}, at: [] ecryptfs_miscdev_read+0x143/0x470 [ecryptfs]

 but task is already holding lock:
  (&(*daemon)->mux){+.+...}, at: [] ecryptfs_miscdev_read+0x21c/0x470 [ecryptfs]

 which lock already depends on the new lock.

 the existing dependency chain (in reverse order) is:

 -> #1 (&(*daemon)->mux){+.+...}:
        [] lock_acquire+0x9d/0x220
        [] __mutex_lock_common+0x5a/0x4b0
        [] mutex_lock_nested+0x44/0x50
        [] ecryptfs_send_miscdev+0x97/0x120 [ecryptfs]
        [] ecryptfs_send_message+0x134/0x1e0 [ecryptfs]
        [] ecryptfs_generate_key_packet_set+0x2fe/0xa80 [ecryptfs]
        [] ecryptfs_write_metadata+0x108/0x250 [ecryptfs]
        [] ecryptfs_create+0x130/0x250 [ecryptfs]
        [] vfs_create+0xb4/0x120
        [] do_last+0x8c5/0xa10
        [] path_openat+0xd9/0x460
        [] do_filp_open+0x42/0xa0
        [] do_sys_open+0xf8/0x1d0
        [] sys_open+0x21/0x30
        [] system_call_fastpath+0x16/0x1b

 -> #0 (&ecryptfs_msg_ctx_arr[i].mux){+.+.+.}:
        [] __lock_acquire+0x1bf8/0x1c50
        [] lock_acquire+0x9d/0x220
        [] __mutex_lock_common+0x5a/0x4b0
        [] mutex_lock_nested+0x44/0x50
        [] ecryptfs_miscdev_read+0x143/0x470 [ecryptfs]
        [] vfs_read+0xb3/0x180
        [] sys_read+0x4d/0x90
        [] system_call_fastpath+0x16/0x1b

Signed-off-by: Tyler Hicks