linux.git/fs/f2fs/debug.c, branch v3.18.72

f2fs: set ->owner for debugfs status file's file_operations

2017-01-15T14:49:50+00:00

[ Upstream commit 05e6ea2685c964db1e675a24a4f4e2adc22d2388 ]

The struct file_operations instance serving the f2fs/status debugfs file
lacks an initialization of its ->owner.

This means that although that file might have been opened, the f2fs module
can still get removed. Any further operation on that opened file, releasing
included,  will cause accesses to unmapped memory.

Indeed, Mike Marshall reported the following:

  BUG: unable to handle kernel paging request at ffffffffa0307430
  IP: [] full_proxy_release+0x24/0x90
  <...>
  Call Trace:
   [] __fput+0xdf/0x1d0
   [] ____fput+0xe/0x10
   [] task_work_run+0x8e/0xc0
   [] do_exit+0x2ae/0xae0
   [] ? __audit_syscall_entry+0xae/0x100
   [] ? syscall_trace_enter+0x1ca/0x310
   [] do_group_exit+0x44/0xc0
   [] SyS_exit_group+0x14/0x20
   [] do_syscall_64+0x61/0x150
   [] entry_SYSCALL64_slow_path+0x25/0x25
  <...>
  ---[ end trace f22ae883fa3ea6b8 ]---
  Fixing recursive fault but reboot is needed!

Fix this by initializing the f2fs/status file_operations' ->owner with
THIS_MODULE.

This will allow debugfs to grab a reference to the f2fs module upon any
open on that file, thus preventing it from getting removed.

Fixes: 902829aa0b72 ("f2fs: move proc files to debugfs")
Reported-by: Mike Marshall 
Reported-by: Martin Brandenburg 
Cc: stable@vger.kernel.org
Signed-off-by: Nicolai Stange 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Sasha Levin

f2fs: check the use of macros on block counts and addresses

2014-09-30T22:34:47+00:00

This patch cleans up the existing and new macros for readability.

Rule is like this.

         ,-----------------------------------------> MAX_BLKADDR -,
         |  ,------------- TOTAL_BLKS ----------------------------,
         |  |                                                     |
         |  ,- seg0_blkaddr   ,----- sit/nat/ssa/main blkaddress  |
block    |  | (SEG0_BLKADDR)  | | | |   (e.g., MAIN_BLKADDR)      |
address  0..x................ a b c d .............................
            |                                                     |
global seg# 0...................... m .............................
            |                       |                             |
            |                       `------- MAIN_SEGS -----------'
            `-------------- TOTAL_SEGS ---------------------------'
                                    |                             |
 seg#                               0..........xx..................

= Note =
 o GET_SEGNO_FROM_SEG0 : blk address -> global segno
 o GET_SEGNO           : blk address -> segno
 o START_BLOCK         : segno -> starting block address

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix typo

2014-08-19T17:01:33+00:00

Fix typo and some grammatical errors.

The words "filesystem" and "readahead" are being used without the space treewide.

Signed-off-by: Park Ju Hyung 
Signed-off-by: Jaegeuk Kim

f2fs: add infra for ino management

2014-07-29T14:45:54+00:00

This patch changes the naming of orphan-related data structures to use as
inode numbers managed globally.
Later, we can use this facility for managing any inode number lists.

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: cleanup the needless return of f2fs_create_root_stats

2014-07-11T22:01:47+00:00

Signed-off-by: Gu Zheng 
Signed-off-by: Jaegeuk Kim

f2fs: remove unnecessary threshold

2014-03-20T13:10:09+00:00

The NM_WOUT_THRESHOLD is now obsolete since f2fs starts to control on a basis
of the memory footprint.

Signed-off-by: Jaegeuk Kim

f2fs: implement a lock-free stat_show

2014-02-24T07:00:41+00:00

The stat_show is just to show the current status of f2fs.
So, we can remove all the there-in locks.

Signed-off-by: Jaegeuk Kim

f2fs: show counts of checkpoint in status

2014-02-17T05:58:53+00:00

This patch shows the counts of checkpoint in f2fs' status.

Signed-off-by: Changman Lee 
Signed-off-by: Jaegeuk Kim

f2fs: introduce NODE_MAPPING for code consistency

2014-01-22T09:41:08+00:00

This patch adds NODE_MAPPING which is similar as META_MAPPING introduced by
Gu Zheng.

Cc: Gu Zheng 
Signed-off-by: Jaegeuk Kim

f2fs: add help function META_MAPPING

2014-01-22T09:41:07+00:00

Introduce help function META_MAPPING() to get the cache meta blocks'
address space.

Signed-off-by: Gu Zheng 
Signed-off-by: Jaegeuk Kim