linux.git/fs/splice.c, branch v2.6.26-rc7

splice: handle try_to_release_page() failure

2008-05-28T12:49:27+00:00

splice currently assumes that try_to_release_page() always suceeds,
but it can return failure. If it does, we cannot steal the page.

Acked-by: Mingming Cao

splice: fix sendfile() issue with relay

2008-05-28T12:49:27+00:00

Splice isn't always incrementing the ppos correctly, which broke
relay splice.

Signed-off-by: Tom Zanussi 
Tested-by: Dan Williams 
Signed-off-by: Jens Axboe

Revert "relay: fix splice problem"

2008-05-08T12:06:19+00:00

This reverts commit c3270e577c18b3d0e984c3371493205a4807db9d.

vfs: splice remove_suid() cleanup

2008-05-07T07:29:00+00:00

generic_file_splice_write() duplicates remove_suid() just because it
doesn't hold i_mutex.  But it grabs i_mutex inside splice_from_pipe()
anyway, so this is rather pointless.

Move locking to generic_file_splice_write() and call remove_suid() and
__splice_from_pipe() instead.

Signed-off-by: Miklos Szeredi 
Signed-off-by: Jens Axboe

relay: fix splice problem

2008-04-29T07:48:15+00:00

Splice isn't always incrementing the ppos correctly, which broke
relay splice.

Signed-off-by: Tom Zanussi 
Signed-off-by: Jens Axboe

splice: fix infinite loop in generic_file_splice_read()

2008-04-10T06:24:25+00:00

There's a quirky loop in generic_file_splice_read() that could go
on indefinitely, if the file splice returns 0 permanently (and not
just as a temporary condition). Get rid of the loop and pass
back -EAGAIN correctly from __generic_file_splice_read(), so we
handle that condition properly as well.

Signed-off-by: Jens Axboe

splice: use mapping_gfp_mask

2008-04-03T22:39:49+00:00

The loop block driver is careful to mask __GFP_IO|__GFP_FS out of its
mapping_gfp_mask, to avoid hangs under memory pressure.  But nowadays
it uses splice, usually going through __generic_file_splice_read.  That
must use mapping_gfp_mask instead of GFP_KERNEL to avoid those hangs.

Signed-off-by: Hugh Dickins 
Cc: Jens Axboe 
Cc: Andrew Morton 
Signed-off-by: Linus Torvalds

splice: only return -EAGAIN if there's hope of more data

2008-03-04T10:14:39+00:00

sys_tee() currently is a bit eager in returning -EAGAIN, it may do so
even if we don't have a chance of anymore data becoming available. So
improve the logic and only return -EAGAIN if we have an attached writer
to the input pipe.

Reported by Johann Felix Soden  and
Patrick McManus .

Tested-by: Johann Felix Soden 
Signed-off-by: Jens Axboe

splice: fix user pointer access in get_iovec_page_array()

2008-02-10T18:27:21+00:00

Commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user
pointer access verification") added the proper access_ok() calls to
copy_from_user_mmap_sem() which ensures we can copy the struct iovecs
from userspace to the kernel.

But we also must check whether we can access the actual memory region
pointed to by the struct iovec to fix the access checks properly.

Signed-off-by: Bastian Blank 
Acked-by: Oliver Pinter 
Cc: Jens Axboe 
Cc: Andrew Morton 
Signed-off-by: Pekka Enberg 
Signed-off-by: Linus Torvalds

splice: missing user pointer access verification

2008-02-08T17:25:01+00:00

vmsplice_to_user() must always check the user pointer and length
with access_ok() before copying. Likewise, for the slow path of
copy_from_user_mmap_sem() we need to check that we may read from
the user region.

Signed-off-by: Jens Axboe 
Cc: Wojciech Purczynski 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Linus Torvalds