linux.git/fs/xfs/xfs_icreate_item.c, branch v6.18.8

xfs: don't use a xfs_log_iovec for ri_buf in log recovery

2025-07-24T15:30:15+00:00

ri_buf just holds a pointer/len pair and is not a log iovec used for
writing to the log.  Switch to use a kvec instead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Carlos Maiolino 
Signed-off-by: Carlos Maiolino

xfs: convert kmem_free() for kvmalloc users to kvfree()

2024-02-13T12:37:34+00:00

Start getting rid of kmem_free() by converting all the cases where
memory can come from vmalloc interfaces to calling kvfree()
directly.

Signed-off-by: Dave Chinner 
Reviewed-by: "Darrick J. Wong" 
Signed-off-by: Chandan Babu R

xfs: fix potential log item leak

2022-05-04T01:45:11+00:00

Ever since we added shadown format buffers to the log items, log
items need to handle the item being released with shadow buffers
attached. Due to the fact this requirement was added at the same
time we added new rmap/reflink intents, we missed the cleanup of
those items.

In theory, this means shadow buffers can be leaked in a very small
window when a shutdown is initiated. Testing with KASAN shows this
leak does not happen in practice - we haven't identified a single
leak in several years of shutdown testing since ~v4.8 kernels.

However, the intent whiteout cleanup mechanism results in every
cancelled intent in exactly the same state as this tiny race window
creates and so if intents down clean up shadow buffers on final
release we will leak the shadow buffer for just about every intent
we create.

Hence we start with this patch to close this condition off and
ensure that when whiteouts start to be used we don't leak lots of
memory.

Signed-off-by: Dave Chinner 
Reviewed-by: Darrick J. Wong 
Reviewed-by: Allison Henderson 
Signed-off-by: Dave Chinner

xfs: rename _zone variables to _cache

2021-10-22T23:04:20+00:00

Now that we've gotten rid of the kmem_zone_t typedef, rename the
variables to _cache since that's what they are.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Chandan Babu R

xfs: remove kmem_zone typedef

2021-10-22T23:00:31+00:00

Remove these typedefs by referencing kmem_cache directly.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Chandan Babu R

xfs: cleanup FUNCTION usage

2021-08-11T16:13:12+00:00

__FUNCTION__ exists only for backwards compatibility reasons
with old gcc versions. Replace it with __func__.

Signed-off-by: Dwaipayan Ray 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Darrick J. Wong

xfs: Remove kmem_zone_zalloc() usage

2020-07-29T03:24:14+00:00

Use kmem_cache_zalloc() directly.

With the exception of xlog_ticket_alloc() which will be dealt on the
next patch for readability.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Darrick J. Wong 
Reviewed-by: Dave Chinner

xfs: refactor log recovery icreate item dispatch for pass2 commit functions

2020-05-08T15:49:59+00:00

Move the log icreate item pass2 commit code into the per-item source code
files and use the dispatch function to call it.  We do these one at a
time because there's a lot of code to move.  No functional changes.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Chandan Babu R 
Reviewed-by: Christoph Hellwig

xfs: refactor log recovery item sorting into a generic dispatch structure

2020-05-08T15:49:58+00:00

Create a generic dispatch structure to delegate recovery of different
log item types into various code modules.  This will enable us to move
code specific to a particular log item type out of xfs_log_recover.c and
into the log item source.

The first operation we virtualize is the log item sorting.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Chandan Babu R 
Reviewed-by: Christoph Hellwig

xfs: Remove kmem_zone_free() wrapper

2019-11-18T16:40:44+00:00

We can remove it now, without needing to rework the KM_ flags.

Use kmem_cache_free() directly.

Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino 
Signed-off-by: Darrick J. Wong