linux.git/include/linux/bsg-lib.h, branch v6.6.132

scsi: core: Remove

2022-03-02T03:21:50+00:00

This header is empty now except for an include of , so
remove it.

Link: https://lore.kernel.org/r/20220224175552.988286-9-hch@lst.de
Reviewed-by: Bart Van Assche 
Reviewed-by: John Garry 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: bsg: Simplify device registration

2021-07-31T02:22:36+00:00

Use the per-device cdev_device_interface to store the bsg data in the char
device inode, and thus remove the need to embedd the bsg_class_device
structure in the request_queue.

Link: https://lore.kernel.org/r/20210729064845.1044147-2-hch@lst.de
Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

block: switch all files cleared marked as GPLv2 or later to SPDX tags

2019-04-30T22:11:59+00:00

All these files have some form of the usual GPLv2 or later boilerplate.
Switch them to use SPDX tags instead.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

scsi: bsg-lib: handle bidi requests without block layer help

2019-02-06T02:27:40+00:00

We can just stash away the second request in struct bsg_job instead of
using the block layer req->next_rq field, allowing for the eventual removal
of the latter.

Signed-off-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Signed-off-by: Martin K. Petersen

bsg: move bsg-lib parts outside of request queue

2018-11-07T20:42:33+00:00

Get rid of the special bsg job fn and timeout handler, move them
into a private bsg_set instead.

Mostly from Christoph, with fixes for error handling and cleanups.

Reviewed-by: Hannes Reinecke 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: provide bsg_remove_queue() helper

2018-11-07T20:42:32+00:00

All drivers do unregister + cleanup, provide a helper for that.

Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: pass in desired timeout handler

2018-11-07T20:42:32+00:00

This will ease in the conversion to blk-mq, where we can't set
a timeout handler after queue init.

Cc: Johannes Thumshirn 
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

block: remove parent device reference from struct bsg_class_device

2018-05-29T19:00:25+00:00

Bsg holding a reference to the parent device may result in a crash if a
bsg file handle is closed after the parent device driver has unloaded.

Holding a reference is not really needed: the parent device must exist
between bsg_register_queue and bsg_unregister_queue.  Before the device
goes away the caller does blk_cleanup_queue so that all in-flight
requests to the device are gone and all new requests cannot pass beyond
the queue.  The queue itself is a refcounted object and it will stay
alive with a bsg file.

Based on analysis, previous patch and changelog from Anatoliy Glagolev.

Reported-by: Anatoliy Glagolev 
Reviewed-by: James E.J. Bottomley 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

bsg: split handling of SCSI CDBs vs transport requeues

2018-03-13T17:40:24+00:00

The current BSG design tries to shoe-horn the transport-specific
passthrough commands into the overall framework for SCSI passthrough
requests.  This has a couple problems:

 - each passthrough queue has to set the QUEUE_FLAG_SCSI_PASSTHROUGH flag
   despite not dealing with SCSI commands at all.  Because of that these
   queues could also incorrectly accept SCSI commands from in-kernel
   users or through the legacy SCSI_IOCTL_SEND_COMMAND ioctl.
 - the real SCSI bsg queues also incorrectly accept bsg requests of the
   BSG_SUB_PROTOCOL_SCSI_TRANSPORT type
 - the bsg transport code is almost unredable because it tries to reuse
   different SCSI concepts for its own purpose.

This patch instead adds a new bsg_ops structure to handle the two cases
differently, and thus solves all of the above problems.  Another side
effect is that the bsg-lib queues also don't need to embedd a
struct scsi_request anymore.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Jens Axboe

bsg-lib: remove bsg_job.req

2018-03-13T17:40:23+00:00

Users of the bsg-lib interface should only use the bsg_job data structure
and not know about implementation details of it.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Benjamin Block 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Jens Axboe