linux.git/include/rdma, branch v4.16.13

IB/umem: Use the correct mm during ib_umem_release

2018-05-30T06:17:17+00:00

commit 8e907ed4882714fd13cfe670681fc6cb5284c780 upstream.

User-space may invoke ibv_reg_mr and ibv_dereg_mr in different threads.

If ibv_dereg_mr is called after the thread which invoked ibv_reg_mr has
exited, get_pid_task will return NULL and ib_umem_release will not
decrease mm->pinned_vm.

Instead of using threads to locate the mm, use the overall tgid from the
ib_ucontext struct instead. This matches the behavior of ODP and
disassociate in handling the mm of the process that called ibv_reg_mr.

Cc: 
Fixes: 87773dd56d54 ("IB: ib_umem_release() should decrement mm->pinned_vm from ib_umem_get")
Signed-off-by: Lidong Chen 
Signed-off-by: Jason Gunthorpe 
Signed-off-by: Greg Kroah-Hartman

RDMA/ucma: Introduce safer rdma_addr_size() variants

2018-03-28T22:13:36+00:00

There are several places in the ucma ABI where userspace can pass in a
sockaddr but set the address family to AF_IB.  When that happens,
rdma_addr_size() will return a size bigger than sizeof struct sockaddr_in6,
and the ucma kernel code might end up copying past the end of a buffer
not sized for a struct sockaddr_ib.

Fix this by introducing new variants

    int rdma_addr_size_in6(struct sockaddr_in6 *addr);
    int rdma_addr_size_kss(struct __kernel_sockaddr_storage *addr);

that are type-safe for the types used in the ucma ABI and return 0 if the
size computed is bigger than the size of the type passed in.  We can use
these new variants to check what size userspace has passed in before
copying any addresses.

Reported-by: 
Signed-off-by: Roland Dreier 
Signed-off-by: Jason Gunthorpe

RDMA/verbs: Remove restrack entry from XRCD structure

2018-03-19T20:10:30+00:00

XRCD object is not implemented in the restrack, so lets remove it.

Fixes: 02d8883f520e ("RDMA/restrack: Add general infrastructure to track RDMA resources")
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/uverbs: Use u64_to_user_ptr() not a union

2018-02-15T21:59:45+00:00

The union approach will get the endianness wrong sometimes if the kernel's
pointer size is 32 bits resulting in EFAULTs when trying to copy to/from
user.

Signed-off-by: Leon Romanovsky 
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Jason Gunthorpe

IB/uverbs: Always use the attribute size provided by the user

2018-02-15T21:59:44+00:00

This fixes several bugs around the copy_to/from user path:
 - copy_to used the user provided size of the attribute
   and could copy data beyond the end of the kernel buffer into
   userspace.
 - copy_from didn't know the size of the kernel buffer and
   could have left kernel memory unexpectedly un-initialized.
 - copy_from did not use the user length to determine if the
   attribute data is inlined or not.

Signed-off-by: Matan Barak 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

RDMA/restrack: Remove unimplemented XRCD object

2018-02-15T21:59:44+00:00

Resource tracking of XRCD objects is not implemented in current
version of restrack and hence can be removed.

Fixes: 02d8883f520e ("RDMA/restrack: Add general infrastructure to track RDMA resources")
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/core: Map iWarp AH type to undefined in rdma_ah_find_type

2018-02-01T22:43:31+00:00

iWarp devices do not support the creation of address handles
so return AH_ATTR_TYPE_UNDEFINED for all iWarp devices.

While we are here reduce the size of port_num to u8 and add
a comment.

Fixes: 44c58487d51a ("IB/core: Define 'ib' and 'roce' rdma_ah_attr types")
Reported-by: Parav Pandit 
CC: Sean Hefty 
Reviewed-by: Ira Weiny 
Reviewed-by: Shiraz Saleem 
Signed-off-by: Don Hiatt 
Signed-off-by: Dennis Dalessandro 
Signed-off-by: Jason Gunthorpe

IB/hfi1: Remove unnecessary fecn and becn fields

2018-02-01T22:43:29+00:00

packet->fecn and packet->becn are calculated in the hot path
and are never used. Remove these fields as they show to be
costly in a profile. Also, remove initialization for
becn and fecn in process_ecn() as they're unconditionally
assigned in the function and ensure fecn and becn variables
use a boolean type.

Reviewed-by: Mike Marciniszyn 
Signed-off-by: Sebastian Sanchez 
Signed-off-by: Dennis Dalessandro 
Signed-off-by: Jason Gunthorpe

IB/hfi1: Optimize packet type comparison using 9B and bypass code paths

2018-02-01T22:43:28+00:00

The packet type comparison used to find out if a packet is a bypass
packet in the hot path is an expensive operation as seen in a profile.

Determine packet's pkey and migration bit through the bypass and 9B
code paths instead.

Reviewed-by: Don Hiatt 
Reviewed-by: Mike Marciniszyn 
Signed-off-by: Sebastian Sanchez 
Signed-off-by: Dennis Dalessandro 
Signed-off-by: Jason Gunthorpe

IB/hfi1: Compute BTH only for RDMA_WRITE_LAST/SEND_LAST packet

2018-02-01T22:43:28+00:00

In hfi1_rc_rcv(), BTH is computed for all packets received.
However, it's only used for packets received with opcodes
RDMA_WRITE_LAST and SEND_LAST, and it is a costly operation.

Compute BTH only in the RDMA_WRITE_LAST/SEND_LAST code path
and let the compiler handle endianness conversion for bitwise
operations.

Reviewed-by: Mike Marciniszyn 
Signed-off-by: Sebastian Sanchez 
Signed-off-by: Dennis Dalessandro 
Signed-off-by: Jason Gunthorpe