linux.git/include/target/iscsi, branch v6.12.80

scsi: target: iscsi: Remove the unused netif_timeout attribute

2023-07-11T16:33:32+00:00

This attribute has never been used, remove it.

Signed-off-by: Maurizio Lombardi 
Link: https://lore.kernel.org/r/20230630155309.46061-1-mlombard@redhat.com
Reviewed-by: Mike Christie 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Remove unused transport_timer

2023-05-22T20:29:39+00:00

Signed-off-by: Maurizio Lombardi 
Link: https://lore.kernel.org/r/20230508162219.1731964-3-mlombard@redhat.com
Reviewed-by: Mike Christie 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Fix hang in the iSCSI login code

2023-05-22T20:29:39+00:00

If the initiator suddenly stops sending data during a login while keeping
the TCP connection open, the login_work won't be scheduled and will never
release the login semaphore; concurrent login operations will therefore get
stuck and fail.

The bug is due to the inability of the login timeout code to properly
handle this particular case.

Fix the problem by replacing the old per-NP login timer with a new
per-connection timer.

The timer is started when an initiator connects to the target; if it
expires, it sends a SIGINT signal to the thread pointed at by the
conn->login_kworker pointer.

conn->login_kworker is set by calling the iscsit_set_login_timer_kworker()
helper, initially it will point to the np thread; When the login
operation's control is in the process of being passed from the NP-thread to
login_work, the conn->login_worker pointer is set to NULL.  Finally,
login_kworker will be changed to point to the worker thread executing the
login_work job.

If conn->login_kworker is NULL when the timer expires, it means that the
login operation hasn't been completed yet but login_work isn't running, in
this case the timer will mark the login process as failed and will schedule
login_work so the latter will be forced to free the resources it holds.

Signed-off-by: Maurizio Lombardi 
Link: https://lore.kernel.org/r/20230508162219.1731964-2-mlombard@redhat.com
Reviewed-by: Mike Christie 
Signed-off-by: Martin K. Petersen

scsi: target: Move sess cmd counter to new struct

2023-03-24T21:32:22+00:00

iSCSI needs to wait on outstanding commands like how SRP and the FC/FCoE
drivers do. It can't use target_stop_session() because for MCS support we
can't stop the entire session during recovery because if other connections
are OK then we want to be able to continue to execute I/O on them.

Move the per session cmd counters to a new struct so iSCSI can allocate
them per connection. The xcopy code can also just not allocate in the
future since it doesn't need to track commands.

Signed-off-by: Mike Christie 
Link: https://lore.kernel.org/r/20230319015620.96006-2-michael.christie@oracle.com
Reviewed-by: Maurizio Lombardi 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Control authentication per ACL

2022-06-08T01:55:11+00:00

Add acls/{ACL}/attrib/authentication attribute that controls authentication
for particular ACL. By default, this attribute inherits a value of the
authentication attribute of the target port group to keep backward
compatibility.

Authentication attribute has 3 states:

 "0" - authentication is turned off for this ACL

 "1" - authentication is required for this ACL

 "-1" - authentication is inherited from TPG

Link: https://lore.kernel.org/r/20220523095905.26070-4-d.bogdanov@yadro.com
Reviewed-by: Roman Bolshakov 
Reviewed-by: Konstantin Shelekhin 
Reviewed-by: Mike Christie 
Signed-off-by: Dmitry Bogdanov 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Add upcast helpers

2022-06-08T01:55:11+00:00

iSCSI target is cluttered with open-coded container_of() conversions from
se_nacl to iscsi_node_acl. The code could be cleaned by introducing a
helper - to_iscsi_nacl() (similar to other helpers in target core).

While at it, make another iSCSI conversion helper consistent and rename
iscsi_tpg() helper to to_iscsi_tpg().

Link: https://lore.kernel.org/r/20220523095905.26070-2-d.bogdanov@yadro.com
Reviewed-by: Roman Bolshakov 
Reviewed-by: Konstantin Shelekhin 
Reviewed-by: Mike Christie 
Reviewed-by: Lee Duncan 
Signed-off-by: Dmitry Bogdanov 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Rename iscsi_session to iscsit_session

2022-05-11T02:32:21+00:00

The structure iscsi_session naming is used by the iSCSI initiator
driver. Rename the target session to iscsit_session to have more readable
code.

Link: https://lore.kernel.org/r/20220428092939.36768-3-mgurtovoy@nvidia.com
Reviewed-by: Mike Christie 
Signed-off-by: Max Gurtovoy 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Rename iscsi_conn to iscsit_conn

2022-05-11T02:32:20+00:00

The structure iscsi_conn naming is used by the iSCSI initiator
driver. Rename the target conn to iscsit_conn to have more readable code.

Link: https://lore.kernel.org/r/20220428092939.36768-2-mgurtovoy@nvidia.com
Reviewed-by: Mike Christie 
Signed-off-by: Max Gurtovoy 
Signed-off-by: Martin K. Petersen

scsi: target: iscsi: Rename iscsi_cmd to iscsit_cmd

2022-05-11T02:32:20+00:00

The structure iscsi_cmd naming is used by the iSCSI initiator driver.
Rename the target cmd to iscsit_cmd to have more readable code.

Link: https://lore.kernel.org/r/20220428092939.36768-1-mgurtovoy@nvidia.com
Reviewed-by: Mike Christie 
Signed-off-by: Max Gurtovoy 
Signed-off-by: Martin K. Petersen

scsi: target: Add iscsi/cpus_allowed_list in configfs

2022-03-15T03:40:36+00:00

The RX/TX threads for iSCSI connection can be scheduled to any online CPUs,
and will not be rescheduled.

When binding other heavy load threads along with iSCSI connection RX/TX
thread to the same CPU, the iSCSI performance will be worse.

Add iscsi/cpus_allowed_list in configfs. The available CPU set of iSCSI
connection RX/TX threads is allowed_cpus & online_cpus. If it is modified,
all RX/TX threads will be rescheduled.

Link: https://lore.kernel.org/r/20220301075500.14266-1-mingzhe.zou@easystack.cn
Reviewed-by: Mike Christie 
Signed-off-by: Mingzhe Zou 
Signed-off-by: Martin K. Petersen