linux.git/kernel/cgroup.c, branch v2.6.27-rc4

cgroup: uninline cgroup_has_css_refs()

2008-07-30T16:41:44+00:00

It's not small enough, and has 2 call sites.

 text    data     bss     dec     hex filename
12813    1676    4832   19321    4b79 cgroup.o.orig
12775    1676    4832   19283    4b53 cgroup.o

Signed-off-by: Li Zefan 
Cc: Paul Menage 
Cc: Cedric Le Goater 
Cc: Balbir Singh 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroup: remove duplicate code in allocate_cg_link()

2008-07-30T16:41:44+00:00

- just call free_cg_links() in allocate_cg_links()
- the list will get initialized in allocate_cg_links(), so don't init
  it twice

Signed-off-by: Li Zefan 
Cc: Paul Menage 
Cc: Cedric Le Goater 
Cc: Balbir Singh 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroup: fix possible memory leak

2008-07-30T16:41:44+00:00

There's a leak if copy_from_user() returns failure.

Signed-off-by: Li Zefan 
Cc: Paul Menage 
Cc: Cedric Le Goater 
Cc: Balbir Singh 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] get rid of indirect users of namei.h

2008-07-27T00:53:42+00:00

fs.h needs path.h, not namei.h; nfs_fs.h doesn't need it at all.
Several places in the tree needed direct include.

Signed-off-by: Al Viro

make cgroup_seqfile_release() static

2008-07-26T19:00:11+00:00

cgroup_seqfile_release() can become static.

Signed-off-by: Adrian Bunk 
Acked-by: Paul Menage 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroup_clone: use pid of newly created task for new cgroup

2008-07-25T17:53:37+00:00

cgroup_clone creates a new cgroup with the pid of the task.  This works
correctly for unshare, but for clone cgroup_clone is called from
copy_namespaces inside copy_process, which happens before the new pid is
created.  As a result, the new cgroup was created with current's pid.
This patch:

	1. Moves the call inside copy_process to after the new pid
	   is created
	2. Passes the struct pid into ns_cgroup_clone (as it is not
	   yet attached to the task)
	3. Passes a name from ns_cgroup_clone() into cgroup_clone()
	   so as to keep cgroup_clone() itself simpler
	4. Uses pid_vnr() to get the process id value, so that the
	   pid used to name the new cgroup is always the pid as it
	   would be known to the task which did the cloning or
	   unsharing.  I think that is the most intuitive thing to
	   do.  This way, task t1 does clone(CLONE_NEWPID) to get
	   t2, which does clone(CLONE_NEWPID) to get t3, then the
	   cgroup for t3 will be named for the pid by which t2 knows
	   t3.

(Thanks to Dan Smith for finding the main bug)

Changelog:
	June 11: Incorporate Paul Menage's feedback:  don't pass
	         NULL to ns_cgroup_clone from unshare, and reduce
		 patch size by using 'nodename' in cgroup_clone.
	June 10: Original version

[akpm@linux-foundation.org: build fix]
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Serge Hallyn 
Acked-by: Paul Menage 
Tested-by: Dan Smith 
Cc: Balbir Singh 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroup files: turn attach_task_by_pid directly into a cgroup write handler

2008-07-25T17:53:36+00:00

This patch changes attach_task_by_pid() to take a u64 rather than a
string; as a result it can be called directly as a control groups
write_u64 handler, and cgroup_common_file_write() can be removed.

Signed-off-by: Paul Menage 
Cc: Paul Jackson 
Cc: Pavel Emelyanov 
Cc: Balbir Singh 
Cc: Serge Hallyn 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroup files: move notify_on_release file to separate write handler

2008-07-25T17:53:36+00:00

This patch moves the write handler for the cgroups notify_on_release
file into a separate handler. This handler requires no cgroups locking
since it relies on atomic bitops for synchronization.

Signed-off-by: Paul Menage 
Cc: Paul Jackson 
Cc: Pavel Emelyanov 
Cc: Balbir Singh 
Cc: Serge Hallyn 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroups: misc cleanups to write_string patchset

2008-07-25T17:53:35+00:00

This patch contains cleanups suggested by reviewers for the recent
write_string() patchset:

- pair cgroup_lock_live_group() with cgroup_unlock() in cgroup.c for
  clarity, rather than directly unlocking cgroup_mutex.

- make the return type of cgroup_lock_live_group() a bool

- use a #define'd constant for the local buffer size in read/write functions

Signed-off-by: Paul Menage 
Cc: Paul Jackson 
Cc: Pavel Emelyanov 
Cc: Balbir Singh 
Acked-by: Serge Hallyn 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cgroup files: move the release_agent file to use typed handlers

2008-07-25T17:53:35+00:00

Adds cgroup_release_agent_write() and cgroup_release_agent_show()
methods to handle writing/reading the path to a cgroup hierarchy's
release agent. As a result, cgroup_common_file_read() is now unnecessary.

As part of the change, a previously-tolerated race in
cgroup_release_agent() is avoided by copying the current
release_agent_path prior to calling call_usermode_helper().

Signed-off-by: Paul Menage 
Cc: Paul Jackson 
Cc: Pavel Emelyanov 
Cc: Balbir Singh 
Acked-by: Serge Hallyn 
Cc: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds