linux.git/kernel/irq/devres.c, branch v6.18.21

genirq/devres: Add error handling in devm_request_*_irq()

2025-08-24T11:00:45+00:00

devm_request_threaded_irq() and devm_request_any_context_irq() currently
don't print any error message when interrupt registration fails.

This forces each driver to implement redundant error logging - over 2,000
lines of error messages exist across drivers. Additionally, when
upper-layer functions propagate these errors without logging, critical
debugging information is lost.

Add devm_request_result() helper to unify error reporting via dev_err_probe(),

Use it in devm_request_threaded_irq() and devm_request_any_context_irq()
printing device name, IRQ number, handler functions, and error code on failure
automatically.

Co-developed-by: Yangtao Li 
Signed-off-by: Yangtao Li 
Signed-off-by: Pan Chuang 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/all/20250805092922.135500-2-panchuang@vivo.com

genirq/devres: Don't free interrupt which is not managed by devres

2024-10-24T09:20:06+00:00

If devres_destroy() does not find a matching devres entry, then
devm_free_irq() emits a warning and tries to free the interrupt.

That's wrong as devm_free_irq() should only undo what devm_request_irq()
set up.

Replace devres_destroy() with a call to devres_release() which only invokes
the release function (free_irq()) in case that a matching devres entry was
found.

[ tglx: Massaged change log ]

Signed-off-by: Zijun Hu 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/all/20241018-devres_kernel_fix-v2-1-08918ae84982@quicinc.com

irqdomain: Add a resource managed version of irq_domain_instantiate()

2024-06-17T13:48:14+00:00

Add a devres version of irq_domain_instantiate().

Signed-off-by: Herve Codina 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/r/20240614173232.1184015-17-herve.codina@bootlin.com

genirq/devres: Use struct_size() in devm_kzalloc()

2019-04-16T19:54:03+00:00

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = devm_kzalloc(dev, size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper.

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Thomas Gleixner 
Link: https://lkml.kernel.org/r/20190410170914.GA16161@embeddedor

genirq/devres: Remove excess parameter from kernel doc

2019-03-22T12:34:12+00:00

Building with 'make W=1' complains:

  CC      kernel/irq/devres.o
kernel/irq/devres.c:104: warning: Excess function parameter 'thread_fn'
			 description in 'devm_request_any_context_irq'

Remove it.

Signed-off-by: Valdis Kletnieks 
Signed-off-by: Thomas Gleixner 
Link: https://lkml.kernel.org/r/31207.1552378676@turing-police

genirq/core: Introduce struct irq_affinity_desc

2018-12-19T10:32:08+00:00

The interrupt affinity management uses straight cpumask pointers to convey
the automatically assigned affinity masks for managed interrupts. The core
interrupt descriptor allocation also decides based on the pointer being non
NULL whether an interrupt is managed or not.

Devices which use managed interrupts usually have two classes of
interrupts:

  - Interrupts for multiple device queues
  - Interrupts for general device management

Currently both classes are treated the same way, i.e. as managed
interrupts. The general interrupts get the default affinity mask assigned
while the device queue interrupts are spread out over the possible CPUs.

Treating the general interrupts as managed is both a limitation and under
certain circumstances a bug. Assume the following situation:

 default_irq_affinity = 4..7

So if CPUs 4-7 are offlined, then the core code will shut down the device
management interrupts because the last CPU in their affinity mask went
offline.

It's also a limitation because it's desired to allow manual placement of
the general device interrupts for various reasons. If they are marked
managed then the interrupt affinity setting from both user and kernel space
is disabled.

To remedy that situation it's required to convey more information than the
cpumasks through various interfaces related to interrupt descriptor
allocation.

Instead of adding yet another argument, create a new data structure
'irq_affinity_desc' which for now just contains the cpumask. This struct
can be expanded to convey auxilliary information in the next step.

No functional change, just preparatory work.

[ tglx: Simplified logic and clarified changelog ]

Suggested-by: Thomas Gleixner 
Suggested-by: Bjorn Helgaas 
Signed-off-by: Dou Liyang 
Signed-off-by: Thomas Gleixner 
Cc: linux-pci@vger.kernel.org
Cc: kashyap.desai@broadcom.com
Cc: shivasharan.srikanteshwara@broadcom.com
Cc: sumit.saxena@broadcom.com
Cc: ming.lei@redhat.com
Cc: hch@lst.de
Cc: douliyang1@huawei.com
Link: https://lkml.kernel.org/r/20181204155122.6327-2-douliyangs@gmail.com

genirq: Add missing SPDX identifiers

2018-03-20T13:23:28+00:00

Add SPDX identifiers to files

 - which contain an explicit license boiler plate or reference

 - which do not contain a license reference and were not updated in the
   initial SPDX conversion because the license was deduced by the scanners
   via EXPORT_SYMBOL_GPL as GPL2.0 only.

[ tglx: Moved adding identifiers from the patch which removes the
  	references/boilerplate ]

Signed-off-by: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Greg Kroah-Hartman 
Cc: Philippe Ombredanne 
Link: https://lkml.kernel.org/r/20180314212030.668321222@linutronix.de

irq/generic-chip: Provide devm_irq_setup_generic_chip()

2017-06-21T13:53:11+00:00

Provide a resource managed variant of irq_setup_generic_chip().

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Thomas Gleixner 
Acked-by: Marc Zyngier 
Cc: linux-doc@vger.kernel.org
Cc: Jonathan Corbet 
Link: http://lkml.kernel.org/r/1496246820-13250-6-git-send-email-brgl@bgdev.pl

irq/generic-chip: Provide devm_irq_alloc_generic_chip()

2017-06-21T13:53:11+00:00

Provide a resource managed variant of irq_alloc_generic_chip().

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Thomas Gleixner 
Acked-by: Marc Zyngier 
Cc: linux-doc@vger.kernel.org
Cc: Jonathan Corbet 
Link: http://lkml.kernel.org/r/1496246820-13250-5-git-send-email-brgl@bgdev.pl

genirq/devres: Use dev_name(dev) as default for devname

2017-02-12T18:49:25+00:00

Allow the devname parameter to be NULL and use dev_name(dev) in this case.
This should be an appropriate default for most use cases.

Signed-off-by: Heiner Kallweit 
Link: http://lkml.kernel.org/r/05c63d67-30b4-7026-02d5-ce7fb7bc185f@gmail.com
Signed-off-by: Thomas Gleixner