linux.git/kernel/locking/locktorture.c, branch v6.6.131

torture: Add lock_torture writer_fifo module parameter

2023-08-14T22:01:07+00:00

This commit adds a module parameter that causes the locktorture writer
to run at real-time priority.

To use it:
insmod /lib/modules/torture.ko random_shuffle=1
insmod /lib/modules/locktorture.ko torture_type=mutex_lock rt_boost=1 rt_boost_factor=50 nested_locks=3 writer_fifo=1
													^^^^^^^^^^^^^

A predecessor to this patch has been helpful to uncover issues with the
proxy-execution series.

[ paulmck: Remove locktorture-specific code from kernel/torture.c. ]

Cc: "Paul E. McKenney" 
Cc: Josh Triplett 
Cc: Joel Fernandes 
Cc: Juri Lelli 
Cc: Valentin Schneider 
Cc: kernel-team@android.com
Signed-off-by: Dietmar Eggemann 
[jstultz: Include header change to build, reword commit message]
Signed-off-by: John Stultz 
Acked-by: Davidlohr Bueso 
Signed-off-by: Paul E. McKenney

locktorture: Add long_hold to adjust lock-hold delays

2023-05-11T20:46:36+00:00

This commit adds a long_hold module parameter to allow testing diagnostics
for excessive lock-hold times.  Also adjust torture_param() invocations
for longer line length while in the area.

Signed-off-by: Paul E. McKenney 
Reviewed-by: Joel Fernandes (Google)

locktorture: Add raw_spinlock* torture tests for PREEMPT_RT kernels

2023-03-07T18:13:57+00:00

In PREEMPT_RT kernels, both spin_lock() and spin_lock_irq() are converted
to sleepable rt_spin_lock().  This means that the interrupt related
suffixes for spin_lock/unlock(_irq, irqsave/irqrestore) do not affect
the CPU's interrupt state. This commit therefore adds raw spin-lock
torture tests.  This in turn permits pure spin locks to be tested in
PREEMPT_RT kernels.

Suggested-by: Paul E. McKenney 
Suggested-by: Davidlohr Bueso 
Signed-off-by: Zqiang 
Reviewed-by: Davidlohr Bueso 
Signed-off-by: Paul E. McKenney

locktorture: With nested locks, occasionally skip main lock

2023-03-07T18:13:57+00:00

If we're using nested locking to stress things, occasionally
skip taking the main lock, so that we can get some different
contention patterns between the writers (to hopefully get two
disjoint blocked trees)

Cc: Davidlohr Bueso 
Cc: "Paul E. McKenney" 
Cc: Josh Triplett 
Cc: Joel Fernandes 
Cc: Juri Lelli 
Cc: Valentin Schneider 
Cc: Dietmar Eggemann 
Cc: kernel-team@android.com
Co-developed-by: Connor O'Brien 
Signed-off-by: Connor O'Brien 
Signed-off-by: John Stultz 
Signed-off-by: Paul E. McKenney

locktorture: Add nested locking to rtmutex torture tests

2023-03-07T18:13:57+00:00

This patch adds randomized nested locking to the rtmutex torture
tests. Additionally it adds LOCK09 config files for testing
rtmutexes with nested locking.

Cc: Davidlohr Bueso 
Cc: "Paul E. McKenney" 
Cc: Josh Triplett 
Cc: Joel Fernandes 
Cc: Juri Lelli 
Cc: Valentin Schneider 
Cc: Dietmar Eggemann 
Cc: kernel-team@android.com
Reviewed-by: Davidlohr Bueso 
Co-developed-by: Connor O'Brien 
Signed-off-by: Connor O'Brien 
Signed-off-by: John Stultz 
Signed-off-by: Paul E. McKenney

locktorture: Add nested locking to mutex torture tests

2023-03-07T18:13:57+00:00

This patch adds randomized nested locking to the mutex torture
tests, as well as new LOCK08 config files for testing mutexes
with nested locking

Cc: Davidlohr Bueso 
Cc: "Paul E. McKenney" 
Cc: Josh Triplett 
Cc: Joel Fernandes 
Cc: Juri Lelli 
Cc: Valentin Schneider 
Cc: Dietmar Eggemann 
Cc: kernel-team@android.com
Reviewed-by: Davidlohr Bueso 
Co-developed-by: Connor O'Brien 
Signed-off-by: Connor O'Brien 
Signed-off-by: John Stultz 
Signed-off-by: Paul E. McKenney

locktorture: Add nested_[un]lock() hooks and nlocks parameter

2023-03-07T18:13:57+00:00

In order to extend locktorture to support lock nesting, add
nested_lock() and nested_unlock() hooks to the torture ops.

These take a 32bit lockset mask which is generated at random,
so some number of locks will be taken before the main lock is
taken and released afterwards.

Additionally, add nested_locks module parameter to allow
specifying the number of nested locks to be used.

This has been helpful to uncover issues in the proxy-exec
series development.

This was inspired by locktorture extensions originally implemented
by Connor O'Brien, for stress testing the proxy-execution series:
  https://lore.kernel.org/lkml/20221003214501.2050087-12-connoro@google.com/

Cc: Davidlohr Bueso 
Cc: "Paul E. McKenney" 
Cc: Josh Triplett 
Cc: Joel Fernandes 
Cc: Juri Lelli 
Cc: Valentin Schneider 
Cc: Dietmar Eggemann 
Cc: kernel-team@android.com
Reviewed-by: Davidlohr Bueso 
Co-developed-by: Connor O'Brien 
Signed-off-by: Connor O'Brien 
Signed-off-by: John Stultz 
Signed-off-by: Paul E. McKenney

locktorture: Make the rt_boost factor a tunable

2023-01-05T20:10:35+00:00

The rt boosting in locktorture has a factor variable s currently large enough
that boosting only happens once every minute or so. Add a tunable to reduce the
factor so that boosting happens more often, to test paths and arrive at failure
modes earlier. With this change, I can set the factor to like 50 and have the
boosting happens every 10 seconds or so.

Tested with boot parameters:
locktorture.torture_type=mutex_lock
locktorture.onoff_interval=1
locktorture.nwriters_stress=8
locktorture.stutter=0
locktorture.rt_boost=1
locktorture.rt_boost_factor=50
locktorture.nlocks=3

Signed-off-by: Joel Fernandes (Google) 
Reviewed-by: Davidlohr Bueso 
Signed-off-by: Paul E. McKenney

locktorture: Allow non-rtmutex lock types to be boosted

2023-01-05T20:10:35+00:00

Currently RT boosting is only done for rtmutex_lock, however with proxy
execution, we also have the mutex_lock participating in priorities. To
exercise the testing better, add RT boosting to other lock testing types
as well, using a new knob (rt_boost).

Tested with boot parameters:
locktorture.torture_type=mutex_lock
locktorture.onoff_interval=1
locktorture.nwriters_stress=8
locktorture.stutter=0
locktorture.rt_boost=1
locktorture.rt_boost_factor=1
locktorture.nlocks=3

Signed-off-by: Joel Fernandes (Google) 
Signed-off-by: Paul E. McKenney

locktorture,rcutorture,torture: Always log error message

2021-12-08T00:36:17+00:00

Unconditionally log messages corresponding to errors.

Acked-by: Davidlohr Bueso 
Signed-off-by: Li Zhijian 
Signed-off-by: Paul E. McKenney