linux.git/kernel/time/tick-broadcast.c, branch v5.3.2

tick: Fix typos in comments

2019-04-19T17:17:04+00:00

Signed-off-by: Laurent Gauthier 
Cc: Frederic Weisbecker 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Signed-off-by: Ingo Molnar

tick/broadcast: Fix warning about undefined tick_broadcast_oneshot_offline()

2019-03-29T13:13:44+00:00

Randconfig builds with

  CONFIG_TICK_ONESHOT=y
  CONFIG_HOTPLUG_CPU=n

trigger

  kernel/time/tick-broadcast.c:39:13: warning: ‘tick_broadcast_oneshot_offline’ \
	  declared ‘static’ but never defined [-Wunused-function]

due to that function's definition missing.

Move the CONFIG_HOTPLUG_CPU ifdeffery around its declaration too.

Fixes: 1b72d4323798 ("tick: Remove outgoing CPU from broadcast masks")
Signed-off-by: Borislav Petkov 
Acked-by: Thomas Gleixner 
Reviewed-by: Mukesh Ojha 
Cc: Valentin Schneider 
Cc: Frederic Weisbecker 
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20190329110508.6621-1-bp@alien8.de

tick: Remove outgoing CPU from broadcast masks

2019-03-23T17:26:43+00:00

Valentin reported that unplugging a CPU occasionally results in a warning
in the tick broadcast code which is triggered when an offline CPU is in the
broadcast mask.

This happens because the outgoing CPU is not removing itself from the
broadcast masks, especially not from the broadcast_force_mask. The removal
happens on the control CPU after the outgoing CPU is dead. It's a long
standing issue, but the warning is harmless.

Rework the hotplug mechanism so that the outgoing CPU removes itself from
the broadcast masks after disabling interrupts and removing itself from the
online mask.

Reported-by: Valentin Schneider 
Signed-off-by: Thomas Gleixner 
Tested-by: Valentin Schneider 
Cc: Frederic Weisbecker 
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1903211540180.1784@nanos.tec.linutronix.de

timers: Mark expected switch fall-throughs

2019-01-29T19:08:42+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where fall through is indeed expected.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Thomas Gleixner 
Cc: Frederic Weisbecker 
Cc: John Stultz 
Cc: Stephen Boyd 
Link: https://lkml.kernel.org/r/20190123081413.GA3949@embeddedor

hrtimers/tick/clockevents: Remove sloppy license references

2018-11-23T10:51:21+00:00

"For licencing details see kernel-base/COPYING" and similar license
references have no value over the SPDX identifier. Remove them.

Signed-off-by: Thomas Gleixner 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Peter Anvin 
Cc: Russell King 
Cc: Richard Cochran 
Cc: "Paul E. McKenney" 
Cc: Nicolas Pitre 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Link: https://lkml.kernel.org/r/20181031182252.963632760@linutronix.de

time: Add SPDX license identifiers

2018-11-23T10:51:20+00:00

Update the time(r) core files files with the correct SPDX license
identifier based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can be used instead of the
full boiler plate text.

This work is based on a script and data from Philippe Ombredanne, Kate
Stewart and myself. The data has been created with two independent license
scanners and manual inspection.

The following files do not contain any direct license information and have
been omitted from the big initial SPDX changes:

  timeconst.bc: The .bc files were not touched
  time.c, timer.c, timekeeping.c: Licence was deduced from EXPORT_SYMBOL_GPL

As those files do not contain direct license references they fall under the
project license, i.e. GPL V2 only.

Signed-off-by: Thomas Gleixner 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Russell King 
Cc: Richard Cochran 
Cc: Nicolas Pitre 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Cc: H. Peter Anvin 
Cc: Paul E. McKenney 
Link: https://lkml.kernel.org/r/20181031182252.879109557@linutronix.de

time: Remove useless filenames in top level comments

2018-11-23T10:51:20+00:00

Remove the pointless filenames in the top level comments. They have no
value at all and just occupy space. While at it tidy up some of the
comments and remove a stale one.

Signed-off-by: Thomas Gleixner 
Acked-by: Nicolas Pitre 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Peter Anvin 
Cc: Russell King 
Cc: Richard Cochran 
Cc: "Paul E. McKenney" 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Link: https://lkml.kernel.org/r/20181031182252.794898238@linutronix.de

tick/broadcast: Remove redundant check

2018-09-28T20:29:35+00:00

tick_device_is_functional() is called early in tick_broadcast_control(), so
no need to call it again later.

Signed-off-by: Peng Hao 
Signed-off-by: Thomas Gleixner 
Cc: fweisbec@gmail.com
Link: https://lkml.kernel.org/r/1538150608-2599-1-git-send-email-penghao122@sina.com.cn

tick/broadcast: Use for_each_cpu() specially on UP kernels

2018-05-15T20:45:54+00:00

for_each_cpu() unintuitively reports CPU0 as set independent of the actual
cpumask content on UP kernels. This causes an unexpected PIT interrupt
storm on a UP kernel running in an SMP virtual machine on Hyper-V, and as
a result, the virtual machine can suffer from a strange random delay of 1~20
minutes during boot-up, and sometimes it can hang forever.

Protect if by checking whether the cpumask is empty before entering the
for_each_cpu() loop.

[ tglx: Use !IS_ENABLED(CONFIG_SMP) instead of #ifdeffery ]

Signed-off-by: Dexuan Cui 
Signed-off-by: Thomas Gleixner 
Cc: Josh Poulson 
Cc: "Michael Kelley (EOSG)" 
Cc: Peter Zijlstra 
Cc: Frederic Weisbecker 
Cc: stable@vger.kernel.org
Cc: Rakib Mullick 
Cc: Jork Loeser 
Cc: Greg Kroah-Hartman 
Cc: Andrew Morton 
Cc: KY Srinivasan 
Cc: Linus Torvalds 
Cc: Alexey Dobriyan 
Cc: Dmitry Vyukov 
Link: https://lkml.kernel.org/r/KL1P15301MB000678289FE55BA365B3279ABF990@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM
Link: https://lkml.kernel.org/r/KL1P15301MB0006FA63BC22BEB64902EAA0BF930@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM

tick/broadcast: Make tick_broadcast_setup_oneshot() static

2017-06-12T16:56:01+00:00

This function isn't used outside of tick-broadcast.c, so let's
mark it static.

Signed-off-by: Stephen Boyd 
Link: http://lkml.kernel.org/r/20170608063603.13276-1-sboyd@codeaurora.org
Signed-off-by: Thomas Gleixner