linux.git/lib/string.c, branch v2.6.17.10

[PATCH] Silence a const vs non-const warning

2006-04-11T13:18:42+00:00

lib/string.c: In function 'memcpy':
lib/string.c:470: warning: initialization discards qualifiers from pointer =
target type

Signed-off-by: Jan-Benedict Glaw 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Clean up arch-overrides in linux/string.h

2006-04-11T13:18:40+00:00

Some string functions were safely overrideable in lib/string.c, but their
corresponding declarations in linux/string.h were not.  Correct this, and
make strcspn overrideable.

Odds of someone wanting to do optimized assembly of these are small, but
for the sake of cleanliness, might as well bring them into line with the
rest of the file.

Signed-off-by: Kyle McMartin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] No arch-specific strpbrk implementations

2006-04-11T13:18:40+00:00

While cleaning up parisc_ksyms.c earlier, I noticed that strpbrk wasn't
being exported from lib/string.c.  Investigating further, I noticed a
changeset that removed its export and added it to _ksyms.c on a few more
architectures.  The justification was that "other arches do it."

I think this is wrong, since no architecture currently defines
__HAVE_ARCH_STRPBRK, there's no reason for any of them to be exporting it
themselves.  Therefore, consolidate the export to lib/string.c.

Signed-off-by: Kyle McMartin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] multiple exports of strpbrk

2006-03-22T15:53:56+00:00

Sam's tree includes a new check, which found that we're exporting strpbrk()
multiple times.

It seems that the convention is that this is exported from the arch files, so
reove the lib/string.c export.

Cc: Sam Ravnborg 
Cc: Yoshinori Sato 
Cc: David Howells 
Cc: Greg Ungerer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] lib/string.c cleanup: restore useful memmove const

2005-10-31T01:37:27+00:00

A couple of (char *) casts removed in a previous cleanup patch in
lib/string.c:memmove() were actually useful, as they suppressed a couple of
warnings:

	assignment discards qualifiers from pointer target type

Fix by declaring the local variable const in the first place, so casts
aren't needed to strip the const qualifier.

Signed-off-by: Paul Jackson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] lib/string.c cleanup: remove pointless explicit casts

2005-10-31T01:37:19+00:00

The first two hunks of the patch really belongs in patch 1, but I missed
them on the first pass and instead of redoing all 3 patches I stuck them in
this one.

Signed-off-by: Jesper Juhl 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] lib/string.c cleanup: remove pointless register keyword

2005-10-31T01:37:19+00:00

Removes a few pointless register keywords.  register is merely a compiler
hint that access to the variable should be optimized, but gcc (3.3.6 in my
case) generates the exact same code with and without the keyword, and even
if gcc did something different with register present I think it is doubtful
we would want to optimize access to these variables - especially since this
is generic library code and there are supposed to be optimized versions in
asm/ for anything that really matters speed wise.

(akpm: iirc, keyword register is a gcc no-op unless using -O0)

Signed-off-by: Jesper Juhl 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] lib/string.c cleanup: whitespace and CodingStyle cleanups

2005-10-31T01:37:19+00:00

Removes some blank lines, removes some trailing whitespace, adds spaces
after commas and a few similar changes.

Signed-off-by: Jesper Juhl 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] documentation for strncpy()

2005-05-05T23:36:50+00:00

this clarifies the documentation on the behavier of strncpy().

Signed-off-by: Domen Puncer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] x86_64: make string func definition work as intended

2005-05-05T23:36:33+00:00

In include/asm-x86_64/string.h there are such comments:

/* Use C out of line version for memcmp */
#define memcmp __builtin_memcmp
int memcmp(const void * cs,const void * ct,size_t count);

This would mean that if the compiler does not decide to use __builtin_memcmp,
it emits a call to memcmp to be satisfied by the C out-of-line version in
lib/string.c.  What happens is that after preprocessing, in lib/string.i you
may find the definition of "__builtin_strcmp".

Actually, by accident, in the object you will find the definition of strcmp
and such (maybe a trick intended to redirect calls to __builtin_memcmp to the
default memcmp when the definition is not expanded); however, this particular
case is not a documented feature as far as I can see.

Also, the EXPORT_SYMBOL does not work, so it's duplicated in the arch.

I simply added some #undef to lib/string.c and removed the (now duplicated)
exports in x86-64 and UML/x86_64 subarchs (the second ones are introduced by
another patch I just posted for -mm).

Signed-off-by: Paolo 'Blaisorblade' Giarrusso 
CC: Andi Kleen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds