linux.git/mm/sparse.c, branch v4.19.259

mm/sparse: add the missing sparse_buffer_fini() in error branch

2021-05-22T08:59:38+00:00

[ Upstream commit 2284f47fe9fe2ed2ef619e5474e155cfeeebd569 ]

sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or a
WARN issue would be through the next time sparse_buffer_init() runs.

Add the missing sparse_buffer_fini() in error branch.

Link: https://lkml.kernel.org/r/20210325113155.118574-1-wangwensheng4@huawei.com
Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()")
Signed-off-by: Wang Wensheng 
Reviewed-by: David Hildenbrand 
Reviewed-by: Oscar Salvador 
Cc: Pavel Tatashin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Sasha Levin

mm/memory_hotplug: remove "zone" parameter from sparse_remove_one_section

2020-01-29T15:43:26+00:00

commit b9bf8d342d9b443c0d19aa57883d8ddb38d965de upstream.

The parameter is unused, so let's drop it.  Memory removal paths should
never care about zones.  This is the job of memory offlining and will
require more refactorings.

Link: http://lkml.kernel.org/r/20190527111152.16324-12-david@redhat.com
Signed-off-by: David Hildenbrand 
Reviewed-by: Dan Williams 
Reviewed-by: Wei Yang 
Reviewed-by: Oscar Salvador 
Acked-by: Michal Hocko 
Cc: Alex Deucher 
Cc: Andrew Banman 
Cc: Andy Lutomirski 
Cc: Anshuman Khandual 
Cc: Ard Biesheuvel 
Cc: Arun KS 
Cc: Baoquan He 
Cc: Benjamin Herrenschmidt 
Cc: Borislav Petkov 
Cc: Catalin Marinas 
Cc: Chintan Pandya 
Cc: Christophe Leroy 
Cc: Chris Wilson 
Cc: Dave Hansen 
Cc: "David S. Miller" 
Cc: Fenghua Yu 
Cc: Greg Kroah-Hartman 
Cc: Heiko Carstens 
Cc: "H. Peter Anvin" 
Cc: Ingo Molnar 
Cc: Jonathan Cameron 
Cc: Joonsoo Kim 
Cc: Jun Yao 
Cc: "Kirill A. Shutemov" 
Cc: Logan Gunthorpe 
Cc: Mark Brown 
Cc: Mark Rutland 
Cc: Masahiro Yamada 
Cc: Mathieu Malaterre 
Cc: Michael Ellerman 
Cc: Mike Rapoport 
Cc: "mike.travis@hpe.com" 
Cc: Nicholas Piggin 
Cc: Paul Mackerras 
Cc: Pavel Tatashin 
Cc: Peter Zijlstra 
Cc: Qian Cai 
Cc: "Rafael J. Wysocki" 
Cc: Rich Felker 
Cc: Rob Herring 
Cc: Robin Murphy 
Cc: Thomas Gleixner 
Cc: Tony Luck 
Cc: Vasily Gorbik 
Cc: Will Deacon 
Cc: Yoshinori Sato 
Cc: Yu Zhao 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: David Hildenbrand 
Signed-off-by: Greg Kroah-Hartman

mm/memory_hotplug: allow arch_remove_memory() without CONFIG_MEMORY_HOTREMOVE

2020-01-29T15:43:26+00:00

commit 80ec922dbd87fd38d15719c86a94457204648aeb upstream.

-- snip --

Missing arm64 memory hot(un)plug support.

-- snip --

We want to improve error handling while adding memory by allowing to use
arch_remove_memory() and __remove_pages() even if
CONFIG_MEMORY_HOTREMOVE is not set to e.g., implement something like:

	arch_add_memory()
	rc = do_something();
	if (rc) {
		arch_remove_memory();
	}

We won't get rid of CONFIG_MEMORY_HOTREMOVE for now, as it will require
quite some dependencies for memory offlining.

Link: http://lkml.kernel.org/r/20190527111152.16324-7-david@redhat.com
Signed-off-by: David Hildenbrand 
Reviewed-by: Pavel Tatashin 
Cc: Tony Luck 
Cc: Fenghua Yu 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Heiko Carstens 
Cc: Yoshinori Sato 
Cc: Rich Felker 
Cc: Dave Hansen 
Cc: Andy Lutomirski 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Borislav Petkov 
Cc: "H. Peter Anvin" 
Cc: Greg Kroah-Hartman 
Cc: "Rafael J. Wysocki" 
Cc: Michal Hocko 
Cc: David Hildenbrand 
Cc: Oscar Salvador 
Cc: "Kirill A. Shutemov" 
Cc: Alex Deucher 
Cc: "David S. Miller" 
Cc: Mark Brown 
Cc: Chris Wilson 
Cc: Christophe Leroy 
Cc: Nicholas Piggin 
Cc: Vasily Gorbik 
Cc: Rob Herring 
Cc: Masahiro Yamada 
Cc: "mike.travis@hpe.com" 
Cc: Andrew Banman 
Cc: Arun KS 
Cc: Qian Cai 
Cc: Mathieu Malaterre 
Cc: Baoquan He 
Cc: Logan Gunthorpe 
Cc: Anshuman Khandual 
Cc: Ard Biesheuvel 
Cc: Catalin Marinas 
Cc: Chintan Pandya 
Cc: Dan Williams 
Cc: Ingo Molnar 
Cc: Jonathan Cameron 
Cc: Joonsoo Kim 
Cc: Jun Yao 
Cc: Mark Rutland 
Cc: Mike Rapoport 
Cc: Oscar Salvador 
Cc: Robin Murphy 
Cc: Wei Yang 
Cc: Will Deacon 
Cc: Yu Zhao 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: David Hildenbrand 
Signed-off-by: Greg Kroah-Hartman

mm, sparse: pass nid instead of pgdat to sparse_add_one_section()

2020-01-29T15:43:24+00:00

commit 4e0d2e7ef14d9e1c900dac909db45263822b824f upstream.

Since the information needed in sparse_add_one_section() is node id to
allocate proper memory, it is not necessary to pass its pgdat.

This patch changes the prototype of sparse_add_one_section() to pass node
id directly.  This is intended to reduce misleading that
sparse_add_one_section() would touch pgdat.

Link: http://lkml.kernel.org/r/20181204085657.20472-2-richard.weiyang@gmail.com
Signed-off-by: Wei Yang 
Reviewed-by: David Hildenbrand 
Acked-by: Michal Hocko 
Cc: Dave Hansen 
Cc: Oscar Salvador 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: David Hildenbrand 
Signed-off-by: Greg Kroah-Hartman

mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section()

2020-01-29T15:43:24+00:00

commit 83af658898cb292a32d8b6cd9b51266d7cfc4b6a upstream.

pgdat_resize_lock is used to protect pgdat's memory region information
like: node_start_pfn, node_present_pages, etc.  While in function
sparse_add/remove_one_section(), pgdat_resize_lock is used to protect
initialization/release of one mem_section.  This looks not proper.

These code paths are currently protected by mem_hotplug_lock currently but
should there ever be any reason for locking at the sparse layer a
dedicated lock should be introduced.

Following is the current call trace of sparse_add/remove_one_section()

    mem_hotplug_begin()
    arch_add_memory()
       add_pages()
           __add_pages()
               __add_section()
                   sparse_add_one_section()
    mem_hotplug_done()

    mem_hotplug_begin()
    arch_remove_memory()
        __remove_pages()
            __remove_section()
                sparse_remove_one_section()
    mem_hotplug_done()

The comment above the pgdat_resize_lock also mentions "Holding this will
also guarantee that any pfn_valid() stays that way.", which is true with
the current implementation and false after this patch.  But current
implementation doesn't meet this comment.  There isn't any pfn walkers to
take the lock so this looks like a relict from the past.  This patch also
removes this comment.

[richard.weiyang@gmail.com: v4]
  Link: http://lkml.kernel.org/r/20181204085657.20472-1-richard.weiyang@gmail.com
[mhocko@suse.com: changelog suggestion]
Link: http://lkml.kernel.org/r/20181128091243.19249-1-richard.weiyang@gmail.com
Signed-off-by: Wei Yang 
Reviewed-by: David Hildenbrand 
Acked-by: Michal Hocko 
Cc: Dave Hansen 
Cc: Oscar Salvador 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: David Hildenbrand 
Signed-off-by: Greg Kroah-Hartman

mm/sparse: fix a bad comparison

2019-04-05T20:32:58+00:00

[ Upstream commit d778015ac95bc036af73342c878ab19250e01fe1 ]

next_present_section_nr() could only return an unsigned number -1, so
just check it specifically where compilers will convert -1 to unsigned
if needed.

  mm/sparse.c: In function 'sparse_init_nid':
  mm/sparse.c:200:20: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
         ((section_nr >= 0) &&    \
                      ^~
  mm/sparse.c:478:2: note: in expansion of macro
  'for_each_present_section_nr'
    for_each_present_section_nr(pnum_begin, pnum) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
  mm/sparse.c:200:20: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
         ((section_nr >= 0) &&    \
                      ^~
  mm/sparse.c:497:2: note: in expansion of macro
  'for_each_present_section_nr'
    for_each_present_section_nr(pnum_begin, pnum) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
  mm/sparse.c: In function 'sparse_init':
  mm/sparse.c:200:20: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
         ((section_nr >= 0) &&    \
                      ^~
  mm/sparse.c:520:2: note: in expansion of macro
  'for_each_present_section_nr'
    for_each_present_section_nr(pnum_begin + 1, pnum_end) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Link: http://lkml.kernel.org/r/20190228181839.86504-1-cai@lca.pw
Fixes: c4e1be9ec113 ("mm, sparsemem: break out of loops early")
Signed-off-by: Qian Cai 
Reviewed-by: Andrew Morton 
Cc: Dave Hansen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Sasha Levin

mm/sparse: delete old sparse_init and enable new one

2018-08-17T23:20:32+00:00

Rename new_sparse_init() to sparse_init() which enables it.  Delete old
sparse_init() and all the code that became obsolete with.

[pasha.tatashin@oracle.com: remove unused sparse_mem_maps_populate_node()]
  Link: http://lkml.kernel.org/r/20180716174447.14529-6-pasha.tatashin@oracle.com
Link: http://lkml.kernel.org/r/20180712203730.8703-6-pasha.tatashin@oracle.com
Signed-off-by: Pavel Tatashin 
Tested-by: Michael Ellerman 	[powerpc]
Tested-by: Oscar Salvador 
Reviewed-by: Oscar Salvador 
Cc: Pasha Tatashin 
Cc: Abdul Haleem 
Cc: Baoquan He 
Cc: Daniel Jordan 
Cc: Dan Williams 
Cc: Dave Hansen 
Cc: David Rientjes 
Cc: Greg Kroah-Hartman 
Cc: Ingo Molnar 
Cc: Jan Kara 
Cc: Jérôme Glisse 
Cc: "Kirill A. Shutemov" 
Cc: Michal Hocko 
Cc: Souptick Joarder 
Cc: Steven Sistare 
Cc: Vlastimil Babka 
Cc: Wei Yang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm/sparse: add new sparse_init_nid() and sparse_init()

2018-08-17T23:20:32+00:00

sparse_init() requires to temporary allocate two large buffers: usemap_map
and map_map.  Baoquan He has identified that these buffers are so large
that Linux is not bootable on small memory machines, such as a kdump boot.
The buffers are especially large when CONFIG_X86_5LEVEL is set, as they
are scaled to the maximum physical memory size.

Baoquan provided a fix, which reduces these sizes of these buffers, but it
is much better to get rid of them entirely.

Add a new way to initialize sparse memory: sparse_init_nid(), which only
operates within one memory node, and thus allocates memory either in large
contiguous block or allocates section by section.  This eliminates the
need for use of temporary buffers.

For simplified bisecting and review temporarly call sparse_init()
new_sparse_init(), the new interface is going to be enabled as well as old
code removed in the next patch.

Link: http://lkml.kernel.org/r/20180712203730.8703-5-pasha.tatashin@oracle.com
Signed-off-by: Pavel Tatashin 
Reviewed-by: Oscar Salvador 
Tested-by: Oscar Salvador 
Tested-by: Michael Ellerman 	[powerpc]
Cc: Pasha Tatashin 
Cc: Abdul Haleem 
Cc: Baoquan He 
Cc: Daniel Jordan 
Cc: Dan Williams 
Cc: Dave Hansen 
Cc: David Rientjes 
Cc: Greg Kroah-Hartman 
Cc: Ingo Molnar 
Cc: Jan Kara 
Cc: Jérôme Glisse 
Cc: "Kirill A. Shutemov" 
Cc: Michal Hocko 
Cc: Souptick Joarder 
Cc: Steven Sistare 
Cc: Vlastimil Babka 
Cc: Wei Yang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm/sparse: move buffer init/fini to the common place

2018-08-17T23:20:32+00:00

Now that both variants of sparse memory use the same buffers to populate
memory map, we can move sparse_buffer_init()/sparse_buffer_fini() to the
common place.

Link: http://lkml.kernel.org/r/20180712203730.8703-4-pasha.tatashin@oracle.com
Signed-off-by: Pavel Tatashin 
Tested-by: Michael Ellerman 	[powerpc]
Tested-by: Oscar Salvador 
Reviewed-by: Andrew Morton 
Cc: Pasha Tatashin 
Cc: Abdul Haleem 
Cc: Baoquan He 
Cc: Daniel Jordan 
Cc: Dan Williams 
Cc: Dave Hansen 
Cc: David Rientjes 
Cc: Greg Kroah-Hartman 
Cc: Ingo Molnar 
Cc: Jan Kara 
Cc: Jérôme Glisse 
Cc: "Kirill A. Shutemov" 
Cc: Michal Hocko 
Cc: Souptick Joarder 
Cc: Steven Sistare 
Cc: Vlastimil Babka 
Cc: Wei Yang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm/sparse: use the new sparse buffer functions in non-vmemmap

2018-08-17T23:20:32+00:00

non-vmemmap sparse also allocated large contiguous chunk of memory, and if
fails falls back to smaller allocations.  Use the same functions to
allocate buffer as the vmemmap-sparse

Link: http://lkml.kernel.org/r/20180712203730.8703-3-pasha.tatashin@oracle.com
Signed-off-by: Pavel Tatashin 
Tested-by: Michael Ellerman 	[powerpc]
Reviewed-by: Oscar Salvador 
Tested-by: Oscar Salvador 
Cc: Pasha Tatashin 
Cc: Abdul Haleem 
Cc: Baoquan He 
Cc: Daniel Jordan 
Cc: Dan Williams 
Cc: Dave Hansen 
Cc: David Rientjes 
Cc: Greg Kroah-Hartman 
Cc: Ingo Molnar 
Cc: Jan Kara 
Cc: Jérôme Glisse 
Cc: "Kirill A. Shutemov" 
Cc: Michal Hocko 
Cc: Souptick Joarder 
Cc: Steven Sistare 
Cc: Vlastimil Babka 
Cc: Wei Yang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds